Users on Reddit have requested support for adding profit when loot keys are opened/deposited to the bank.

Not much more to say. Closed my client without saving the session and it just deleted the session.

If your not able to auto save the session in that case you could have an option to save it after every X amount of idle time or on logout.

P.S - Love the plugin. Really wish more plugins had the config option and the sidebar position

It seems like this plugin works best for long trips (eg: pvm). It would be great if it didn't always reset every time you opened the bank. If I'm doing any bankstanding activity where I'm constantly opening and closing the bank, the overlay keeps resetting every minute or so which makes it not very useful.

• The concept of a "trip" can be configurable so it doesn't end whenever you open a bank. Maybe provide a few options: bank, idle minutes, manual
• Or make an option so the trip overlay is actually the session stats that are currently in the side panel. Then the trips can be tracked as normal and you'll just end up with hundreds of trips, but you'll get a summary of them in the overlay.

After a little bit of cooking, I had about 50 trips, each with 28 sharks in it. The trips weren't useful but the overall session stats were extremely useful.

Prior art:

• XP Tracker plugin has XP/hr pause/reset after a configurable number of minutes
• Bossing Info plugin has sessions timeout by a configurable number of minutes

Thank you for your consideration! This would make the plugin so much more versatile!

The Static gold drop display mode is great, especially its ability to add up all the drops within a few seconds, but it'd be even better if you could reposition it to be on top of your inventory with the trip profit overlay.

It tracks the bars/items used but not the GP gained when you hand in a sword at Giants' Foundry

https://i.imgur.com/D2djVJj.jpg

A user on reddit reported not seeing static xp drops appearing next to their inventory.

Users on reddit requested tracking soul bearer.

Users on reddit requested adding support for the ring of endurance.

If you have items collected from the gauntlet in your inventory and start a new run, the plugin instantly counts them towards loss, as all the items appear to be "deleted" when entering the challenge. Furthermore, equipped items also appear to be counted towards loss.
Example:

• You have 100 sapphires in your inventory from a previous run. You also have a mystic fire staff equipped.
• Entering the gauntlet, the plugin will highlight the sapphires and staff as red, and report "-50k" loss for the trip/session (price of staff + gems)
• If fake XP drops are enabled, this will also trigger.

However, when you leave the gauntlet these items are counted as profit, so in the end it doesn't affect the overall tracking. New items from looting the chest are tracked accurately. Its a minor issue, but less than ideal. Is having a specific way of handling gauntlet viable, for example ignoring items when entering/leaving?

Finally, here is a screenshot of what the sidebar starts to look like when you have a lot of items in the inventory (The trip windows get squished):

Love the plugin! One of the most polished plugins out there. Also as a developer I'm happy to do the leg work on this issue and submit a PR I just want to get on the same page about your preferred implementation.

In ToA trips could behave slightly differently, the biggest pain-points are:

• using the deposit pot/friendly spirit(not sure which, I can do some testing) will reset the trip, this causes 2-3 trips to be created each raid and I think it would be more intuitive/useful if they were all treated as 1 trip.
• when using the send to bank option on the loot chest it doesn't count towards gains. I can see the argument for this being intended behavior but I don't see why anyone wouldn't want this included in their trip gains.
• support for splits would be nice but admittedly that may be better scoped to a raids specific loot plugin, unfortunately the current ones don't support ToA and I personally prefer to use your plugins UI.
• maybe add support to count death fees, could be a toggle
• would be nice to also include pre-pot in raid trip but this may be tricky

TLDR; Each raid should be considered one trip instead of the current 3.

Let me know what you think, if you think point 1 is out of scope I'll just roll it all into a new plugin. If you're open to these improvements we can strategize about implementation and I'll work on a PR if you like.

While doing herb runs (or any farming runs) and you find yourself needing to open the leprechaun tool bank to grab a plant cure, it starts a new session and splits the herb run (or any farm run) into two sessions. Not sure if it bothers anyone else but I think nobody is using the tool leprechaun for any specific money making methods where you'd necessarily want to track gp gained between every time you open up the leprechaun interface.

(Edit: typo)

This is a really cool plugin! Was trying it at fossil island wyverns and was wondering if you were able to track blood fury charges? Would be cool to see if I'm breaking even when I use blood fury. Thanks for the great plugin

Repro:

• Withdraw a bunch of items from the bank.
• Log off
• Log on to that same account but from another device (eg: mobile)
• Deposit the items in the bank
• Log off
• Log back on to RuneLite where you were originally
• Now the GP Per Hour plugin will show a large loss of GP because it suddenly saw that all the items disappeared.

Suggestion:

When logging on, it should check if the state of all of the tracked inventories has changed, if they have changed, then treat the logon like "banking" and reset everything to this new state and start a new session. If everything is identical to when the user last logged off, then continue as it does currently.

Regardless of having the box checked or not, it will always display the exact number
EDIT: changed nothing in the session and it updated and seemed to resolve itself. Closing issue because its possible something else was causing it

I love your addon, but I noticed that it doesnt take into account if the player dies, say at Vorkath, where you have to pay 100,000 to retrieve the items. Would be a nice feature to have and I wouldnt imagine too difficult to add

Love your plugin! Hoping you can add support for the Blazing Blowpipe.

Would it just require this change on line 1098 of ChargedWeapon.java?

.chargedItemIds(12926 /*TOXIC_BLOWPIPE*/, 28688 /*BLAZING_BLOWPIPE*/)

Blazing Blowpipe (charged) item ID: 28688

https://oldschool.runescape.wiki/w/Blazing_blowpipe#Charged

Users on reddit requested an option to prevent new trips from automatically starting when banking.

Running version 1.1. Chopped log and got this error in the console.

java.lang.NullPointerException: null
	at com.gpperhour.itemcharges.items.U_LogBasket.lambda$new$2(U_LogBasket.java:90)
	at com.gpperhour.itemcharges.ChargedItem.onChatMessage(ChargedItem.java:477)
	at com.gpperhour.itemcharges.ChargedItemManager.lambda$onChatMessage$0(ChargedItemManager.java:148)
	at java.base/java.util.Spliterators$ArraySpliterator.forEachRemaining(Spliterators.java:948)
	at java.base/java.util.stream.ReferencePipeline$Head.forEach(ReferencePipeline.java:658)
	at com.gpperhour.itemcharges.ChargedItemManager.onChatMessage(ChargedItemManager.java:148)
	at net.runelite.client.eventbus.EventBus$Subscriber.invoke(EventBus.java:70)
	at net.runelite.client.eventbus.EventBus.post(EventBus.java:223)
	at net.runelite.client.callback.Hooks.post(Hooks.java:194)
	at gm.al(gm.java:18811)
	at pe.ac(pe.java:19)
	at client.kq(client.java:49047)
	at client.hw(client.java:3098)
	at client.ai(client.java:1124)
	at bb.ad(bb.java:358)
	at bb.run(bb.java:335)
	at java.base/java.lang.Thread.run(Thread.java:829)

Planting a seed inside a pot causes a profit loss event as seeded/watered pots are valueless. If the plant grows into a seedling while in the player's inventory, the value is added back to the session profit. However if the pot is inside the bank and it grows, the value is never added back.

Love the plugin so far, but upon doing some Corrupted Gauntlet runs I notice it subtracts my current gear from the gp per hour once I enter a run, as seen in the linked video:
https://www.youtube.com/watch?v=PrxATpP8xKo

Also more of a curiosity question, is it possible to make the gp/hr box alt-draggable like other UI in runelite? This would be a great ux enhancement instead of manually setting x/y offsets.

Thanks!

as brought up in this comment

As of the update on Feb 21, 2024, Rune Pouches now have a Presets panel which can be viewed in a bank to instantly change out the entire contents of the pouch with another set of runes. When in the bank, if you change presets, the tracker will sometimes think that you just lost all of the runes that were previously in the pouch and just gained all of the new runes you put in the pouch.

The easiest way to reproduce this is to load two totally different pouch presets back to back and it's always reproducible.

It seems like it's not tracking banks correctly since nothing should be tracked as a gain/loss while a bank interface is open.

Would be cool if there was an option to ignore trades. I play with an alt and frequently trade items back and fourth between them. Currently the trades are considered as losses/gains.

Request to be able to configure a hotkey to start a new trip outside of the bank

Upon starting runelite the gp per hour plugin is showing that it is no longer compatible with the current runelite version

Love the plug in! I noticed today while doing forestry that the plugin is not able to accurately track gp gained when logs go into an open basket (sometimes it does though?). Also, when I bank logs with the leprechaun it subtracts the logs from GP gained.

When I'm making super restores with and without an amulet of chemistry, it logs the trip as creating x4s for all the potions instead of x3

Whenever you switch to another tab that isn't the inventory, the trip overlay disappears. I cannot seem to find if any of the settings affect this.

I'm reporting this as a bug because it was surprising/unexpected. But I suspect it was intentionally coded this way. Is there a reason it needs to be only when the inventory is visible? It's very jarring for it to constantly appear and disappear as you switch tabs.

Firstly: Thank you very much for the plugin, I love it!

The only problem I got with it is that my snapdragons that I get on my herb runs won't be counted if if they go into open herb sack.

I can't really track my daily wins/losses because of this.

I hope this can be fixed :)

Using trouver parchment you can lock the divine rune pouch (lets you keep it and contents on death even outside wild)
But the runes stored in the pouch are not tracked

Edits are because I accidentally hit enter when typing the title before I could type the body
Love the plugin gl with your refactoring!

When the number of items in history gets large, the plugin will force the client to resize up to its vertical maximum if in a resizable mode to accommodate the grid instead of causing a scrollbar. On systems with particularly large vertical resolution (e.g. I have 4 3440x1440 ultrawides in a 2x2 grid), this can cause the client to largely go outside the usable area of the monitors. It also prevents the client from being resized any smaller by any means other than switching plugin tabs first, or first hiding the grid, or (ironically) maximizing the window.

Seems pretty easy to repro, other than getting a list of items in the log long enough to force it... here is one such grid that was causing the bad behavior:

I've been tracking this plugin since it seems incredibly well done so I jumped on it as soon as it was released. Unfortunately, it seems like it is partially incompatible with the Customizable XP drops plugin which override the XP drop UI. Instead of showing the coins in profit/loss mode, it shows the following.

Would it be reasonable to ask for either compatibility with that plugin, or a different UI option for your plugin so that it avoids the compatibility issues entirely? A simple solution might be to show the gold drops right next to the trip overlay sort of like this. It would be static, appear for a few seconds, and then disappear. If there was another gold drop before the first one disappeared, the numbers would add together and the disappear time would reset.

Anyway, thank you so much for this amazing plugin. I'm sure you'll come up with something clever to solve this problem.

Similar to how loot tracker allows you to hide or remove an item, let players do the same by right clicking the item and excluding it. This would help the user correct any GP discrepancies, such as receiving a loaned item through a trade.

Similar to other untradeable currencies, it'd be great if anima-bark (from Forestry) could have a value assigned to it.

Note: Most of the time these items go straight into the Forestry kit and not the inventory, so it'd need to be tracked via the chat messages, same way the built-in Woodcutting plugin tracks Bark.

Known/widespread issue, will be fixed pending refactor of how profits/losses are calculated.

The side panel is a little difficult to use on fixed mode, or even small resizable, once enough items have been added. This could be resolved by allowing the entire panel to scroll and not just the trips section.

Users on reddit (ironmen) requested option to show HA value instead of GE value.

Not sure if it was just missed or if it's not working correctly but the ancient essence for venator bow charges is not tracked

Users on reddit requested an option to filter out negative gold drops and only show positive gold drops.

Users on Reddit have requested an option to set brimstone keys value to zero.

Users on reddit requested adding support for bracelet of ethereum.

While using the plugin, I found myself wanting to see my inventory value alongside my session profit, but found no way to set this up to have them side by side. Would be nice to be able to display both at once, instead of just one or the other. For example, having inventory value on the right and session profit on the left.

Using the value of converting the shards to dust which are used for making divine super combats. Currently ~16k each not being tracked.

Fantastic plugin though, thank you so much for making this.

Users on reddit reported an issue with loot not being tracked as profit after using the bank deposit box in the crafting guild (known issue).

Start/ end sessions in overlay are greyed out and i cannot scroll on that side of the hub. a cannot get a session to begin. have tried going and coming from multiple banks.

Unsure if it happens with other npcs but i assume it does. When pickpocketing vyres it wont add the rubys to current session unless you manually check the gem bag every time. It does show up in chat as well.

Users on Reddit have reported that death fees are not tracked as losses.