Giter VIP home page Giter VIP logo

Comments (9)

seeflood avatar seeflood commented on August 15, 2024 1

@ZLBer 本来考虑过加个isSupportCache() 后来改成GetSegment了
GetSegment也能解决你说的问题呀,只想判断是否支持segment、不想取号的话,size传0,GetSegment(0)

from layotto.

seeflood avatar seeflood commented on August 15, 2024 1

这样啊 怪怪的

是有点
其实我原来第一版就写的一个单独的判断函数(叫supportSegement还是啥来着忘了)
后来和其他人讨论,别人觉得没必要单独加一个函数;然后我看了下Dapr state组件的BulkGet 设计风格也是往返回结果里加个support,就改成这样了。当时觉得这种其实是个人喜好问题,没啥对与错,既然Dapr之前是这风格那就保持一致吧,就改了
或者你也可以把你的想法写下,我们下周讨论下

from layotto.

seeflood avatar seeflood commented on August 15, 2024

This task will be assigned to @ZLBer

from layotto.

ZLBer avatar ZLBer commented on August 15, 2024

建议给sequencer增加是否支持segment的方法,现在GetSegment方法功能不够单一, 在写catch的时候发现有时候只想查看sequencer是否支持segment,并不想直接申请一段。

from layotto.

ZLBer avatar ZLBer commented on August 15, 2024

这样啊 怪怪的

from layotto.

seeflood avatar seeflood commented on August 15, 2024

现在实现的话可以先写GetSegment(0) 后面真要改成supportSegment也简单

from layotto.

ZLBer avatar ZLBer commented on August 15, 2024

fine

from layotto.

github-actions avatar github-actions commented on August 15, 2024

This issue has been automatically marked as stale because it has not had recent activity in the last 30 days. It will be closed in the next 7 days unless it is tagged (pinned, good first issue or help wanted) or other activity occurs. Thank you for your contributions.

from layotto.

github-actions avatar github-actions commented on August 15, 2024

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as pinned, good first issue or help wanted. Thank you for your contributions.

from layotto.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.