Comments (4)
dotch
commented on August 28, 2024
we switched to only using ids in all our component selectors.
this is open for discussion as long as we do it consistently across all components!
from brick-tabbar.
potch
commented on August 28, 2024
There aren't plans, but there could be plans! The idea of selectors (which can return more than one element) isn't really DOMy, and encourages things like target-selector='element:nth-child(5):not(.thatone)' which is pretty un-nice.
from brick-tabbar.
sole
commented on August 28, 2024
Right, I see! I don't have a strong opinion on this to be honest. It might be even better to be simpler in that sense.
I'll change the template code to use plain ids.
from brick-tabbar.
potch
commented on August 28, 2024
Alright- strong 'meh' all around! 🎆
from brick-tabbar.
Related Issues (9)
- indicator not moving in safari HOT 1
- Any way to disable/configure the "indicator"? HOT 6
- observe for new tabs being added and adjust the indicator size HOT 1
- Link back from target on show event
- tabs parameter doesn't exist HOT 2
- gaia style for tabbar HOT 1
- Removing a selected tab throws
- CODE_OF_CONDUCT.md file missing
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from brick-tabbar.