mozbrick / brick-tabbar Goto Github PK

I wanted to change the color and appearance of it and it confused me that it wasn't the bottom border of the selected tab, but a div that gets translated when the selected tab changes. Sure I can write a rule for brick-tabbar .selected-indicator but what I have ended up using is

brick-tabbar .selected-indicator {
  background-color: transparent;
}

in order to "disable" it.

I was thinking that perhaps Brick should be more neutral in that sense and make this either an optional feature or (harder to do) convert into a CSS rendering thing only rather than an element that is floating around.

Thoughts?

TypeError: tabEl is null brick-tabbar.js:101:8

It's working well for a tab which isn't selected

brick-tabbar is working great with brick-deck - switches cards without additional JS.
It would be great if would select the according brick-tabbar-tab when brick-deck-card is changed.
To do so it would be good to listen to target's show event.
It would be applicable to other type of targets with just firing this event.

After implementing the tabbar with deck I wanted to iterate by tabs to link them back with cards.

• https://github.com/zalun/school-plan-app/blob/master/stage4/index.html#L34
• https://github.com/zalun/school-plan-app/blob/master/stage4/js/index.js#L19

TypeError: app.planGroupMenu.tabs is undefined

As of January 1 2019, Mozilla requires that all GitHub projects include this CODE_OF_CONDUCT.md file in the project root. The file has two parts:

1. Required Text - All text under the headings Community Participation Guidelines and How to Report, are required, and should not be altered.
2. Optional Text - The Project Specific Etiquette heading provides a space to speak more specifically about ways people can work effectively and inclusively together. Some examples of those can be found on the Firefox Debugger project, and Common Voice. (The optional part is commented out in the raw template file, and will not be visible until you modify and uncomment that part.)

If you have any questions about this file, or Code of Conduct policies and procedures, please reach out to [email protected].

(Message COC001)

Porting existing code from x-tag based tabbar. It appears that I can't use the target-selector attribute anymore and I now need to use an specific id instead of a selector?

Are there plans to bring back this functionality?