mozilla / ad-analysis-for-facebook-disabled Goto Github PK

This "blank" extension consists of a two main pieces of code.

A background script that sets the badge over the toolbar icon.
https://github.com/mozilla/ad-analysis-for-facebook-disabled/blob/master/src/background/background.js

A doorhanger that displays (plain text) messages and shows various links to the users.
https://github.com/mozilla/ad-analysis-for-facebook-disabled/tree/master/src/toolbar/toolbar.html
https://github.com/mozilla/ad-analysis-for-facebook-disabled/tree/master/src/toolbar/toolbar.js
https://github.com/mozilla/ad-analysis-for-facebook-disabled/tree/master/src/toolbar/toolbar.less

Steps to reproduce:

1. Install the extension
2. Click the extension icon
3. Observe the displayed doorhanger

Expected results:

There are no display issues.

Actual results:

There is a scroll bar displayed in right side of the doorhanger.

Notes Issues:

Issue can be reproduced on Win7x64, Win10x64, Ubuntu 14.04 when using FF release, beta or nightly
Please view the screenshot of this issue:

Update the text and links in the doorhanger.

QA test plan is located at:
https://github.com/mozilla/ad-analysis-for-facebook-disabled/blob/master/qa-test-plan.md

Terser v3.16.0 released three days ago (Feb 2) broke Webpack. I've included [email protected] in the package.json as a workaround. See webpack-contrib/terser-webpack-plugin#66 for both the issue and the workaround.

Remove the workaround when we can confirm that the latest terser is compatible with Webpack.

FYI: The following changes were made to this repository's wiki:

• defacing spam has been removed

• Restricting write access to contributors is strongly encouraged. Please make that change (documentation).

These were made as the result of a recent automated defacement of publically writeable wikis.

• Code by @jcchuang
  • Toolbar icon
  • Badge
  • Grey out after first use #5
• Copy by @mheubusch #3
• Design review
• Legal review
• Code review by @biancadanforth #2
• QA review by @madalincm #1
• Bugs and Workarounds
  • Remove terser workaround after [email protected] broke webpack on Feb 2nd #7
  • Remove unnecessary scrollbar per QA testing #8
• Publish
  • Upload the extension to AMO
  • Update AMO listing
  • Turn this repository public #4

As of January 1 2019, Mozilla requires that all GitHub projects include this CODE_OF_CONDUCT.md file in the project root. The file has two parts:

1. Required Text - All text under the headings Community Participation Guidelines and How to Report, are required, and should not be altered.
2. Optional Text - The Project Specific Etiquette heading provides a space to speak more specifically about ways people can work effectively and inclusively together. Some examples of those can be found on the Firefox Debugger project, and Common Voice. (The optional part is commented out in the raw template file, and will not be visible until you modify and uncomment that part.)

If you have any questions about this file, or Code of Conduct policies and procedures, please see Mozilla-GitHub-Standards or email [email protected].

(Message COC001)