mozilla / aframe-xr Goto Github PK

View Code? Open in Web Editor NEW

182.0 182.0 40.0 1.88 MB

System / Components to build WebXR experiences with A-frame

Home Page: https://mozilla.github.io/aframe-xr/

License: MIT License

HTML 7.59% JavaScript 92.41%

aframe-xr's People

Contributors

Stargazers

Watchers

aframe-xr's Issues

If `a-scene` has `vr-mode-ui` disabled the WebVR button is still shown

It looks like aframe-xr always enables vr-mode-ui even if the scene has set it to off. The code here:

aframe-xr/dist/aframe-xr.js

Line 192 in 50326e4

addEnterButtons: function addEnterButtons(displays) {

Likely should inspect the value on the scene and use that value instead of the hardcoded true value for vr-mode-ui in the cases where it is being explicitly enabled. I'm happy to cut a PR if this makes sense!

animations do not work

The most basic example works great on desktop, Safari... but somehow not on the XR Viewer. I checked the console (using VorlonJS) and no new error or warning.

<!DOCTYPE html>
<html>
  <head>
    <title>Animation on XR Viewer</title>
    <!-- aframe-xr with dependencies and utils -->
    <script src="https://rawgit.com/mozilla/aframe-xr/master/vendor/aframe-master.js"></script>
    <script src="https://rawgit.com/mozilla/aframe-xr/master/vendor/three.xr.js"></script>
    <script src="https://rawgit.com/mozilla/aframe-xr/master/dist/aframe-xr.js"></script>
  </head>
  <body>

    <a-scene hit-test>
        <a-sphere color="red" radius="0.1" position="5 0 -1">
                <a-animation attribute="radius" dur="1000" fill="forwards" to="0.0001" repeat="indefinite">
                </a-animation>
        </a-sphere>
      
    </a-scene>
  </body>
</html>

Same issue using the dedicated animation component. Is the tick handler behaving as expected?

Add `<meta>` tag for `https://mozilla.github.io` Origin-Trial token

Without needing a user to enable the flags for Cardboard or Daydream modes, I would recommend enrolling in the WebVR Origin Trial for Chrome for Android.

CODE_OF_CONDUCT.md file missing

As of January 1 2019, Mozilla requires that all GitHub projects include this CODE_OF_CONDUCT.md file in the project root. The file has two parts:

Required Text - All text under the headings Community Participation Guidelines and How to Report, are required, and should not be altered.
Optional Text - The Project Specific Etiquette heading provides a space to speak more specifically about ways people can work effectively and inclusively together. Some examples of those can be found on the Firefox Debugger project, and Common Voice. (The optional part is commented out in the raw template file, and will not be visible until you modify and uncomment that part.)

If you have any questions about this file, or Code of Conduct policies and procedures, please see Mozilla-GitHub-Standards or email [email protected].

(Message COC001)

examples wont work on current version of chrome

Running the examples on chrome 83 on samsung galaxy A40 show only a white screen with some text.

Warning component for non supported browser

Assuming that this there will still be a transition period for main browsers to include the WebXR API proper and that no polyfill will be sufficient (unlike for WebVR and A-frame) having a warning message to suggest XR Viewer, WebARonARKit or WebARonARCore would be useful.

More projects relying aframe-xr at such an early stage will most likely always have to educate and explain those steps to the users (arguably testers at this point), having a shared component for this would be useful to most.

xr component shouldn't search for a-scene

aframe components should not search for the a-scene dom element, they should use their own sceneEl.

instead of registering for a "loaded" message, and then in that searching for the a-scene, why not just register for the "realityChanged" event in init?

There is no ROADMAP.md laying down plans for future releases

Even though https://github.com/aframevr/aframe/blob/master/ROADMAP.md wasn't always realistic (cf 0.8 release scheduled for 3 months ago) it still gave a vision to the community at large. Having an equivalent for aframe-xr would give a good sense of where the project is going and eventually when upcoming features or support might get released.

aframe-xr won't load in WebXR-Viewer w/ aframe v0.8.2

Hey everyone,

Ever since upgrading our app from aframe v0.8.1 to v0.8.2, we are experiencing issues with running aframe-xr.
With further debugging we found out that the "enterAR" method won't load the scene correctly and will eventually crash it.
I suspect that it might be caused by an event emitter, but I'm still trying to find out what might cause that.

(note that the app works fine on the WebARonARCore browser)

Tested on iPhone 7, iOS v. 11.3.1 (15E302).
Latest https://github.com/mozilla-mobile/webxr-ios build.

Any ideas where to start looking?

VR view on xr/basic example renders incorrectly on iOS mobile

The scene renders but when VR mode is activated, the scene renders incorrectly. I see strobing white lines when changing the view. On iPhone 6 and 7.

Wiki changes

FYI: The following changes were made to this repository's wiki:

defacing spam has been removed
Restricting write access to contributors is strongly encouraged. Please make that change (documentation).

These were made as the result of a recent automated defacement of publically writeable wikis.

hit-test does not make the position of the added entity instantly available

As briefly discussed with @arturitu , not necessarily a bug but when in https://github.com/mozilla/aframe-xr/blob/master/examples/ar/hit_test/index.html#L35 I try to access the position of the added entity I get 0 0 0 even after a hit.

Results of some naive tests:

//displayCoord(entity); // not OK, getting 0 0 0
// scene.flushToDOM(); displayCoord(entity); // not OK
// entity.flushToDOM(); displayCoord(entity); // not OK
// entity.components.position.flushToDOM(); displayCoord(entity); // not OK

setTimeout( () => { displayCoord(entity); } , 100 ); // always OK
//setTimeout( () => { displayCoord(entity); } , 10 ); // OK the vast majority of the time BUT not always!

This wasn't necessarily the expected usage but the behavior might be surprising for some so suggestions welcomed.

mozilla / aframe-xr Goto Github PK

aframe-xr's People

Contributors

Stargazers

Watchers

Forkers

aframe-xr's Issues

Recommend Projects

Recommend Topics

Recommend Org