Comments (6)
cc @aethanyc
from git-bz-moz.
In the PR, I only fixed the authorship issue.
As to the date issue, since raw diff's lack of authorship and patch creation time, we can only refer to the authorship and creation time from Bugzilla. I think that's the reason why the original implementation treat attachment uploader as the author, and attachment creation time as the patch creation time.
As can be seen in the example, only two possible time can be referred, creation_time
or last_change_time
. IMHO, creation_time
makes more sense to me, so I'm not sure if we should treat the date/time issue as a bug.
from git-bz-moz.
mozreview requests have corresponding mercurial changesets. Those have full authorship information, including date.
from git-bz-moz.
I can't find a trivial way to get the corresponding mercurial changesets... :(
Maybe after Bug 1346321 is fixed, we could get the corresponding mercurial changesets. Then, we can apply the full authorship information accordingly.
from git-bz-moz.
I'll leave the issue open for the more specific request, in case somebody wants to figure out how to do that. #93 will at least improve the situation, and also applies to the case of diffs attached to Bugzilla that have no information.
from git-bz-moz.
mozreview is no more.
from git-bz-moz.
Related Issues (20)
- git bz attach -e HEAD leads to ImportError: No module named auth HOT 5
- Add a way to assign the bug to yourself when attaching a patch HOT 1
- git bz apply adds a bogus "Bug 1234567" to the commit message HOT 3
- ImportError: No module named requests HOT 3
- adding bug #s to commits doesn't check for existing bug numbers HOT 2
- git bz apply should work for bugs with mozreview request attachments HOT 1
- `add-url-ignore-remote-commits = true` should be the default HOT 4
- trying to self-review a patch with :me causes errors HOT 4
- Insufficient detection of conflict when specifying bug number on the command line
- Add testing mode that does not push to bugzilla HOT 2
- `git bz apply` uses `git am` HOT 1
- attach fails with KeyError: 'data' if the bug has a MozReview patch HOT 1
- Remove MozReview cruft from the commit message on export HOT 1
- Unicode decoding error in 'git bz apply' HOT 3
- RuntimeError: git rev-list didn't return a number of lines divisible by 3 HOT 3
- Need better error message when the reviewer doesn't accept the review requests HOT 4
- "git bz apply" treats the virtual/hidden commit-message from MozReview as part of the patch HOT 8
- Cannot git bz apply patches in Bug 1375969 HOT 1
- filing bugs with commits ending in "; r=build-peer" does not strip the r= info for the bug title HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from git-bz-moz.