Giter VIP home page Giter VIP logo

Comments (6)

chenpighead avatar chenpighead commented on June 14, 2024

cc @aethanyc

from git-bz-moz.

chenpighead avatar chenpighead commented on June 14, 2024

In the PR, I only fixed the authorship issue.

As to the date issue, since raw diff's lack of authorship and patch creation time, we can only refer to the authorship and creation time from Bugzilla. I think that's the reason why the original implementation treat attachment uploader as the author, and attachment creation time as the patch creation time.

As can be seen in the example, only two possible time can be referred, creation_time or last_change_time. IMHO, creation_time makes more sense to me, so I'm not sure if we should treat the date/time issue as a bug.

from git-bz-moz.

glandium avatar glandium commented on June 14, 2024

mozreview requests have corresponding mercurial changesets. Those have full authorship information, including date.

from git-bz-moz.

chenpighead avatar chenpighead commented on June 14, 2024

I can't find a trivial way to get the corresponding mercurial changesets... :(
Maybe after Bug 1346321 is fixed, we could get the corresponding mercurial changesets. Then, we can apply the full authorship information accordingly.

from git-bz-moz.

amccreight avatar amccreight commented on June 14, 2024

I'll leave the issue open for the more specific request, in case somebody wants to figure out how to do that. #93 will at least improve the situation, and also applies to the case of diffs attached to Bugzilla that have no information.

from git-bz-moz.

amccreight avatar amccreight commented on June 14, 2024

mozreview is no more.

from git-bz-moz.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.