Comments (8)
zalun
commented on June 3, 2024
1
Download Diff link is fixed - no virtual files included.
from git-bz-moz.
zalun
commented on June 3, 2024
This is a MozReview bug as described in https://bugzilla.mozilla.org/show_bug.cgi?id=1346321#c17
from git-bz-moz.
chenpighead
commented on June 3, 2024
Yeah, since Bug 1346321 has been assigned, I think we can close this issue.
from git-bz-moz.
zalun
commented on June 3, 2024
I think it should be reopened. It would be better to use the patch directly from HG instead of the one from MozReview.
from git-bz-moz.
chenpighead
commented on June 3, 2024
I thought If we could prevent the virtual/hidden commit-message file from showing in the raw diff downloaded by clicking Download Diff on MozReview, this issue could be gone. @zalun, are you saying that Bug 1346321 may not fix this issue?
from git-bz-moz.
zalun
commented on June 3, 2024
This will fix the issue, but using this feature is not the best solution. Code is pushed to HG, then it's loaded to MozReview and analyzed there. Then diff is taken from MozReview objects and provided for download. IMO it would be best to shorten this path. @smacleod suggested HG repository should be used. In the end MozR is just a review tool, the diff should be treated as an additional way to review the code.
from git-bz-moz.
chenpighead
commented on June 3, 2024
IMHO, git-bz-moz is a tool for interacting with Bugzilla only, so it shouldn't be his responsibility to tell whether this patch is from HG or from a fork on MozReview, as long as the patch is what exactly attached to Bugzilla. Since MozReview couldn't provide a copy of the patch on Bugzilla (for reasons like the consistency between MozReview and Bugzilla during the review process), I think at least a link to the patch is pretty reasonable.
Right now, it seems to me that the link to the patch is broken by the new virtual/hidden commit-message feature. The view raw links still point to the HG formatted patch without the virtual/hidden files, however, Download Diff points to a diff including the virtual/hidden files. I think the best way might be correcting the Download Diff link. After all, MozReview already has all the information it needs.
from git-bz-moz.
chenpighead
commented on June 3, 2024
@zalun thank you for fixing this. :-)
from git-bz-moz.
Related Issues (20)
- git bz attach -e HEAD leads to ImportError: No module named auth HOT 5
- Add a way to assign the bug to yourself when attaching a patch HOT 1
- git bz apply adds a bogus "Bug 1234567" to the commit message HOT 3
- ImportError: No module named requests HOT 3
- adding bug #s to commits doesn't check for existing bug numbers HOT 2
- git bz apply should work for bugs with mozreview request attachments HOT 1
- `add-url-ignore-remote-commits = true` should be the default HOT 4
- trying to self-review a patch with :me causes errors HOT 4
- Insufficient detection of conflict when specifying bug number on the command line
- Add testing mode that does not push to bugzilla HOT 2
- `git bz apply` uses `git am` HOT 1
- attach fails with KeyError: 'data' if the bug has a MozReview patch HOT 1
- Remove MozReview cruft from the commit message on export HOT 1
- Unicode decoding error in 'git bz apply' HOT 3
- RuntimeError: git rev-list didn't return a number of lines divisible by 3 HOT 3
- git bz apply should get mozreview patch information from hg changeset HOT 6
- Need better error message when the reviewer doesn't accept the review requests HOT 4
- Cannot git bz apply patches in Bug 1375969 HOT 1
- filing bugs with commits ending in "; r=build-peer" does not strip the r= info for the bug title HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from git-bz-moz.