This might be an artifact of my local dev env, but I'm seeing the following error:
...
2019-07-18 20:38:50 INFO MainThread mozdep.detectors.retirejs RetireDependency adding `third_party/webkit/PerformanceTests/Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/jquery/dist
/jquery.min.js`
2019-07-18 20:38:50 DEBUG MainThread mozdep.detectors.retirejs Processing file /home/gguthe/mozilla-unified/third_party/webkit/PerformanceTests/Speedometer/resources/todomvc/dependency-examples/flight/flight/nod
e_modules/jquery/dist/jquery.min.js
2019-07-18 20:38:50 DEBUG MainThread mozdep.detectors.retirejs Updating existing vulnerability node for CVE-2015-9251
2019-07-18 20:38:50 DEBUG MainThread mozdep.detectors.retirejs Updating existing vulnerability node for CVE-2015-9251
2019-07-18 20:38:50 DEBUG MainThread mozdep.detectors.retirejs Updating existing vulnerability node for CVE-2019-11358
Traceback (most recent call last):
File "/home/gguthe/mozilla-unified/mozilla-depends/venv/bin/mozdep", line 11, in <module>
load_entry_point('mozdep', 'console_scripts', 'mozdep')()
File "/home/gguthe/mozilla-unified/mozilla-depends/utils/mozdep/main.py", line 107, in main
result = command.run(args, tmp_dir)
File "/home/gguthe/mozilla-unified/mozilla-depends/utils/mozdep/command/__init__.py", line 44, in run
result = current_command.run()
File "/home/gguthe/mozilla-unified/mozilla-depends/utils/mozdep/command/detect.py", line 54, in run
run_all(repo_dir, g, choice=self.args.detector)
File "/home/gguthe/mozilla-unified/mozilla-depends/utils/mozdep/detectors/__init__.py", line 78, in run_all
ret = run(detector.name(), tree, graph)
File "/home/gguthe/mozilla-unified/mozilla-depends/utils/mozdep/detectors/__init__.py", line 53, in run
current_detector.run()
File "/home/gguthe/mozilla-unified/mozilla-depends/utils/mozdep/detectors/retirejs.py", line 88, in run
if len(f["results"]) == 0:
TypeError: list indices must be integers or slices, not str
This is against moz-unified @ 540474:a50c36fad95a. For some reason retire is returning an empty list as the last item with JSON output:
$ # from the unified root
$ mozilla-depends/utils/node_modules/.bin/retire --verbose --outputformat json third_party/webkit/PerformanceTests/Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/jquery/dist/jquery.min.js
..."file":"/home/gguthe/mozilla-unified/third_party/webkit/PerformanceTests/Speedometer/
resources/todomvc/dependency-examples/flight/flight/node_modules/flight/lib/utils.js","results":[]},{"file":"/home/gguthe/mozilla-unified/third_party/webkit/P
erformanceTests/Speedometer/resources/todomvc/labs/architecture-examples/react/bower_components/director/build/director.js","results":[]},{"file":"/home/gguth
e/mozilla-unified/third_party/webkit/PerformanceTests/Speedometer/resources/todomvc/labs/architecture-examples/react/bower_components/director/build/director.
min.js","results":[]},{"file":"/home/gguthe/mozilla-unified/third_party/webkit/PerformanceTests/Speedometer/resources/todomvc/labs/architecture-examples/react
/bower_components/director/build/ender.js","results":[]},{"file":"/home/gguthe/mozilla-unified/testing/talos/talos/tests/devtools/addon/content/pages/custom/d
ebugger/static/js/main.js","results":[]},{"file":"/home/gguthe/mozilla-unified/mobile/android/tests/browser/chrome/tp5/bbc.co.uk/static.bbc.co.uk/frameworks/b
arlesque/1.8.15/desktop/3/script/barlesque.js","results":[]},[]]
I have a simple patch I'll submit, but I thought I'd raise the issue for documentation purposes.