json-loader error about neo HOT 6 CLOSED

Found out the webpack core config prevents the webpack "json-loader" to parse the "node_modules" and "bower_components" folders.

For others who might encounter a similar error, here is how to deal with it with a dev.config.jsconfig file:

const dev = require('mozilla-neo/config/webpack.dev');
const { join } = require('path');
const ContextReplacementPlugin = require('webpack').ContextReplacementPlugin;

// http://stackoverflow.com/questions/25384360/how-to-prevent-moment-js-from-loading-locales-with-webpack
// dev.plugins.push(new IgnorePlugin(/^\.\/locale$/, /moment$/));
dev.plugins.push(new ContextReplacementPlugin(/moment[\/\\]locale$/, /en/));


dev.module.loaders[2].include.push(join(process.cwd(), '/node_modules/moment-timezone'));
dev.module.loaders[2].exclude = /((node_modules\/(?!moment-timezone))|bower_components)/;

module.exports = dev;

from neo.

I guess the node_modulesfolders are excluded from the parsers to boost the build process, however it looks like a hack to tune it with a dev.config.jsfile.

@eliperelman don't you think it would be nice to control the excluded folders from the config in package.json?

from neo.

@pierre-b could you confirm if this is still an issue with 2.4.0?

from neo.

Is there any performance downside to not exclude node_modules from the parsers?

from neo.

@eliperelman the json parsing is no more an issue with 2.4.0

from neo.

I think this is resolved, please re-open if still an issue.

from neo.