mozilla / neo Goto Github PK

Right now we use destructuring in Neo code, which can't run natively prior to v6. I think with a few changes we could support earlier versions.

to run tests in continuous mode

After creating a new project using neo v2.2.0, running "neo test" results in build errors related to loading JSON files. Running dev mode works fine.

ERROR in .//cheerio/package.json
Module build failed: SyntaxError: Unexpected token m in JSON at position 0
at Object.parse (native)
at Object.module.exports (/home/derekho/LikeMindNetworks/prototypes/react-proto/node_modules/json-loader/index.js:7:48)
@ .//cheerio/index.js 11:18-38

ERROR in .//css-select/lib/procedure.json
Module build failed: SyntaxError: Unexpected token m in JSON at position 0
at Object.parse (native)
at Object.module.exports (/home/derekho/LikeMindNetworks/prototypes/react-proto/node_modules/json-loader/index.js:7:48)
@ .//css-select/lib/compile.js 17:18-45

ERROR in .//entities/maps/xml.json
Module build failed: SyntaxError: Unexpected token m in JSON at position 0
at Object.parse (native)
at Object.module.exports (/home/derekho/LikeMindNetworks/prototypes/react-proto/node_modules/json-loader/index.js:7:48)
@ .//htmlparser2/lib/Tokenizer.js 6:16-49

ERROR in .//entities/maps/entities.json
Module build failed: SyntaxError: Unexpected token m in JSON at position 0
at Object.parse (native)
at Object.module.exports (/home/derekho/LikeMindNetworks/prototypes/react-proto/node_modules/json-loader/index.js:7:48)
@ .//htmlparser2/lib/Tokenizer.js 4:16-54

ERROR in .//entities/maps/legacy.json
Module build failed: SyntaxError: Unexpected token m in JSON at position 0
at Object.parse (native)
at Object.module.exports (/home/derekho/LikeMindNetworks/prototypes/react-proto/node_modules/json-loader/index.js:7:48)
@ .//htmlparser2/lib/Tokenizer.js 5:16-52

ERROR in .//entities/maps/decode.json
Module build failed: SyntaxError: Unexpected token m in JSON at position 0
at Object.parse (native)
at Object.module.exports (/home/derekho/LikeMindNetworks/prototypes/react-proto/node_modules/json-loader/index.js:7:48)
@ .//entities/lib/decode_codepoint.js 1:16-46

it is also important to test that release was sucessfull. this means that we should be able to run our tests against released version.

@eliperelman thoughts?

here's a logtalk though I think this is the important part

126406 warn enzyme@2.4.1 requires a peer of react@0.13.x || 0.14.x || ^15.0.0-0 but none was installed.
126407 verbose If you need help, you may report this error at:
126407 verbose     <https://github.com/npm/npm/issues>
126408 warn react-element-to-jsx-string@3.2.0 requires a peer of react@^0.14.8 || ^15.0.1 but none was installed.
126409 verbose If you need help, you may report this error at:
126409 verbose     <https://github.com/npm/npm/issues>
126410 warn react-addons-test-utils@15.4.1 requires a peer of react-dom@^15.4.1 but none was installed.
126411 verbose If you need help, you may report this error at:
126411 verbose     <https://github.com/npm/npm/issues>
126412 warn react-hot-api@0.4.7 requires a peer of react@>=0.11.0 || ^0.14.0-rc but none was installed.
126413 verbose If you need help, you may report this error at:
126413 verbose     <https://github.com/npm/npm/issues>
126414 verbose stack Error: node-sass@3.10.0 postinstall: `node scripts/build.js`
126414 verbose stack Exit status 1
126414 verbose stack     at EventEmitter.<anonymous> (C:\Users\MOSHMA~1\AppData\Roaming\nvm\v7.2.0\node_modules\npm\lib\utils\lifecycle.js:255:16)
126414 verbose stack     at emitTwo (events.js:106:13)
126414 verbose stack     at EventEmitter.emit (events.js:191:7)
126414 verbose stack     at ChildProcess.<anonymous> (C:\Users\MOSHMA~1\AppData\Roaming\nvm\v7.2.0\node_modules\npm\lib\utils\spawn.js:40:14)
126414 verbose stack     at emitTwo (events.js:106:13)
126414 verbose stack     at ChildProcess.emit (events.js:191:7)
126414 verbose stack     at maybeClose (internal/child_process.js:885:16)
126414 verbose stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:226:5)
126415 verbose pkgid node-sass@3.10.0

NEO does not require on react? (as in, do I have to install react by hand and then install neo?)

When I created Neo, it was meant highly React-Redux-boilerplate specific. I have since been working on development of neutrino, which splits Neo out into two pieces: a wrapped Webpack build system, and a way to have pre-configured presets.

Right now Neo is all-in-one; installing it comes with the build system and all the configuration needed to build. Neutrino is slightly different; you use 2 development dependencies: neutrino and a build preset. For example, if I wanted to build a baseline React project, I could install neutrino and neutrino-preset-react.

Neo does more than just a baseline React project by including Sass building, but anything more than that either comes from scaffolding, or project-specific includes.

Both tools support project-based configuration overrides, but neutrino makes management of these simpler by easily installing from npm a pre-configured preset.

Leaving this open to discuss possibilities.

i'd like to do this before we make our first release

i need this for relenapi work and will probably work on this first thing tomorrow morning

Currently, all imports in the code need to be relative to the current path, making it harder to refactor the code base as it's a pain to have to change all import paths, figuring out how many ../.. are needed.

Adding the src/ directory to webpack's resolve.root config allows developers to go from something like this:

import Header from '../../components/Header';
import TransactionForm from '../TransactionForm';
import * as AppActions from '../../actions';

to something like this:

import Header from 'components/Header';
import TransactionForm from 'containers/TransactionForm';
import * as AppActions from 'actions';

This change is also backwards compatible, so relative imports still work.

would it be possible to bundle configuration for Jest tests?

As of January 1 2019, Mozilla requires that all GitHub projects include this CODE_OF_CONDUCT.md file in the project root. The file has two parts:

1. Required Text - All text under the headings Community Participation Guidelines and How to Report, are required, and should not be altered.
2. Optional Text - The Project Specific Etiquette heading provides a space to speak more specifically about ways people can work effectively and inclusively together. Some examples of those can be found on the Firefox Debugger project, and Common Voice. (The optional part is commented out in the raw template file, and will not be visible until you modify and uncomment that part.)

If you have any questions about this file, or Code of Conduct policies and procedures, please see Mozilla-GitHub-Standards or email [email protected].

(Message COC001)

Formidable just came out with this awesome tool:

https://github.com/FormidableLabs/webpack-dashboard

I think we should integrate this as the default npm start view.

Hi @eliperelman , when importing moment-timezone into my project I get the following error:

ERROR in ./~/moment-timezone/data/packed/latest.json
Module parse failed: /my-project/node_modules/moment-timezone/data/packed/latest.json Unexpected token (2:10)
You may need an appropriate loader to handle this file type.

After playing around with the json loader in the webpack I still can't get rid of it, do you know how to solve this please?

Thanks!

Hi!

I'd like to use the Redux Devtools by using the browser plugin. Is it possible to turn the bundled devtools off?

Also, the browser plugin version gives me the error: No store found. Make sure to follow the instructions.

also it would be nice to just display the error (in red) without all those traceback.

Any plans to add support for server side rendering? After all, it seems like SSR is one of the best reasons to use Redux.

Hi @eliperelman , sorry to bother you again, I found out the dev tools embeded in the production build bring 1.1Mo so here is a webpack config line I think you should include in the default production config:

new webpack.NormalModuleReplacementPlugin(/^(redux-slider-monitor|redux-devtools-log-monitor|redux-devtools-dock-monitor|redux-devtools-chart-monitor|react-hot-loader|redux-devtools|redux-logger|react-hot-loader)$/, join(process.cwd(), './shim.js'))

with shim.js as en empty file

for example: redux-devtools-chart-monitor brings he whole D3 as a dependency

hi, is there a way to hide the right side state panel so that playing with css would result the way it should without dragging to hide?

Hi guys, @eliperelman,

The dev server can't serve static assets (images...), I tried to put them at the root level and /src but it's not working.

That would be nice to have a /public or /assets folder in the default config configured to serve a root URL like /my-logo.png

Thanks ;)

I was following the flow setup described in the Create and build React web applications with zero initial configuration and minimal fuss post:

• installing flow-status-webpack-plugin
• running node_modules/.bin/flow init
• updating .flowconfig file
• updating package.json to add --config dev.config.js argument to neo start
• creating dev.config.js:

const dev = require('mozilla-neo/config/webpack.dev');
const FlowStatusPlugin = require('flow-status-webpack-plugin/index');

dev.plugins.push(new FlowStatusPlugin({binaryPath: 'node_modules/.bin/flow'}));

module.exports = dev

I've added a sample function which breaks type, to one of the sources:

function display(x: string): string {
    return x.length;
}

When running npm start I don't see flow status after modifying any file, though my editor displays nice notification that return type is incompatybile.

Is there something wrong with my setup or FlowStatusPlugin doesn't display status?

Currently src/app.js provides a skeleton that can't be extended is almost always not what someone will be completely happy with. Someone most certainly always wants to change it. We should do one of the following:

• Make the file super simple for those just wanting a simple React/Redux app
• Make the file pretty opinionated, but extensible
• Remove app.js and include something simple in the scaffolding

Hi, awesome project. Congrats!
After building the example project and placing the folder (index + 2 js files) in webserver (apache) does not open any html element. However console in chrome tools does show the show output as when the project is run in dev mode (npm start). What is I'm missing?
Thanks in advance