Giter VIP home page Giter VIP logo

Comments (3)

victorporof avatar victorporof commented on July 28, 2024

@linclark do you know of any way react could notify us when a proptype validation fails, so that we may fail the tests automatically?

One hack around this would be to wrap console.warn (or whatever react is using to log these errors) and check the message. If it's a proptype validation failure, we throw instead of logging. It's a very fragile hack though.

from tofino.

victorporof avatar victorporof commented on July 28, 2024

Also, note that now that we're using babel-preset-react-optimize in production mode, these prop types are deleted from production builds, which we're actually using for tests.

Should we test builds in development mode instead? Or have yet another build configuration which is for tests only, mostly the same as production but without babel-preset-react-optimize?

from tofino.

victorporof avatar victorporof commented on July 28, 2024

Found a middleground approach, see the PR.

from tofino.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.