To reproduce, open two tabs (say to https://mozilla.org). Select the first tab, then the second tab. On my Mac OS X box, I see a white "pop" when switching tabs. This is particularly noticeable when the underlying web content rendered in the <webview> is identical.

I think the original intentions was that the npm scripts was gonna be called 'npm start-dev', but in reality, you need to use 'npm run' to run scripts. Instead of calling 'npm run start-dev', let's simplify to 'npm run dev'

We have the eslint rules enforcing certain styles but there are other things to say here.

Started happening after #62

After this, gulp run is failing on a fresh clone, even after a npm install:

fs.js:584
  return binding.open(pathModule._makeLong(path), stringToFlags(flags), mode);
                 ^

Error: ENOENT: no such file or directory, open '/Users/victorporof/Desktop/tofino/node_modules/electron-prebuilt/dist/Electron.app/Contents/MacOS/version'
    at Error (native)
    at Object.fs.openSync (fs.js:584:18)
    at Object.fs.readFileSync (fs.js:431:33)
    at Object.getElectronVersion (utils.js:25:13)
    at Object.<anonymous> (config-builder.js:25:24)
    at Module._compile (module.js:413:34)
    at loader (/Users/victorporof/Desktop/tofino/node_modules/babel-register/lib/node.js:126:5)
    at Object.require.extensions.(anonymous function) [as .js] (/Users/victorporof/Desktop/tofino/node_modules/babel-register/lib/node.js:136:7)
    at Module.load (module.js:357:32)
    at Function.Module._load (module.js:314:12)

A LICENSE file as well as license in package.json

Moving the NavBar to the top, and TabBar below, and moving buttons around to match the mockups. TabBar will eventually be hidden like the mockups and revealed with the "Pages" button.

Working on this now.

This ticket tracks collecting rudimentary metrics. It's the kind of thing we'll want on day one. Google Analytics is easy and has the simplest analysis set-up. It's intended to be used event-by-event without much (if any) batching. Historically, Mozilla has been reluctant to share fine-grained data with Google in any form.

Mozilla's own Telemetry system is an option. It's intended to be used in batch form. The ping format is more or less free-form, but if we use Mozilla's Telemetry we probably want to converge on the v4 core ping format at least. The new data pipeline is fast (~15 minutes to view in Spark) and supports a range of analyses. It's nothing like Google Analytics, though.

There are other off-the-shelf systems, but I don't know the competitive merits.

It provides nearly 50% compression ratio improvement due to solid archive.

I checked some similar formats (like tar.gz/bz2/xz), but they seem weaker than 7z. If this brings a compatibility issue, I hope it can serve as an alternative option or provided according to the platform.

ES2015 already has Object.entries

https://github.com/electron/electron/blob/master/docs/tutorial/application-packaging.md

That have 17000+ files in /dist/tofino-win32-x64/resources/app, it is a horrible effects for end users, although we may have no plans.

In command line way: asar p app app.asar
Then, renamed or removed the app dir.

STR:
Open a couple of tabs
Press cmd+w

Expected:
Current tab/page closes

Actual:
Electron window closes

Hi
When i try i Debian building i receive:
root@debian:/home/fabrizio/Scrivania# npm install tofino
npm WARN engine [email protected]: wanted: {"node":">=5.8.0"} (current: {"node":"4.3.1","npm":"1.4.21"})
npm WARN optional dep failed, continuing [email protected]
|

[email protected] postinstall /home/fabrizio/Scrivania/node_modules/tofino
electron-rebuild

sh: 1: electron-rebuild: not found
npm WARN This failure might be due to the use of legacy binary "node"
npm WARN For further explanations, please read
/usr/share/doc/nodejs/README.Debian

npm ERR! [email protected] postinstall: electron-rebuild
npm ERR! Exit status 127
npm ERR!
npm ERR! Failed at the [email protected] postinstall script.
npm ERR! This is most likely a problem with the tofino package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR! electron-rebuild
npm ERR! You can get their info via:
npm ERR! npm owner ls tofino
npm ERR! There is likely additional logging output above.

npm ERR! System Linux 4.4.0-1-amd64
npm ERR! command "/usr/bin/nodejs" "/usr/bin/npm" "install" "tofino"
npm ERR! cwd /home/fabrizio/Scrivania
npm ERR! node -v v4.3.1
npm ERR! npm -v 1.4.21
npm ERR! code ELIFECYCLE
npm ERR!
npm ERR! Additional logging details can be found in:
npm ERR! /home/fabrizio/Scrivania/npm-debug.log
npm ERR! not ok code 0
root@debian:/home/fabrizio/Scrivania#

A number of things are exposed to content processes via HTML5 APIs, but not directly to the main process. (For example, https://github.com/electron/electron/blob/master/docs/tutorial/online-offline-events.md.)

Rather than negotiating 0/1/many content windows, I suggest we add a single long-lived hidden rendering process to handle funneling HTML5 APIs to the main process.

When on google.com, we get a message we're using an old Chrome. This is no doubt super confusing. Maybe just a user-agent thing.

I'm guessing this is the webserver we're starting for hot-module reloading. Maybe if we only listen on localhost it won't throw up this?

We're using this to zip up the packaged builds. See https://github.com/mozilla/tofino/blob/master/build/task-package.js

Should probably remove such a small dependency. See #77

I feel it is a common feature when user clicks middle mouse button on the tab, the tab should be closed.
And i'm happy to open up a PR.

Inactive tabs don't seem to resize when they are shown.

Steps to reproduce:

• Start with the small browser window
• Double click on the top bar to make full screen
• Select the second tab which was opened at first load also
• Notice that the tab is the same size as the initial window

Ubuntu 16.04 and Node 5.8.0

Maybe we can do this via eslint.

Since we transpile our code before packaging, these values get turned into strings of the current machine, not the machine where a distributable is actually run. Most of the time it would be ok (like the os.platform() value), but there may be other discrepencies. Either way, it's a bit confusing.

If you need to query similar info, we should do it at build time -- look at build/config-builder.js at how the build-config.js is created during build time to have build-specific configurations, not runtime specific.

I'm sure I could be missing some nuisances, but this seems to make sense. How do others feel about this? Is this nothing to worry about?

We're thinking of using --signoff. May not happen though.

https://github.com/mozilla/tofino/wiki/Directory-Layout

Right now we're doing this in runtime. We need to transpile this code (put it in app-built/app.js? no idea) and then move all the babel deps to devDependency so we don't put it in the distributed package.

[I'm definitely not working on this]

Extra reading: https://medium.com/@dan_abramov/smart-and-dumb-components-7ca2f9a7c7d0#.8e28rxk9a

Especially when using with redux, almost all of our components should be "dumb" -- that is, just take props and construct a DOM fragment. This includes handlers and the like, where our main container/app passes in all handlers necessary into its children components. This also will lead to easier testing due to having control over the props passed in, but also minimize the area in which we directly access electron methods in components.

I hit save in Emacs, a lot. I manage my git tree in Emacs, a lot. We hot reload the App front-end even when it's not the foreground App; and that brings the window to the front. Can we not do that?

Right now, if there's a build failure when running gulp run-dev, we just get a useless 404 error for static/built/browser.js.

When running in gulp run, we can open the tools and see "Uncaught Error: Cannot find module "./navbar/navbar.jsx". We need to display this information somewhere.

See #5 (comment) about coming up with a better detection for data URIs. Here are some relevant looking utilities:

• http://mxr.mozilla.org/gaia/source/shared/js/url_helper.js
• http://mxr.mozilla.org/gaia/source/apps/sharedtest/test/unit/url_helper_test.js
• https://github.com/brave/browser-laptop/blob/master/js/lib/urlutil.js

It attempts to set the NODE_ENV environment variable as if running under a unix shell.

All of the interface of the top bar is not clickable (url bar, reload, close etc) and I get the grabbing hand cursor.

The tabs and new button are clickable and selectable.

I'm running this on Ubuntu 16.04 with Node 5.8.0.

I have no opinion on the value of the "Private browsing" product feature, but it does raise require particular architectural features. This is relevant to #44 in particular, since the profile service needs to know when certain windows (or tabs) are private, and should have different views of the profile data.

When clicking the 'Pages' button let's toggle a placeholder area

Right now when I run the app and switch focus to another one (like Firefox), cmd+l doesn't work in the other app, and an error gets thrown over in fawkes:

Uncaught Exception:
TypeError: Cannot read property 'webContents' of null
    at Function.globalShortcut.register (/fawkes/app/main/main.js:93:37)

https://github.com/mozilla/fawkes/blob/4e09ae97cae8c62658590d4acb7258f5b489c6d9/app/main/main.js#L92

This is a piece demonstrating part of the profile service envisioned by #44. Right now, we have a "bookmark" external action that writes to IndexedDB; that's shared by each rendering process. This cross-process sharing should happen, but with the main process managing the global bookmark state.

Types help large projects maintain sanity. I saw this on on a large Electron/Atom-based project (https://github.com/facebook/nuclide/). Consider using typed JS from the start to keep the code sane. I would suggest Flow as you can do gradual typing, replaces React proptypes, etc...but please, use something!

There's a .travis.yml file here: https://github.com/mozilla/tofino/blob/master/.travis.yml, but https://travis-ci.org/mozilla/tofino appears to not be set up.

Right now, there's a global set of bookmarks shared between BrowserWindow instances via IndexedDB. This approach doesn't address Sync (in the future) well. @rnewman has written about this in https://github.com/FractalBrew/blueharvest/wiki/Profile-service (currently (temporarily?) private).

This ticket tracks fleshing out a main process profile service, fleshing out the IPC required to move between the two, and moving the existing approach to the new hotness.

We have these warnings in a handful of places

webContents.send() sends a message to the renderer process, and thus we actually need a ipcRenderer to listen on the rederer process.

Right now, packaged apps use the icons in ./branding, but when running gulp run or gulp run-dev, we just have the default atom icon. It should be as simple as passing in a path to BrowserWindow[0], but it looks like that's only supported for Linux/Windows, and don't have a machine to test that on right now.

http://electron.atom.io/docs/v0.37.4/api/browser-window/

Electron will upload crash reports to a Socorro instance: https://github.com/electron/electron/blob/master/docs/api/crash-reporter.md. Mozilla runs a Socorro instance at https://crash-stats.mozilla.org.

It's easy to ask the main process and a renderer process to crash: process.crash(), see electron/electron#1577.

Since this is almost free, we should try to wire it up.