Giter VIP home page Giter VIP logo

Comments (16)

jedireza avatar jedireza commented on June 18, 2024

Yes I noticed this too. When the app starts I get access to the mic and setup the events to listen to the volume levels (for the listening motion). I can try changing it if you see it as a problem.

Won't this be the case if we have word spotting anyways, since the mic will be active all the time?

from vaani.

kdavis-mozilla avatar kdavis-mozilla commented on June 18, 2024

You're right about the word spotting case. I guess it will be on anyway. Stupidly,
I hadn't thought that through.

Ultimately, I'm worried about the appearance that we are listening in despite the
fact that we aren't.

from vaani.

andrenatal avatar andrenatal commented on June 18, 2024

This is by design, since the API uses getusermedia to receive record the voice. There is nothing we can do to change this on Gaia. If you wish to change this, need to ask in #media channel.

from vaani.

kdavis-mozilla avatar kdavis-mozilla commented on June 18, 2024

When word spotting is integrated, then yes the indicator should always be on and there is nothing
we can or should do about it.

However, word spotting is currently not integrated.

So, we shouldn't be listening all the time, we should only listen when the user requests we listen.

from vaani.

jedireza avatar jedireza commented on June 18, 2024

Maybe I could try to change it and use getusermedia only when we're listening to a command. If we notice a performance degradation or another negative side affect by doing that, we can always move back to the current setup since we know it works.

from vaani.

andrenatal avatar andrenatal commented on June 18, 2024

This don`t have anything to do with wordspot. It is a getusermedia beahviour, and even if we don't pass a DomMediaStream to the constructor, gum will be called internally in Gecko [1], showing the red icon on top. Again, there is nothing to do to fix this on Gaia neither on the app, but yes on Gecko. So this is not an issue here, but an expected behavior.

[1] https://github.com/mozilla/gecko-dev/blob/master/dom/media/webspeech/recognition/SpeechRecognition.cpp#L732

from vaani.

kdavis-mozilla avatar kdavis-mozilla commented on June 18, 2024

@jedireza I think that sounds reasonable.

We don't want to give the user the impression that we are in any way spying on them.

from vaani.

andrenatal avatar andrenatal commented on June 18, 2024

@jedireza Even if you don't call gum in js, will be called internally.

https://github.com/mozilla/gecko-dev/blob/master/dom/media/webspeech/recognition/SpeechRecognition.cpp#L732

from vaani.

andrenatal avatar andrenatal commented on June 18, 2024

@jedireza I just tested on my phone, and after ~30 secs without activity, the red icon disappears, and when I push the mic button again, recording icon appears but don't listen anything.

from vaani.

kdavis-mozilla avatar kdavis-mozilla commented on June 18, 2024

@andrenatal Can you re-open this issue?

from vaani.

andrenatal avatar andrenatal commented on June 18, 2024

@kdavis-mozilla ok, but I am not sure if this issue belongs here.

from vaani.

kdavis-mozilla avatar kdavis-mozilla commented on June 18, 2024

@andrenatal I was wondering about where to track Vaani issues too, and right now this seems about as good a place as any. I think when Vaani's in Gaia, we can move over to Bugzilla.

from vaani.

andrenatal avatar andrenatal commented on June 18, 2024

@kdavis-mozilla I agree, but being specific about the matter of this issue, looks more related to gum than Gaia/Vaani itself.

from vaani.

kdavis-mozilla avatar kdavis-mozilla commented on June 18, 2024

@andrenatal I agree. Once we start listening the indicator is on and that's out of our hands, as it should be.

All I am saying is that we should only start listening when the user asks us to. That way we don't give the impression that we are spying in on the user.

The issue I am concerned with is not really, at its core, technical, but it's one of user perception.

from vaani.

andrenatal avatar andrenatal commented on June 18, 2024

You are correct. My phone is still with the rec icon on! One hour after!

from vaani.

jedireza avatar jedireza commented on June 18, 2024

getusermedia/attachmediastream don't seem to have good mechanics to "release user media" and "detach media stream". I'll leave this issue open so we can try to resolve later.

from vaani.

Related Issues (13)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.