mpeters / smolder Goto Github PK

See

http://smolder.parrot.org/app/projects/feed/1

and

http://smolder.parrot.org/app/projects/feed/1/failed

for examples. They point to the wrong file/dir, wrong port and the wrong IP.

Duke

The subject says it all! Thanks!

We made a small change to lib/Smolder/DB/SmokeReport.pm - the email subject wasn't as detailed as we wanted. In the patch, the new subject line reads:

Smolder - [projname] passed #passed/#total tests: (SUCCESS|FAILURE)

Committed to my git fork & pushed upstream.

To reproduce:

Take a private project, enable RSS/Atom feeds.
Open the 'all' feed for the project, click on the link. The feed will attempt to take you to:

http://servername:port/app/developer_projects/smoke_report/report#

This results in a 404.

I think the correct URL should be:

http://servername:port/app/projects/report_details/report#

Requiring authenticated cookies to retrieve RSS feeds for private projects is incompatible with most RSS aggregators. For example, using Yahoo, Netvibes, or Google Reader doesn't work with private projects. There is, however, a desire for a public RSS feed for an otherwise-private project.

It's a common problem, and is handled elsewhere (e.g. Google Calendars) by adding an identifier and cryptographic checksum to the URL string, and using that as validation instead. For example:

sitename.com/port/app/projects/feeds/PROJECTID/USERID/crypto_string

where crypto_string could be something like the md5sum of PROJECT_ID, USERID and some secret key.

Thoughts?

Other note is that any FORBIDDEN message relating to RSS feeds should be sent as an RSS feed and not as an HTML page.

When I run 'perl Build.PL' I get the followinbg error message:

• ERROR: Net::Server::PreFork (0) is installed, but we need version >= 0.97

I already have 0.97 installed, so how can I force the build anyway?

bin/smolderctl doesn't seem to work. The fatal error that percolates up is that Smolder::Server::Control is not able to load the library Server::Control::Simple.

I have grepped the entire codebase, searched CPAN, and searched the installed CPAN packages that Smolder depends on - there is no mention of said library.

Note - bin/smolder works, including daemon mode - I was hoping to use smolderctl to provide 'stop' functionality in addition to 'start' (e.g. using the pidfile droppings). Is there a better way to do this?

Using 1.51.