Giter VIP home page Giter VIP logo

photoapp's Introduction

TASK

Hello! Thank you for taking time to review this code. The goal of the test is to show my coding and little bit design skills

  • There are no pods or any third party services has been used or consumed, so just open PhotosApp.xcodeproj on Xcode
  • Custom Dependency Injection has been used to use the proper testing
  • MVVM-C was used in this project
  • In unit test, mock network layer was used to get the data from json file but for app development normal network request has been consumed
  • Unit test for DummyPhotoRepository was written to showcase
  • Small and frequent commits approach is used while developing and designing the code and architecture

What can further be done

  • ActivityIndicator can be added on DummyPhotosListViewController and DummyPhotoDetailViewController to show that data is fetching from server
  • An Error Label or Toast can be added on DummyPhotosListViewController and DummyPhotoDetailViewController to show error to the user for better user experience
  • UI wasn't focused on this task, improved UI can be implemented
  • Network Request and Image caches can be implemented
  • Multiple schemes and configuration can be created for production use
  • .gitignore file can be added

Just to clear

This naming DummyPhoto is used because it may be conflicted in the idea of the team that we are using native Photo or might be a Photo object which can have image file

API Details

The server at the following url responds with JSON formatted data:

(GET) https://jsonplaceholder.typicode.com/photos

The response represents a list of photo objects:

[ {
}, {
"albumId": 1,
"id": 2,
"title": "reprehenderit est deserunt velit ipsam",
"url": "https://via.placeholder.com/600/771796", "thumbnailUrl": "https://via.placeholder.com/150/771796"
},
<...>
]

The following url returns a single entry for a given id:

https://jsonplaceholder.typicode.com/photos/{id}

photoapp's People

Contributors

mrazam110 avatar

Watchers

 avatar

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.