Add keyboard shortcuts for zoom in and out in OrbitControls.js about three.js HOT 5 CLOSED

OrbitControls like other control classes rely on KeyboardEvent.code which represents the physical key on the keyboard. This is ideal for all use cases where the user is supposed to control an object/camera with fixes keys on the keyboard (think of games which rely on WASD or arrow keys).

Add keycodes PLUS: 107, MINUS: 109 to this.keys.

Regarding plus and minus, using the numeric key code values doesn't work since the control classes check for KeyboardEvent.code. So the + and - signs are e.g. NumpadAdd and NumpadSubtract when using the numpad. However, not all keyboards have a numpad so their plus and minus keys might be at different positions. I wonder if it is better to make a second switch statement in handleKeyDown() and check for KeyboardEvent.key instead. Meaning:

switch ( event.key ) {

	case '+':

		dollyOut( getZoomScale() );
		needsUpdate = true;
		break;

	case '-':

		dollyIn( getZoomScale() );
		needsUpdate = true;
		break;

}

@felixmariotto Plus and minus signs are not that established as WASD or arrow keys in context of gaming. It seems checking for the actual character seems better in this case, imo. What do you think?

from three.js.

I like the idea of support keys for zoom but the suggested change does not work for me. E.g. on macOS the code for plus on the numpad is NumpadAdd.

from three.js.

Wouldn't it be even better to replace all usages of KeyboardEvent.code with KeyboardEvent.key? The second would be more understandable because of comparing with the character instead of some abstract keycode.

from three.js.

KeyboardEvent.code is the better default for controls with has been approved in #21056. I don't think there is a need to question this policy. It definitely makes sense for many use cases. There might be exceptions like this issue though.

from three.js.

Closing, see #26862 (comment).

from three.js.