mren / assert-outdated Goto Github PK

I have a dependency which is loaded from Github, since the projects version on npm is outdated and has a bug.

"devDependencies": {
  "swagger-snippet": "https://github.com/ErikWittern/swagger-snippet",
}

npm outdated --json --save false reports

{
  "swagger-snippet": {
    "current": "0.6.0",
    "wanted": "git",
    "latest": "git",
    "location": "node_modules\\swagger-snippet"
  }
}

The documentation (https://docs.npmjs.com/cli/outdated.html) says:

Git dependencies will always be reinstalled, because of how they’re specified.

I think that's why they are always treated as outdated. Possible values of "latest" and "wanted" are "git", "linked" and "remote".

assert-outdated should not return with an error for such dependencies, otherwise it's not usable with such links.

@mren I know that you're busy and don't have the capacity to work in this project right now.

Since I'm using it in a couple of projects and I think it's a very useful piece of software, I would like to investigate some time in refactoring, if that's OK for you.

• One thing would be to update the dev. dependencies (since they are really outdated).
• Restructure the tests a bit to make creating tests easier
• Restructure the code a bit
• Make use of JSDoc type comments and TypeScript code validation
• Code indention by 4 spaces or 1 tab
• Make use of async/await to increase the readablity

Is that OK for you, or do you want to keep the project as it is?

Especially the last point would require to use Node.js v8 - that's already more than 2 years old, but maybe there are still people using it? Anyway, I think people should be forced to update their systems regularly to get security updates.

With following script defined in package.json:

"lint:outdated": "assert-outdated-npm-modules --max-warnings 0 --ignore-pre-releases",

1. Ran lint:outdated and got a list of outdated dependencies (as expected)
2. Updated package.json with new versions
3. Ran lint:outdated again, and got following errror (not expected):

C:\dev\project>npm run lint:outdated

> [email protected] lint:outdated C:\dev\project
> assert-outdated-npm-modules --max-warnings 0 --ignore-pre-releases

TypeError: Cannot read property 'indexOf' of undefined
    at C:\dev\project\node_modules\assert-outdated\outdated.js:23:26
    at Array.filter (<anonymous>)
    at filterDependencies (C:\dev\project\node_modules\assert-outdated\outdated.js:22:49)
    at C:\dev\project\node_modules\assert-outdated\outdated.js:62:27

5. Ran npm install to see if that helped
6. Ran lint:outdated once again, and got no errors (as expected)

Seems when I update package.json, but don't run npm install, then outdated.js crashes for some reason?

I use your module to check that all dependencies are update to date before I release a new version.

One of my projects dependencies is "tslint-microsoft-contrib", their latest version is "6.1.0-beta".
I don't want my project to depend on beta versions (especially because this specific release of tslint-microsoft-contrib is defect).

It would be cool if it would be possible, to specify that versions ending with "-beta" or "-alpha" (or a specific regexp-pattern) should be ignored. Or if it would be possible to exclude package from the check.