mrfdev / 1mb Goto Github PK

I might consider adding this as a default, or at least as an option to set to true.

We could potentially check against https://papermc.io/api/v1/paper to see if the version we're trying to get is actually a valid version. If not, figure out what the latest version is and ask to build that instead.

If we get to the point where we are going to actually go ahead with the script and try to make a new spigot-1.16.1.jar, we should (just like in updatepaper script) maybe rename spigot-1.16.1.jar to spigot-1.16.1._jar

That way if the new jar turns out to be problematic than we can roll back to the latest working version.
And this would also be the first step to allowing to run buildtools from the same dir where we run the jars from.

Script filename
N/A

Describe the feature you would like to see
add a git submodule (basicly shows like a symlink in github, but cloning with --recursive (iirc) includes that repository too

Additional context
just makes it easier/ leaves it all in 1 place
https://git-scm.com/book/en/v2/Git-Tools-Submodules

curl is quiet, but wget still spits out stuff.
Might be an idea to make wget silent/quiet as well.
Maybe if verbose is true, then curl/wget could spit out stuff, otherwise.. stay quiet?

tmux and screen are both not installed on ubuntu 20 by default, tmux isn't by default on macOS Catalina.
I personally prefer screen, so leaning towards that. Checking for it first, but tmux is more modern and ppl prefer it sometimes.

Anyway, check if it's there, before going to the next step

Ie: os it is made for/tested against
What needs to be installed for it to run (if anything)

For the differnet scipts?
or just bug + feature, and include a section to say what script its for

There's a risk when (auto) updating the jar file while jar with the same name is already being used and running live. That's why i always strongly recommend to run this buildtools script from a completely empty new directory instead of on a live server.

People don't read, and that means they ignore the advice and probably just dump it in the same dir and run it, even without backing up or /stop the server.

We can help with this, maybe check if we can find a server.properties and assume we're running from such a directory. And if there's an existing jar file that we back that up. Or halt the script or something.

Requires a bit of thinking, considering, .. not sure what direction I want to go at the moment.

While the cache is basically there for debugging reasons, it would be kinda nice it also gets updated when debug is set to false. Maybe worth looking into.

Currently it checks only for the version json of the _minecraftVersion we set manually in the buildtools script, if it can't find it - it stops the script. If it can find it, it will compare it against our cache, and if mismatches.. it asks if we are certain we wish to continue. And otherwise it just continues comparing versions (and perhaps it figures out if there's a new jar to make)

What it doesn't do is check against latest, it just says (Script Halted!) Failed to get version from https://hub.spigotmc.org/stash/projects/SPIGOT/repos/builddata/raw/info.json, quitting script! It could say: build a jar using --1.16.1 instead? (and read user input for y/n key)

java -jar BuildTools.jar --rev latest