Giter VIP home page Giter VIP logo

Comments (5)

LeviWilliams avatar LeviWilliams commented on June 1, 2024 1

@alexzkazu Yes, if you're switching what you're publishing or the component is remounting before a new publish you need to call "unpublish()" to make sure all existing publications are removed. "Make sure to unpublish, disconnect and remove any listeners as they won't be removed automatically!" - from the docs.

Just a piece of advice too - from what I can gather there this is kind of a complex way to achieve what you're trying to do. I would isolate the text input just so it's strictly a component and doesn't handle any logic and have a useEffect hook waiting for a new message or just pass down your publish logic function through props into the component. Then it's a lot easier to debug and see the flow as well. Seems to be a problem with how you're implementing it.

from react-native-google-nearby-messages.

LeviWilliams avatar LeviWilliams commented on June 1, 2024

Interesting, I haven't experienced this dropping in my production apps. Do you experience the issue with the app open on both devices and the message suddenly dropping? Is there some kind of rerender or maybe it has to do with how you've implemented the logic? Are you using hooks?

from react-native-google-nearby-messages.

midori-ao avatar midori-ao commented on June 1, 2024

Hey @LeviWilliams , yeah this happens when the app is open on both devices.

I modified the example app to give this a try.. I'm still new with hooks so I might've made a mistake somewhere:

let meObj = {};

const TextInput = () => {

  const onSubmitEditing = async (text) => {
    meObj.text = text;
    await publish(JSON.stringify(meObj));
  };

  const [value, onChangeText] = React.useState('Useless Placeholder');

  return (
    <TextInput
      style={{ height: 40, borderColor: 'gray', borderWidth: 1 , color: 'black'}}
      onChangeText={text => onChangeText(text)}
      onSubmitEditing = {(event) => (onSubmitEditing(event.nativeEvent.text))}
      value={value}
    />
  );
};

export default function App() {
  const [nearbyMessage, setNearbyMessage] = useState('');
  const [textMessage, setTextMessage] = useState('');

  useNearbyErrorCallback(
    useCallback((kind, message) => {
      Alert.alert(kind, message);
    }, []),
  );

  const _connect = useCallback(async () => {
    console.log('Connecting...');
    await connect({
      apiKey: API_KEY,
      discoveryModes: ['broadcast', 'scan'],
      discoveryMediums: ['ble'],
    });
    console.log('Connected!');
    return () => disconnect();
  }, []);

  const _publish = useCallback(async () => {
    const deviceName = await getDeviceName();
    meObj.deviceName = deviceName;
    console.log(`Publishing "${deviceName}"...`);
    await publish(JSON.stringify(meObj));
    console.log(`Published "${deviceName}"!`);
  }, []);

  const _subscribe = useCallback(async () => {
    console.log('Subscribing...');
    await subscribe(
      (m) => {
        m = JSON.parse(m);
        setNearbyMessage(m.deviceName);
        setTextMessage(m.text);
        console.log(`Found: ${JSON.stringify(m)}`);
      },
      (m) => {
        setNearbyMessage('');
        setTextMessage('');
        console.log(`Lost: ${JSON.stringify(m)}`);
      },
    );
    console.log('Subscribed!');
  }, []);

  const _checkPermissions = useCallback(async () => {
    const permission = await checkBluetoothPermission();
    const available = await checkBluetoothAvailability();
    Alert.alert(
      'Bluetooth Permissions:',
      `Granted: ${permission}, Available: ${available}`,
    );
  }, []);

  useEffect(() => {
    const start = async () => {
      try {
        await _checkPermissions();

        await _connect();
        await _subscribe();
        await _publish();
      } catch (e) {
        Alert.alert(
          'Unknown error occured while connecting!',
          JSON.stringify(e.message ?? e),
        );
      }
    };

    start();
    return () => disconnect();
  }, [_connect, _subscribe, _publish, _checkPermissions]);

  return (
    <View style={styles.container}>
      <Text style={styles.welcome}>☆GoogleNearbyMessages example☆</Text>
      {TextInput()}
      <Text style={styles.welcome}>Nearby Message:</Text>
      <Text style={styles.instructions}>{nearbyMessage}</Text>
      <Text style={styles.welcome}>Text Message:</Text>
      <Text style={styles.instructions}>{textMessage}</Text>
    </View>
  );
}

from react-native-google-nearby-messages.

midori-ao avatar midori-ao commented on June 1, 2024

Well, I put the TextInput component directly in the return statement, changed onSubmitEditing to onEndEditing, and that seems to have fixed it so I'll be closing this. Thanks!

from react-native-google-nearby-messages.

midori-ao avatar midori-ao commented on June 1, 2024

Actually, upon doing this several times, the issue occurred again. I reverted back to the original example, published a simple string with a button component, and I ran into the same issue.. Do we have to do anything before publishing a message again?

from react-native-google-nearby-messages.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.