mrvdh / mapping-north-korea Goto Github PK

With for example:

• Major roads
• Landuse
• Minor roads
• Buildings

Sections remain on "being edited" or "being reviewed" since some people don't change it back. It needs a timer that automatically sets it back to the previous state non-editable state.

Zoom level is static, even though sectors are not always the same size.

When interesting things on the map are found and you want to share them with others, mark it with a poi. See the first comment with the progress and todo list.

Sometimes there is a 500 error on get user details, with OSM's response being this:

timestamp:  <= RES /osm/getuserdetails ERROR response error
Couldn't authenticate you

Might be related to issue #10

CustomMenuRight is now a component that could be seperated into several other smaller ones. Same goes for the left menu.

such as:

https://www.mappingnorthkorea.com/#map=16/38.2968/127.1050

and

https://www.mappingnorthkorea.com/#map=16/38.2968/127.1050&sectorid=27342324234

and

https://www.mappingnorthkorea.com/#sectorid=27342324234

possibly related to history mode being turned on

The Tasking Manager shows a ping square in iD which shows me the area I selected to map.

I missed this when I „viewed“ an area out of interest.

It helps to connect the editor with the task manager.

GitHub link needs to be added on about page and FAQ.

How to reproduce:

• Have JOSM open with Remote Control enabled and the local HTTPS certificate installed
• On https://mappingnorthkorea.com select a tile in editing mode
• Select "JOSM" from the "Map" button menu.

Expected result:
JOSM to load the area to map

Result:
MNK shows this error toast:

Nothing happens in JOSM

Tried with Chrome 74 and Edge 44 on Windows 10

I often have to log in again, and the amount of sessions in the database is quite large. Also MappingNorthKorea is often there on the OAuth clients list on the OSM site.

https://www.openstreetmap.org/user/YOUR_USER_NAME/oauth_clients

https://choosealicense.com/licenses/gpl-3.0/

OpenLayers might be better for performance and smooth map navigation.

Whenever a request goes wrong the loading bar keeps moving as if it's still doing something. It should stop moving when a request is completed, whether by error or success.

This is probably caused by the fact that not everywhere the catch of a request is implemented.

Selected tiles should only have the opacity changed so you can still easily see which state it's in.

Currently you need to run npm run build and manually delete the server/dist folder and then copy the client/dist folder to the server folder. This should be automated for ease.

Currently running unsupported vue-loader 3.x on a vulnerable webpack version on vue-cli 2.x.
This needs to be updated.

Currently no 'confirm' check is present.

In the HOT Tasking Manager each project has a detailed description of the entities to be mapped (roads, waterways, land uses, buildings).

I can not see any any explanation of things to be mapped with this project. I assume each sector should be mapped completely, including all roads, waterways and buildings? If this is true it should be noted on the About page more explicitly than "mapping everything" in the first sentence.

From my experience with HOT it leads to an inconsistent data set when too much different things are mapped at once and it's too easy to get lost in details of one area while missing basic elements in others.

I personally see not much value when individual residential buildings would be mapped before the basic road network.

I don't know the current mapping quality in North Korea [1], but I suggest that the mapping phases should concentrate on different features, for example:

• phase 1: important roads (unclassified / tertiary - but not residential / service) & important waterways (river / riverbed - but not stream / ditch) & important landuses (residential / industrial - but not farmland)
• phase 2: residential roads and smaller waterways in urban areas (important for bridges)
• phase 3: buildings

[1] I randomly zoomed to https://www.openstreetmap.org/#map=16/39.1644/126.2312 and noticed that this area should be connected with a road and have a residential landuse at least

Initially I added this since the HOT Tasking Manager has it. However, what is the actual purpose and does it actually serve a benefit?

Possibly it should be:

• Open
• Being edited
• Review needed
• Completed

When a user is done editing they will set it to 'Review needed'. When another user reviews that sector they can set it to 'Being edited' since the reviewing user will most likely make small changes anyway.

https://www.openstreetmap.org/user/DrishT/diary/368711

I think that the size of the tasks as thzey are right now is much too big. They include almost 40 square kilometers while one square kilometer in a relatuively densely populated county like North Korea (with poor OSM coverage so far) would already be a challenge.
My radical idea/suggestion would be to split all the orginal tasks in 32 parts. It is always good and motivating for a mapper if he/she has the chance to finish a task.

Modal for comments and state edits is unnecessary. Can be integrated into the side panel with live edits and no 'save' button. (other than a post button for the comment)

A user who has emoji's in his username reported that he could not log in.

Files with translation strings. etc.

https://kazupon.github.io/vue-i18n