msdevmtl / globalazurebootcamp-2019 Goto Github PK

Create clear content explaining step by step what needs to be done. The reader must know exactly what needs to be done without further explanations.

Confusion between folder named GABDemo and GABCDemo

I think we should use fewer parameters and more variables.
Have one parameter something like SolutionName
then multiple variable building all other names based on that one.

If you take a look at the ARM template between labs, there are discrepancies in naming. In short, the templates are not always an evolution from the previous steps.

i.e.: Lab5

"variables": {
    "suffix": "[uniqueString(resourceGroup().id, resourceGroup().location)]",
    "storageName": "[concat('stg', variables('suffix'))]",
    "csVisionName": "[concat('vision', variables('suffix'))]"
  }

vs Lab6

  "variables": {
    "storageAccountName": "[concat('gab2019', uniquestring(resourceGroup().id))]"
  }

In the Section Azure CLI - incremental mode (https://github.com/MSDEVMTL/GlobalAzureBootcamp-2019/tree/master/Lab5#azure-cli---incremental-mode)

The explanation of "Complete" vs "Incremental" is good. However we should not be using Azure CLI to deploy but instead, commit and push our changes.

Add the following text (and more possibly) to lab0 setup:

Download Azure Storage Explorer

If you are not using the Azure Portal, you can download the Azure Storage Explorer here.

Once you have Azure Storage Explorer, add your account and you should be able to see all the storage in your (selected) subscription(s)

In the section Continuous Deployment (https://github.com/MSDEVMTL/GlobalAzureBootcamp-2019/tree/master/Lab1#continuous-deployment)

We need to specify the subFolder ./GABDemo/ like explained in #37

So the snippet (line 133)

    - task: DotNetCoreCLI@2
      displayName: 'dotnet publish $(buildConfiguration)'
      inputs:
        command: publish
        publishWebProjects: True
        arguments: '--configuration $(buildConfiguration) --output $(Build.ArtifactStagingDirectory)'
        zipAfterPublish: True

should become

    - task: DotNetCoreCLI@2
      displayName: 'dotnet publish ./GABDemo/ $(buildConfiguration)'
      inputs:
        command: publish
        publishWebProjects: True
        arguments: '--configuration $(buildConfiguration) --output $(Build.ArtifactStagingDirectory)'
        zipAfterPublish: True

@MSDEVMTL/gab2019-contributors
In lab 3 I explain a few ways to open a terminal on Windows, but I have no clue how to open one with a MAC (sorry Apple I am not a customer of yours). For Linux, we could guess that the user knows.

Does any of you know how macs work, so I could replace TODO: how to do that? by more precise instructions? Thanks

In Lab 1, we should open VSCOde at the root
We should remove the line 21-23

It will also avoid error where attendees initialize git in the sub-folder

Here the list of stuff we should add to Lab 1

1- In the Section Create The Azure WebApp (https://github.com/MSDEVMTL/GlobalAzureBootcamp-2019/tree/master/Lab1#create-the-azure-webapp) we should add

• How to validate current subscription (using az account show)
• where is Cloud shell! (https://shell.azure.com/)

In the step

Configure the web app

I think we need more detailed step by step explanation

In the section Deploy automatically your first template (https://github.com/MSDEVMTL/GlobalAzureBootcamp-2019/tree/master/Lab2#part-2---deploy-automatically-your-first-template)

multiple steps are missing. We need to complete this LAB

Now that we are running from a parent folder, the default yaml will fail because there is no .Net Core project at the root.

We need to add the subfolder ./GABDemo/ to the build command

Change

steps:
- script: dotnet build --configuration $(buildConfiguration)
  displayName: 'dotnet build $(buildConfiguration)'

by

steps:
- script: dotnet build ./GABDemo/ --configuration $(buildConfiguration)
  displayName: 'dotnet build ./GABDemo/ $(buildConfiguration)'

In the section Create an Azure DevOps project we need to add instruction to turn on some Preview features like New YAML pipeline creation experience.

Removing precompiled bin/obj from repo

Create clear content explaining step by step what needs to be done. The reader must know exactly what needs to be done without further explanations.

Open question.
Should we use the same resource group that we are using in the previous labs?

Specify that we should use a unique name as it's use as a dns record. If everybody try to use this one, only the first person will be able to create it
az webapp create --name gabcdemo --resource-group gabcdemogroup --plan gabcdemoplan

Indentation needs to be fixed. Nothing crazy but the steps 1,2,3,4... aren't the things at that are at the extreme left. code, text, and images are...

Create clear content explaining step by step what needs to be done. The reader must know exactly what needs to be done without further explanations.

• when talking about the interface IBlobStorageManager, it says BlobStorageManager without the I
• A bit later it says IBlobStorageManager should be IImageAnalyzer
• This typo appears a couple time Blog instead of Blob

In the lab01 it will be great if we could execute the command git Init in the root folder instead of inside your webapp. This way if in the lab02 I add a new folder it will be added to the same repo. Agree? (edited)
we should have something like

c:\dev\gab2019.git
c:\dev\gab2019\GABCDemo
c:\dev\gab2019\Deployment

etc.. (edited)

We need a topic for lab 7
I suggested Test, but it could be something else.

3- In the Section Continuous Integration (https://github.com/MSDEVMTL/GlobalAzureBootcamp-2019/tree/master/Lab1#continuous-integration)

around line 120 of the ReadMe.md file it's not clear how we get the Yaml template.

Just re-work that section to specify to pick the 'Asp.Net Core template' that is by default recommended... a screenshot could be useful.

2- In Section Add a Remote Repository (https://github.com/MSDEVMTL/GlobalAzureBootcamp-2019/tree/master/Lab1#add-a-remote-repository)

• Change the code snippet git remote add origin https:..... by something more clear like git remote add origin https: [URL_FOUND_IN_THE_PREVIOUS_STEP]

it's not clear where we should create the files: Dockerfile and .dockerignore

From the screenshot, it looks at inside folder gab2019 but the folder structure is different from Lab 1 and Lab2.

Remove some files from the Folder Lab 5 (sub-Folder)

• Lab5\deployment\deploy.ps1
• Lab5\GABDemo.gitignore

Create clear content explaining step by step what needs to be done. The reader must know exactly what needs to be done without further explanations.

In the section Initialize Local Repository

the code is wrong:

 git add -A -m "initial commit"  (i dont think that this command works --> should be git add . or git add  -A than you can use git commit -m "initial commit")

• we should review the images for his section, the interface has changed a lot
• on line 120

Click the Add button to add
should be changed by Save and run

Create clear content explaining step by step what needs to be done. The reader must know exactly what needs to be done without further explanations.

Create clear content explaining step by step what needs to be done. The reader must know exactly what needs to be done without further explanations.

Create clear content explaining step by step what needs to be done. The reader must know exactly what needs to be done without further explanations.

at line 22 we need to add a sub-folder /deployment

• task: CopyFiles@2
  inputs:
  sourceFolder: '$(Build.SourcesDirectory)/deployment'
  contents: '?(gab2019.json|gab2019.parameters.json)'
  targetFolder: $(Build.ArtifactStagingDirectory)

Create clear content explaining step by step what needs to be done. The reader must know exactly what needs to be done without further explanations.

Install the Docker extension, see Working with Docker for more information.
Install the Docker Explorer extension.

#1

We need to add a section to explain how to:

• Validate you have at least version 2.x or .Net Core
• How to install/ update .Net Core

In part 2, point 6, also specify that we need to fill up the parameter field with our parameter file. Otherwise it will fail later