The aioregistry from msg555

aioregistry's People

Contributors

Stargazers

aioregistry's Issues

Accessing images from AWS' public registry fails

Attempting to access any image stored on AWS' public registry fails attempting to acquire an access token.

Reproduce:

$ aioregistry public.ecr.aws/lambda/python:3.10
Traceback (most recent call last):
  File "/home/msg/proj/aioregistry/.venv/bin/aioregistry", line 8, in <module>
    sys.exit(sync_main())
  File "/home/msg/proj/aioregistry/aioregistry/cli.py", line 249, in sync_main
    return asyncio.run(main())
  File "/usr/lib/python3.10/asyncio/runners.py", line 44, in run
    return loop.run_until_complete(main)
  File "/usr/lib/python3.10/asyncio/base_events.py", line 649, in run_until_complete
    return future.result()
  File "/home/msg/proj/aioregistry/aioregistry/cli.py", line 133, in main
    return await _main(args)
  File "/home/msg/proj/aioregistry/aioregistry/cli.py", line 219, in _main
    result = _convert_object(await get_object(src_ref))
  File "/home/msg/proj/aioregistry/aioregistry/client.py", line 305, in manifest_download
    async with await self._request("GET", registry, ref.url) as response:
  File "/home/msg/proj/aioregistry/aioregistry/client.py", line 217, in _request
    self.access_tokens[auth_key] = (await auth_resp.json())["access_token"]
KeyError: 'access_token'

Add support

If a registry presents a manifest in a non-canonical format we should still support correctly copying data. We'll need to do one of the following:

Store the original manifest encoding when parsing from an encoded version
Dynamically adjust the written manifest based on the updated digests of sub-objects

My preference is probably to do the former. We maybe should still support the latter, however, in case the destination registry attempts to reformat the digest.

Recommend Projects