Would it be possible to use a yubikey (in pgp/ccid mode) with this app? I take it there currently isn't any support - as I see no mention of it on the wiki.. but it would be neat if there was :D

Create a new entry in the app and sync to your repo
Now on your computer delete or move the entry, sync again with git
Sync with the app and the entry still exists. In the case of a move to a folder, the entry will also exist in the folder now (so now you have it twice).

But syncing to the repo won't add the local entry again to the repo until you change something in the local entry.

Uploading keys using some web server is a fine option, but I think it would be much more secure to use the file sharing mechanism to get the ssh and gpg keys to the device.

Password Store

After saving an empty PGP key, the application crashes:

Debug info:

2017-02-22 13:46:28.102 pass[4066:71397] *** Assertion failure in -[ObjectivePGP keysFromData:], /Users/tyz/src/pass-ios/Pods/ObjectivePGP/ObjectivePGP/ObjectivePGP.m:766
2017-02-22 13:46:28.107 pass[4066:71397] *** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'Empty data'

Also the application will continue to crash immediately after a restart

Blurring app screen (or showing something else) in switch mode so that passwords won't be shown while switching apps.

If field "url" contains valid url then the entry should get the favicon of the website.

Hi,

i had the last days time to test the app.

one of the points that need attention (in my opinion) that the user should be able to choose in which format new created or changed secrets should be stored ... binary or armored.

I always prefer to have my ggp files armored, even if a diff of this is also useless for a human :)

greetings

1. Settings - Repository - SSH Key: Crash if URL is not a valid URL (e.g., empty).
2. Settings - Repository - PGP Key: Crash if URL is not a valid URL (e.g., empty).

Pass allows the creation of passwords in folders.

For example:
’pass insert Business/cheese-whiz-factory’

Currently the app displays all passwords in the top level.

If your gpg pass phrase is incorrect, Pass crashes when trying to decrypt passwords.

Perhaps test and warn when setting up your keys.

I got this information from:
http://stackoverflow.com/questions/10767517/rejected-by-uifilesharingenabled-key-set-to-true

I think it would be better to keep keys in Documents directory and repository in another private directory.

There is no way to delete an entry or move it to another folder. When adding an entry you have to call it something like "private/Test" so that the entry gets moved to the private-folder. And this happens only after sync.
Imho this is fine behavior on the cli but in an iOS-app that should be handled differently by letting the user choose folders and even let them create them new ones.

Hello! Any chance of support for OTP support (as implemented by pass-otp)?

I am trying to clone my repository. It just fails
I tried:
ssh://$domain:/path/to/repo.git
ssh://$domain/path/to/repo.git
$domain:/path/to/repo.git
$domain/path/to/repo.git

I put the username in "username" and added an ssh-key.

Problem 1) The error-message closes itself so fast that I had to make a screenshot to finally see it
Problem 2) The error-message just says that it couldn't clone the repo, but not way
Problem 3) I'd like to add my ssh-keys like adding an armored gpg-key. I do not want to have an ssh-key-pair even so I generated just for this app lying around in the public and just protected by security through obscurity (and its passphrase)

When you have multiple folders, search only works in the current folder. Thus when I am in the "top folder" I cannot find entries in the subfolders.
Let's say I have the following structure
Password Store
├── private
│   ├── foo
│   ├── bar
├── something
│   ├── foo
│   └── bar
└── work
├── pass
├── is
└── cool

And I am on the level of Password store and enter "foo" in the search, I would expect that it shows me the entries:
private/foo and something/foo

It would be great if viewing password history is supported. It would be useful if something got messed up.

Handle PGP settings exception and show error.

Hi,

the user should be able to import more than his own public gpg key and also should be able delete public keys from his device.

in a team setup a secret stored in pass is encrypted with more than your own key.

if you change the secret or create a new one , the app should use all the public keys that are configured in this store to encrypt the secret.

as for now the app only encrypt changed/new secrets with the public key that matches the private key that is configured in the app.

greetings

I added the following
User: username
TOTP-rescue-token 1
TOTP-rescue-token 2
…
TOTP-rescue-token 20

When I hit save, the app crashes. Without the 20 tokens it doesn't crash and everything works.

When concealed, copy dots

Settings -> General -> Remember Phassphrase

It'd be great to have deeper integration with Safari — allowing autofill, password generation and storing.

• Sync
• Clone
• PGP
• SSH key

is it still under review or how do I find this in the appstore?

hey guys,
i try to test your app and stuck at the part of the pgp key. i dont have a webserver where i can upload my keys. so i wanted to use the ascii format. is there a way how i can get it from my linux system to the iphone? it's not jailbroken. but i dont want to send them by mail to my iphone. i tried to generate a qrcode, but the keys are too big for qrencode. do you have any hints?

I followed the steps in the Build section of the README. Upon building the project with Xcode, I get the following errors:

/Users/raxod502/Desktop/Code/iOS/passforios/pass/Helpers/Objective-CBridgingHeader.h:13:9: error: 'ObjectiveGit/ObjectiveGit.h' file not found
#import <ObjectiveGit/ObjectiveGit.h>
        ^
<unknown>:0: error: failed to import bridging header '/Users/raxod502/Desktop/Code/iOS/passforios/pass/Helpers/Objective-CBridgingHeader.h'

This seems to be because something is wrong with CocoaPods. In particular, the Internet suggests that a file called pods.xcconfig is supposed to be generated (it isn't), and that it can cause problems if it is missing.

I don't really know how to debug this further. Any tips would be appreciated—I'd love to get this app working on my phone (typing in my pass-generated Apple ID is getting pretty old).

How to reproduce?

1. Settings - About - Erase All Password Store Data
2. Settings - Password Repository - Add a correct git repository url and a non-empty wrong username, hit "Save" and provide whatever password.

Then, Pass continually prompts for the password (not being able to "cancel" at all).

1. Always add a "cancel" option in the "Please fill in the password of your Git account" dialog. The reason for seeing this dialog is probably "wrong repository url" or "wrong/missing username". It does not make sense if we have to try the wrong password for several times before being able to double check the git repo url or username.
2. Before asking the password, check and make sure that both the "git repo url" field and the "username" field are non-empty. Currently, I am able to hit "Save" without both url and username.
3. Do no go back to the "Settings" page before git clone successes." Currently, If something went wrong, users would have to open "Password Repository" again in order to edit/check the repo url or username.
4. Help users save the time of manually entering "https://" in the git repo url field. I guess everyone has to enter "https://" anyway, right?
5. Make suggestions for the username. It is possible to make suggestions about the "username"? For example, if the git repo url looks like "https://github.com/helloworld/xxxxx*", the corresponding username is probably "helloworld".

Going into General -> About Repository-> Commit Logs crashes when no repo has been loaded.

Set minimal height or expend with user's input.

Static viable but not singlinton.

Password entries are decoded as latin1 instead of utf8. This should be «проверка».

1. settings -> Git Server
   if Authentication is not chosen, crash
2. settings
   if PGP Key is not chosen, crash
3. In the "Password Store" main frame
   if PGP passphrase is not correct, crash
4. PGP Key URL support only https, not including http

Show password as dots. Users can reveal and conceal password by tapping cells.

I've done a fresh build.

When I try and connect to by git server via. SSH using either a password or key files I get a "Unsupported URL protocol". I've tried everything I can think of for the Git Repository URL:

My server name is correct, listening to SSH on port 22, and has a user called "pass" with the password store repo in "pass.git" in the user's home folder.

• server:pass.git (I think this is the right one)
• pass@server:pass.git
• ssh://pass@server:pass.git
• ssh://pass@server:port/home/pass/pass.git
  ...

I found this issue and I'm wondering if the underlying libgit wasn't compiled with SSH support. Maybe Carthage needs some additional hints?

libgit2/git2go#249

password-store-temp" UserInfo={NSLocalizedDescription=Failed to clone repository from [email protected]:22/home/pass/pass.git to file:///var/mobile/Containers/Data/Application/..../Library/password-store-temp, NSUnderlyingError=0x17044fc30 {Error Domain=GTGitErrorDomain Code=-1 "Unsupported URL protocol" UserInfo={NSLocalizedDescription=Unsupported URL protocol}}}

Environment

iOS Version: 10.2.1 (14D27)
Pass for iOS: 0.2 (24)

Steps

1. Export PGP public and private key (4096 RSA key generated by GnuPG) in ASCII-Armor format using the instructions:

gpg --export -a <keyname>
gpg --export-secret-keys -a <keyname>

2. Paste the key into the two edit controls of "PGP Key" window

3. Press "Save" in the upper right corner

4. Enter passphrase in the "PassPhrase" dialog, and press "OK", then press "Save"

Expected Result

The PGP key is saved

Got Result

The program crashed

Crash Log

pass_ios_crash_log.txt

In the first line of readme.md <img src="icon/icon_round.png" width="76"/>, the icon file icon/icon_round.png seems to be missing.

After a fresh start, when I tap the "PGP Key" Button the application crashes.

Here is some info from the debug window:

Terminating app due to uncaught exception 'NSGenericException', reason: 'Your application has presented a UIAlertController (<UIAlertController: 0x7ff5b8f286a0>) of style UIAlertControllerStyleActionSheet. The modalPresentationStyle of a UIAlertController with this style is UIModalPresentationPopover. You must provide location information for this popover through the alert controller's popoverPresentationController. You must provide either a sourceView and sourceRect or a barButtonItem.  If this information is not known when you present the alert controller, you may provide it in the UIPopoverPresentationControllerDelegate method -prepareForPopoverPresentation.'

I am using an iPad Air to test the application.

EDIT:
The issue is not present when application is running in the sidebar.

Random password generated by Apple keychain.

I always use at least ten digits for my iPhone passcodes. It would be nice to have support for this in Pass for iOS.

Relevant: yankodimitrov/SwiftPasscodeLock#55

(But the issue might be upstream.)

Use weak instead of unowned

With other password-managers like 1Password or Enpass for example, I have in some apps the possibility to directly get my password. I guess they all use some way so that apps that integrate the 1Password App Extension can speak with them as well