msteinert / pam Goto Github PK

Apparently v2 tags are not supported.

https://go.dev/blog/v2-go-modules

This issue is a reminder to follow up on a v2 release as described in the link.

I was trying to an extra test to go-pam, to test the finalizer:

3v1n0@693b913

But as you can see from the message, it may not behave as expected.

In fact I feel that calling data finalizers on modules side from a
groutine as SetFinalizer does could create troubles as you can see in
logs from: https://github.com/msteinert/pam/actions/runs/6355635285

PAM per se is thread safe but modules may not and this could be problematic since it's implicitly happening in a goroutine.

So, we decided with @msteinert to just drop this and make usage of End() to be explicit.

../../go/pkg/mod/github.com/msteinert/pam/[email protected]/errors.go:81:21: could not determine kind of name for C.PAM_BAD_ITEM
../../go/pkg/mod/github.com/msteinert/pam/[email protected]/errors.go:84:23: could not determine kind of name for C.PAM_CONV_AGAIN
../../go/pkg/mod/github.com/msteinert/pam/[email protected]/errors.go:88:24: could not determine kind of name for C.PAM_INCOMPLETE

They are probably Linux specific. Can these be OS architecture dependent?