multisafepay / zencart Goto Github PK

The notify_checkout.php script instantiates the multisafepay class without having first included its language file. This generates a number of warnings like this:

Use of undefined constant MODULE_PAYMENT_MULTISAFEPAY_TEXT_TITLE - assumed 'MODULE_PAYMENT_MULTISAFEPAY_TEXT_TITLE' (this will throw an Error in a future version of PHP) in ... includes/modules/payment/multisafepay.php on line 56.

It does include a language file later in the script, but that is too late to prevent the warnings.

I'm not sure if there's an easy way to fix this. It does not seem possible to include the language file at the beginning of the script, because it does not yet know what language file to use. (And it does not seem possible to include all language files, because they all define the MODULE_PAYMENT_MULTISAFEPAY_TEXT_TITLE constant.)

I noticed that orders that were entered after activating a module like "ideal" or "Bancontact" leads to receiving 4 order confirmation e-mails, by both the customer and the admin. Information about this issue is scarce at the moment. I think there might be a compatibility issue with Zencart V1.56c compared to V1.55 for which the MultiSafepay plugin was initially developed. Ideas for how to solve this are very welcome.

I'm seeing some PHP warnings in a site's log files regarding includes/modules/payment/multisafepay_fastcheckout.php:

PHP Warning: Declaration of multisafepay_fastcheckout::getShoppingCart() should be compatible with multisafepay::getShoppingCart($order)
PHP Warning: Declaration of multisafepay_fastcheckout::parseAddress($street_address) should be compatible with multisafepay::parseAddress($address1, $address2 = '')
PHP Warning: Declaration of multisafepay_fastcheckout::checkout_notify() should be compatible with multisafepay::checkout_notify($manual_status = '')

The multisafepay class has an old-style constructor and this generates a warning when the class is used:

Methods with the same name as their class will not be constructors in a future version of PHP; multisafepay has a deprecated constructor in ... includes/modules/payment/multisafepay.php on line 28.