Giter VIP home page Giter VIP logo

mtasa-resources's Introduction

Resources

Resources are a key part of Multi Theft Auto. A resource is essentially a folder or zip file that contains a collection of files - including essential script and content files, plus a meta file that describes how the resource should be loaded - and runs on a Multi Theft Auto dedicated server.

A resource can be seen as being partly equivalent to a program running in an operating system - it can be started and stopped, and multiple resources can run at once. Its worth remember though, that unlike programs on an operating system, there is no multi-tasking between resources. Resources generally contain content and Lua scripts for game modes, user interfaces and other tasks affecting the players that are connected to the dedicated server on which the resources are running.

This project maintains a list of up-to-date resources that come with Multi Theft Auto. These can be checked out by anyone that wishes to run a dedicated server with the latest resources.

For a collection of user created resources, head over to our Community web page which serves as a place for hosting our community's resources.

To report a bug or suggest an idea, please submit a GitHub issue.

License

Unless otherwise specified, all source code hosted on this repository is licensed under the MIT license. See the LICENSE file for more details.

mtasa-resources's People

Contributors

afusensi avatar arcusmaximus avatar arrantuna avatar brenodanyel avatar cazomino05 avatar ccw808 avatar dark-dragon avatar darkdreamingdan avatar dutchman101 avatar einheit-101 avatar fernando-a-rocha avatar fileex avatar itslewiswatson avatar jlillis avatar jushar avatar miki785 avatar necktrox avatar nico8340 avatar norby89 avatar patrikjuvonen avatar qaisjp avatar ricksterhd123 avatar srslyyyy avatar stoneage-mta avatar tapl-93 avatar toady avatar woovie avatar xlive avatar xluxy avatar zangomangu avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

mtasa-resources's Issues

Implement additional rotation attributes in race spawnpoints

Is your feature request related to a problem? Please describe.
The race script currently only supports the 'rotation' attribute in spawnpoints, which maps to the rotZ parameter of createVehicle.

Describe the solution you'd like
Since the map editor already allows you to set the spawnpoint rotation in all 3 axis, I think this should be fairly easy to implement in race as well.

A sample implementation:

[racemap.lua]
g_MapObjAttrs = {
spawnpoint = { 'position', 'rotation', 'vehicle', 'paintjob', 'upgrades', 'rotX', 'rotY', 'rotZ' },

[race_server.lua]
local x, y, z = unpack(spawnpoint.position)
...
vehicle = createVehicle(spawnpoint.vehicle, x, y, z, spawnpoint.rotX or 0, spawnpoint.rotY or 0, spawnpoint.rotation, plate:sub(1, 8))

Additional context
https://bugs.mtasa.com/view.php?id=5992

freecam:setPlayerFreecamOption not work

Which resource(s) have this problem?

freecam
Describe the bug

ERROR:server trigged clientside doSetfreecamOption,butevent is not marked as remotely triggerable.
function not work but thee trigger event not remotely as true
To Reproduce

Expected behavior

addEvent("doSetFreecamOption",true)
Screenshots

ERROR:server trigged clientside doSetfreecamOption,butevent is not marked as remotely triggerable.

Version

he doesn't need it because he's just a simple bug

Additional context

he doesn't need it because he's just a simple bug

admin2: evaluate use of comboboxes

Describe the bug
The comboboxes used are actually buttons with some sort of dropdown image. This issue is to track the use of these custom comboboxes.

First task is to see whether we should move to a native combobox or fix the problems with the current system.

Second task would be to move to a new combobox, or fix the issues described below:

Problems with the current system, and how to reproduce, and what is expected

You can find a combobox on "Resources tab" -> "View type"

What is the problem?
You cannot click the button to open the combobox - you must click the dropdown image.

Why is this bad?
Poor UX

How to reproduce?
Click on the button, then click on the dropdown image

What is the problem?
Clicking the button brings it to the front. If you hold mouse down it will bring it to the front - letting go with mouse outside the button does not send it to the back (if you click the button without moving your mouse then it does send it to the back)

Why is this bad?
It is unexpected behaviour

What is the problem?
The gridlist is misplaced resulting in weird things being clicked sometimes

Why is this bad?
You would expect more accurate selection

How to reproduce?
"Double click slowly" on the dropdown image. Even though the "map" item is the second item down (for the Resources -> View type combobox) it will select that item.

What is expected?
Maybe make the button disabled, make the gridlist headerless, and push it down a little bit so it is not covering the top?
Or you can remove the header and make it an empty item that is unselectable?

Screenshots
image
image

freeroam: blackscreen at respawning with sp command

Which resource(s) have this problem?
freeroam

Describe the bug
If a player use the command sp directly after dying , he get a black screen

To Reproduce
Steps to reproduce the behavior:
In freeroam open F8 console and execute the following commands:

kill
sp

That's the end until you change your skin.

Expected behavior
Respawning of the player

Screenshots
image

MTA Client (please complete the following information):

  • Version v1.5.6-release-14334
  • Running on Windows 7

MTA Server (please complete the following information):

  • OS: Windows 7
  • Version v1.5.6-release-14334

dimension and interior functions not working with collision

Hello,
Today I was trying to set dimension and interior for a collision that I created, and guess what happened?
these functions don't work with a collision. For instance, I created a collision and it appears in all dimension and all interior :/

game version :
Multi Theft Auto v1.5.7-release-20358.1
Code :

addCommandHandler("createColSphere",function(player,_)
x,y,z = getElementPosition(player)
col = createColSphere(x,y,z,5)
setElementDimension(col,6666)
setElementInterior(col,12)
outputChatBox("The dimension of this element is "..getElementDimension(col)..".",player,255,255,255,false)
-- Output : The dimension of this element is 6666.
outputChatBox("The interior of this element is "..getElementInterior(col)..".",player,255,255,255,false)
-- Output : The interior of this element is 12.

end
)


addCommandHandler("createColCircle",function(player,_)
x,y,z = getElementPosition(player)
col = createColCircle(x,y,z,5)
setElementDimension(col,6666)
setElementInterior(col,12)

outputChatBox("The dimension of this element is "..getElementDimension(col)..".",player,255,255,255,false)
-- Output : The dimension of this element is 6666.
outputChatBox("The interior of this element is "..getElementInterior(col)..".",player,255,255,255,false)
-- Output : The interior of this element is 12.

end
)

addCommandHandler("createColCuboid",function(player,_)
x,y,z = getElementPosition(player)
col = createColCuboid(x,y,z,5,5,5)
setElementDimension(col,6666)
setElementInterior(col,12)

outputChatBox("The dimension of this element is "..getElementDimension(col)..".",player,255,255,255,false)
-- Output : The dimension of this element is 6666.
outputChatBox("The interior of this element is "..getElementInterior(col)..".",player,255,255,255,false)
-- Output : The interior of this element is 12.

end
)



addCommandHandler("createColPolygon",function(player,_)
x,y,z = getElementPosition(player)
col = createColPolygon(x,y,z,x+5,y+5,z+5,x-5,y-5,z-5) -- I know its wrong but I want to check only.
setElementDimension(col,6666)
setElementInterior(col,12)

outputChatBox("The dimension of this element is "..getElementDimension(col)..".",player,255,255,255,false)
-- Output : The dimension of this element is 6666.
outputChatBox("The interior of this element is "..getElementInterior(col)..".",player,255,255,255,false)
-- Output : The interior of this element is 12.

end
)

addCommandHandler("createColRectangle",function(player,_)
x,y,z = getElementPosition(player)
col = createColRectangle(x,y,10,10) 
setElementDimension(col,6666)
setElementInterior(col,12)

outputChatBox("The dimension of this element is "..getElementDimension(col)..".",player,255,255,255,false)
-- Output : The dimension of this element is 6666.
outputChatBox("The interior of this element is "..getElementInterior(col)..".",player,255,255,255,false)
-- Output : The interior of this element is 12.

end
)

addCommandHandler("createColTube",function(player,_)
x,y,z = getElementPosition(player)
col = createColTube(x,y,z,5,5) 
setElementDimension(col,6666)
setElementInterior(col,12)

outputChatBox("The dimension of this element is "..getElementDimension(col)..".",player,255,255,255,false)
-- Output : The dimension of this element is 6666.
outputChatBox("The interior of this element is "..getElementInterior(col)..".",player,255,255,255,false)
-- Output : The interior of this element is 12.

end
)

(Race Gamemode) End map when only spectators are left

Is your feature request related to a problem? Please describe.
The race state is normally set to "EveryoneFinished" whenever... well everyone finishes a race. This skips the "timeafterfirstfinish" waiting time and starts a vote for the next map. However this race state is never set when there are spectators still left watching the race after all non-spectating players have finished. This makes it quite frustrating to have any spectators.

Describe the solution you'd like
Set the race state to "EveryoneFinished" when all non-spectating players have finished, as opposed to every single player currently on the server. Perhaps making a new setting to configure whether you'd like to skip waiting for spectators or not.

Describe alternatives you've considered
It is possible to just lower the "timeafterfirstfinish" amount to lower the wait, however then you have issues with people who are trying to race not finishing in time. For longer races you want a higher "timeafterfirstfinish" but for shorter ones waiting for say a minute after a 20 second race for some spectators slows things down a lot.

Additional context
I was planning on adding an afk script to a race server whereby afk players are forced into spectator mode as opposed to just kicking them from the server (say for instance they crashed out early and don't want to continue, or don't like the map and would like to just watch) however with spectators holding the races up it's not worth doing.

admin2: server properties should prevent invalid input

Describe the bug
It is possible to type "hello" in the "game speed" value (e.g.)

To Reproduce
Steps to reproduce the behavior:

  1. Go to Server tab
  2. Click on Game Speed edit
  3. Type "hello"

Expected behavior
Only numbers should be allowed

Screenshots
image

admin2: "cannot resume dead coroutine"

Describe the bug
This error sometimes (one time) appears:

ERROR: admin2/client/widgets/admin_inputbox:72: cannot resume dead coroutine [string "?"]

To Reproduce see comment
Difficult to reproduce.

  1. Manage to trigger the error by editing an input box in the server tab
  2. Showing/Hiding the admin panel will always cause that error to appear

Expected behavior
No error

Fix spam prevention

Describe the bug
Spam (chat and command) prevention needs to be done properly. It is too sensitive.

Expected behavior
Use a back-off algorithm. DIsable spam prevention for people with certain ACL permissions.

admin2: cache meta settings

Is your feature request related to a problem? Please describe.
Currently admin2 does not cache any of its meta settings so it is required to call the get function each time the setting is read.
#161 adds new settings so it would be good to look into this issue first.

Describe the solution you'd like
Implement a system that would cache the settings and update them onSettingChange.

Describe alternatives you've considered

  • Keep calling get function each time the setting is read (may downgrade server performance).
  • Replace meta settings with a different system (database, XML files, etc.)

Additional context
This was already implemented in the old admin resource:
https://github.com/multitheftauto/mtasa-resources/blob/master/%5Badmin%5D/admin/server/admin_serverprefs.lua
It could be improved further by adding 'serveronly' attribute so not all settings are sent to the client.

admin2: shutdown reason does not work

Describe the bug
Shutdown reason does not show a reason to players.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Server
  2. Click on shutdown
  3. Type in a reason
  4. Click shutdown
  5. See shutdown message

Expected behavior
Shutdown reason to show. If feature unavailable in MTA, implement it OR replace with "are you sure" dialog.

Screenshots (GIF)
2018-07-22_16-26-40-min

Ghostmode race custom transparancy %

Is your feature request related to a problem? Please describe.
When in racemode with ghostmode, the other cars aren't transparent enough! I can't properly differentiate my car vs others at the start of a race.

Describe the solution you'd like
A transparency setting for ghostmode races, so I can set the transparancy to whatever I'd like!

Additional context
The server I'm on offers /hide to hide all other players, but I'd like to see them so I can compare & improve

admin2: navigate to players from search box

Is your feature request related to a problem? Please describe.
I find it frustrating having to click on the gridlist after searching from the search box!

Describe the solution you'd like
Pressing down from the searchbox should go onto the gridlist. Pressing up on the first item should go onto the search box.

Describe alternatives you've considered
Press tab and shift+tab instead? Potential clash with changing tabs there. We should keep away from these shift+tab/tab keybinds until we have decided on an overall keybind plan.

Additional context
This is an enhancement to be worked on after feature parity is established (or when someone is super duper bored).

Screenshots cannot be viewed after creating them

Which resource(s) have this problem?
admin

Describe the bug
When creating a screenshot via the admin panel you can not view it again.

To Reproduce
Steps to reproduce the behaviour:

  1. Open Admin Panel
  2. Select any player
  3. Click screenshots
  4. Take a new screenshot
  5. Select the screenshots from the menu
  6. Click on View
  7. Observe that if you try to view it again you won't be able to access it

Expected behavior
Selected screenshot to be shown

Version
Server v1.5.6-release-18427
Client v1.5.6-release-18427.3
Windows 10 - 64 Bit

Additional context
Server Error Messages:

WARNING: admin\server\admin_screenshot.lua:55: Bad argument @ 'fileGetSize' [Expected scriptfile at argument 1, got boolean]
WARNING: admin\server\admin_screenshot.lua:55: Bad argument @ 'fileRead' [Expected scriptfile at argument 1, got boolean]
WARNING: admin\server\admin_screenshot.lua:56: Bad argument @ 'fileClose' [Expected scriptfile at argument 1, got boolean]
WARNING: admin\server\admin_screenshot.lua:54: Bad usage @ 'fileOpen' [unable to load file 'screenshots/1.jpg']
WARNING: admin\server\admin_screenshot.lua:55: Bad argument @ 'fileGetSize' [Expected scriptfile at argument 1, got boolean]
WARNING: admin\server\admin_screenshot.lua:55: Bad argument @ 'fileRead' [Expected scriptfile at argument 1, got boolean]
WARNING: admin\server\admin_screenshot.lua:56: Bad argument @ 'fileClose' [Expected scriptfile at argument 1, got boolean]

Client Error Messages:

WARNING: admin\client\gui\admin_screenshot.lua:133: Bad argument @ 'fileWrite' [Expected string at argument 2, got nil]
WARNING: admin\client\gui\admin_screenshot.lua:136: Bad argument @ 'addEventHandler' [Expected element at argument 2, got nil]

Not sure if this is also relevant:

CEGUI Error Message:

(Error)	Exception: Failed to create Texture object from file 'C:\Program Files (x86)\MTA San Andreas 1.5\mods\deathmatch\resources\admin\screenshots\1560438598.jpg

admin2: misbehaviour if you perform user operations without mouse-selecting them

Which resource(s) have this problem?

admin2

Describe the bug

Some details do not update if you select yourself this way.

To Reproduce

  1. Restart admin2
  2. Press p to load the admin panel
  3. Press the DOWN arrow key to select yourself
  4. Note how ip, serial, country, account and groups are all UNSET
  5. Press mute, and notice how the mute button does not now say "Unmute"
  6. Press mute again, and it tries to mute you again

Expected behavior

  1. Select yourself in the sidebar using your mouse
  2. Note how ip, serial, country, account and groups are all set correctly now
  3. Note how the Mute button now says Unmute (and works correctly now)

Screenshots

Version

Additional context

image
admin

admin2: clearchat command

Describe the solution you'd like

the /clearchat command should clear the chat.

Additional context

  1. It should be its own entry in acl.xml
  2. The defaults should match setPlayerMuted imo
  3. Please also backport to regular admin resource

Parachute

Which resource(s) have this problem?
The parachute resource

Describe the bug
Skydiving feels completely different in comparison to SA-MP or San Andreas

To Reproduce
Jump off a high building in sa-mp or SA, try to skydive and turn around and move forward. Then do the same in MTA, and notice the difference.

Expected behavior
Have the parachute behave the same way as in the other mentioned versions. (That also includes skydiving)

Version
Multi Theft Auto v1.5.6-release-16588

Additional context
If there is a solution to this, I would love to be redirected to it. It's pretty frustrating that it has to behave completely different in comparison to the regular San Andreas game.

Maxed out skills resets while testing map

Which resource(s) have this problem?
defaultstats

To Reproduce
Steps to reproduce the behaviour:

  1. Start Freeroam, then defaultstats.
  2. Spawn any bicycle, hold jump button and release to make high jump.
  3. Start Map Editor and press F5.

Now repeat the same steps of number 2.

Expected behaviour
Everytime Freeroam starts after press Full Test your maxed out skills resets because defaultstats automatically stop so you can't do bicycle high jump or shoot while walking, for example.

admin2: add extended ban features

This request is the result of a discussion in #development on 12th June 2019.

Is your feature request related to a problem? Please describe.
admin2 currently has no feature parity with admin1 when it comes to ban features

Describe the solution you'd like
Make sure ban-related features that are present in admin1 will also be in admin2

Describe alternatives you've considered
The current ban-related features in admin2 aren't suitable for modern-day use. For example, there's only support for IP banning and not serial banning. Besides that, the set of features are very limited; see below at context. We really need a rewrite of ban features in admin2 overall, no alternatives.

Additional context

Current situation:

  • There is only 1 way to add a ban: select player from list. You cannot offline-ban or add manual bans in the "Bans" tab.
  • The ban you can add from playerlist is limited to an IP ban.
  • The "Bans" tab offers an "Unban" button for IP bans. That's it.
  • There is a ban search bar in the "Bans" tab

So we currently got a minimal, outdated set of ban-related features.

Required situation:

  • You can add bans both from player list and the "Bans" tab.
  • Both serial and IP bans are supported, online ban (from player list) and "Bans" tab should largely share the same ban customisation window

The ban customisation window should include:

For online bans:

  • Ban reason
  • Ban type (IP / serial)
  • Duration (custom mins/days/hours and predefined values like in admin1)

For offline bans/from the "Bans" tab:

  • "Ban IP" and "Ban serial" buttons like in admin1 (or as simplification over admin1, merge them into "Add ban" in admin2)
  • Duration (custom mins/days/hours)
  • Fields to enter player nick and ban reason

Implementing this list would result in feature parity with admin1 and suitability for modern-day usage in regards to banning.
To further explain, I will add screenshots of current ban-related features supported by admin1 that were described:

ban1

ban2

Issue description edit: added note about the ban search bar's presence in admin1. I personally don't think it's a hard requirement, but it would be nice to also offer it in admin2 to achieve full feature parity and not make admin2 less attractive than admin1 in terms of such a feature.

editor_main: save doesn't save element dimension

Which resource(s) have this problem?
editor_main

Describe the bug
Saving map doesn't save element dimensions.

To Reproduce
Steps to reproduce the behaviour:

  1. Spawn an object, vehicle or marker
  2. Set its dimension to something other than 0
  3. Save the map
  4. Open the map file
  5. dimension attribute's value is 0 for all elements

Expected behavior
Save elements' set dimension.

Additional context
Related comment by @botder

I'm currently working on a PR to close this issue.

EDF custom vehicle rotation doesn't match actual vehicle rotation

Which resource(s) have this problem?
Not sure, edf, editor_main maybe

Describe the bug
The rotation of a custom element represented by a vehicle seems to work differently than the rotation of an actual vehicle.
For example, if I want to use that custom element's rotation to do something with real vehicles, It won't work as expected.
This doesn't happen with all rotations.

To Reproduce

  1. Define a custom element that is represented by a vehicle, for example:
	<element name="customveh" friendlyname="Custom vehicle">
		<vehicle editorOnly="true" model="!model!" />
		<data name="model" type="vehicleID" default="411" />
		<data name="position" type="coord3d" default="0,0,0" />
		<data name="rotation" type="coord3d" default="0,0,0" />
	</element>
  1. Place one in a map
  2. Set it's rotation to x:345 y:180 z:90
  3. Save the map and play it
  4. Create a vehicle through scripting and set it's rotation to the same as the custom element in the map file -> Rotations do not match

Expected behavior
If I create a custom element represented by a vehicle it's rotation should match an actual vehicle rotation.

Screenshots
See 'additional context'

Version
1.5.6

Additional context
I made a forum post regarding this problem
https://forum.mtasa.com/topic/117044-possible-editor-bug/

Freeroam Warp wnd Search Player

Which resource(s) have this problem?

Freeroam
Describe the bug

if you write player name you can't find him
To Reproduce

Go to warp
Click on the editbox
Write player name
function not work

Expected behavior

Screenshots

Version

Additional context

Add exported function to toggle realdriveby on/off for the player

Is your feature request related to a problem? Please describe.
Right now it is not possible to disable realdriveby feature for the player. It is always force-enabled. It would be useful to be able to disable it for special cases such as entering a non-driveby area etc.

Describe the solution you'd like
Add an exported function that toggles the ability to driveby.

Additional context
A scripter found this to be a problem while he wanted to disable driveby inside a specific colshape. Can't do that easily.

admin2: admin rights button

Is your feature request related to a problem? Please describe.
admin1 has a "Give admin rights" and "Revoke admin rights" button. Historically this has been kinda buggy.

Describe the solution you'd like
Make sure this feature is in admin2, and make sure it is working correctly.

Describe alternatives you've considered
Remove this feature from admin2.

Additional context
Ported from Mantis 0005112

Web Resource doesnt work due jQuery

Which resource(s) have this problem?
(Please do not include the resource in the title as we will assign a label)
webmap

Describe the bug
Whenever you open your webbrowser and access the resource / html file, you're getting the following error:

script.js:17 Uncaught ReferenceError: $ is not defined
at init (script.js:17)
at onload (map.htm:14)

To Reproduce
Steps to reproduce the behavior:

  1. start the resource
  2. load the http page (http://localhost:22005/webmap/map.htm on localhost)

Additional context
Maybe we should remove ajax resource and make use of jquery - we're not living in the past...

  • Luxy.c

admin2: "rights" tab incomplete

Describe the bug
the "rights" tab is partially complete

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'rights'
  2. Click on 'acl matrix'
  3. Nothing except "ACL matrix" works

Expected behavior
it should work

upgrade admin,parachute and freeroam

admin :
WARNING: admin/server/admin_server.lua(Line 1042) [Server] doesPedHaveJetPack is deprecated and may not work in future versions. Please replace with isPedWearingJetpack.
WARNING: admin/client/gui/admin_main.lua(Line 476) [Client] doesPedHaveJetPack is deprecated and may not work in future versions. Please replace with isPedWearingJetpack.

parachute:
WARNING: parachute/skydiving_cl.lua(Line 22) [Client] doesPedHaveJetPack is deprecated and may not work in future versions. Please replace with isPedWearingJetpack.

freeroam:
WARNING: freeroam/fr_client.lua(Line 799) [Client] doesPedHaveJetPack is deprecated and may not work in future versions. Please replace with isPedWearingJetpack.

and fix this error: ERROR: freeroam\fr_client.lua:1016: attempt to index local 'player' (a nill value)

admin2: "set game type" and "set map name" show the wrong title

Describe the bug
On the server tab, clicking "Set Game Type" or "Set Map Name" will show a popup for the other one. It is just a mistake in the text. The button shows a popup that eventually does the correct thing although has an incorrect text.

To Reproduce
Steps to reproduce the behavior:

  1. Make sure admin2 is in ACL
  2. Go to server tab
  3. Click set game type
  4. The popup that appears says "enter map name"
  5. Filling in that form will actually update the game type, and not the map name

Expected behavior
Correct text.

Screenshots
gif:
2018-07-22_15-31-05

admin2: input boxes should disable input

Describe the bug
Input boxes still trigger binds

To Reproduce
Steps to reproduce the behavior:

  1. bind 1 say hello
  2. Click on Server tab
  3. Edit one of the fields and type in 1
  4. See hello being sent in the chat

Expected behavior
guiSetInputMode('no_binds_when_editing') or similar

admin2: overhaul glitches and world properties

Describe the bug
Since the initial development of admin2 a number of world properties and glitches have been created. These are missing in the interface.

To do

  1. Evaluate whether we should stick to a list of checkboxes (I think a gridlist of green/red glitches/props would be good, with an on/off column for the colourblind, would be good)
  2. Add the extra glitches and props
  3. Implement new system if needed
  4. Push

Screenshots
image
image
image

admin2: permanent mute from serial

Is your feature request related to a problem? Please describe.
I would like to mute abusive players. Permanently.

Describe the solution you'd like
An option to mute players permanently from the menu. Based on serial or IP.

Details
We would need a way to store serial and IP mutes as well as a way to track the associated player (just list the name that was banned?)

Additional context
Request received from forum seems reasonable.

Please add "permanently from IP" and "permanently from serial".
image

Editor-Objects not created in dimension

Describe the bug

Certain Map-Objects that have a dimension above zero are not created correctly in versions newer than 1.5.6-9.14640.0

Any object with the dimension-tag greater than zero is created in dimension 0.

<object id="object (wdpillar01_lvs) (53)" breakable="true" interior="11" collisions="true" alpha="255" model="3498" doublesided="false" scale="1" dimension="12" posX="518.53027" posY="-20.71973" posZ="948.82001" rotX="0" rotY="90" rotZ="0"></object>

The above object is not created in dimension 12 but oddly in dimension 0.

To reproduce

Update to any recent version.
Update the default resources.
Create a map with an interior above zero as well as a dimension above zero.
Checkout said map.

Expected behaviour

The map-object should be created at the given location, dimension, interior.

Version
1.5.6-9.14664.0

Additional context

EDF Can't open properties window for object element

Which resource(s) have this problem?
editor

Describe the bug
Well you can't open the properties window by double click or other way

To Reproduce
just create s simple edf file like this

<def name="test">
    <element name="custom_object" friendlyname="Custom Object" icon="edf/object.png">
        <data name="model" type="objectID" default="1271" />
        <data name="position" type="coord3d" default="0,0,0" />
        <data name="rotation" type="coord3d" default="0,0,0" />
        <object model="!model!" position="!position!" rotation="!rotation!" />
    </element>
</def>

then spawn custom_object and try to double click nothing happens only with object

admin2: weather input is broken

Describe the bug
Cannot edit weather field or select weather from dropdown(?)

To Reproduce
Steps to reproduce the behavior:

  1. Go to Server tab
  2. Click on 'Weather field (doesn't work)
  3. Push on Blend/Set (causes error because empty field, see #100)

Expected behavior
To be able to set the weather

Screenshots
gif of new admin resource:
2018-07-22_16-19-38

old admin resource did this:

2018-07-24_01-11-18

admin2: scripts still use admin1's messagebox format

Scripts still use admin1's messagebox system.
Admin2 uses coroutines instead of passing actions as arguments and admin2 scripts do not yet make use of this new format, thus causing bugs.

Expected behavior
Admin2 should make use of the new messagebox format.

Admin2 also calls aMessageBox() which is a table in admin2.
The correct function to call should be messageBox()
https://github.com/multitheftauto/mtasa-resources/blob/master/%5Badmin%5D/admin2/client/widgets/admin_messagebox.lua#L26

admin2: resource settings are broken

Describe the bug
It is not possible to edit resource settings.

To Reproduce
Steps to reproduce the behavior:

  1. Add admin2 to ACL admin
  2. Click on Resources
  3. Scroll down to any resource that has settings
  4. Double click fields to edit a setting
  5. You receive an error

Expected behavior
To be able to edit resource settings

Screenshots
image

Jetpack function causes errors on recent server versions

Describe the bug
Latest resources causes errors such as attempt to call global 'isPedWearingJetpack' (a nil value)

To Reproduce

  1. Open admin panel and give jetpack to player

Expected behavior
Player gets jetpack

MTA Client (please complete the following information):

  • Version 1.5.5-9.12411
  • Running in Wine? No

MTA Server (please complete the following information):

  • OS: Debian
  • Version 1.5.5-9.12250

admin2: whowas command

Is your feature request related to a problem? Please describe.
In multitheftauto/mtasa-blue@0cffa92 the whowas command was removed. I can't use it anymore ๐Ÿ˜ข

Describe the solution you'd like
Please implement a new whowas command.

Describe alternatives you've considered
n/a

Additional context
A GUI for this would also be cool.

Markers don't retain their dimension

Which resource(s) have this problem?
Editor

Describe the bug
When setting a dimension for a marker, then saving and reloading, it is set to 0 again.

To Reproduce

  1. Create a marker
  2. Set it's dimension to something that isn't 0
  3. Save the map
  4. Load the map
  5. Notice that the dimension is set back to 0

Expected behavior
The marker to still be in whatever dimension I put it into

Screenshots
N/A

Version
Server: Windows 10, 1.5.7
Client: Windows 10, 1.5.7

Additional context
Opening a map that already has a marker set to another dimension will have it be loaded into that dimension.
However, trying to modify that and saving it (e.g. from 40 to 3) will not save the new value either.

runcode resource should log executed lua strings

Is your feature request related to a problem? Please describe.

Currently, the runcode resource is not logging anything when someone runs a lua string which could potentially lead to abusive behaviours.

Describe the solution you'd like

Write executed string & info about that user to a log file (or outputDebugString ?)

What do you guys think about it ?

admin2: input validation for server props

Describe the bug
Typing nothing or letters into server props cause a server error.

To Reproduce
Steps to reproduce the behavior:

  1. Go to server tab
  2. Click on game speed
  3. Type hello or empty the box
  4. Click set

Expected behavior
Set should either be disabled OR input validation is performed and the operation is blocked when you click Set.

Additional context
Related to #100 so inputting hello should not be possible. Only empty inputs need to be checked. Alternatively an empty input can set it to the default.

edf: add missing map attributes

Is your feature request related to a problem? Please describe.
Various map attributes are missing from the edf. Also from the editor menus.

Describe the solution you'd like
Add them in.

Additional context
Also include any new map attributes, such as those here once and if applied: multitheftauto/mtasa-blue#263

mta version bumped higher version than the latest version

Describe the bug
The resource parachute bumps the required version higher (1.5.5-9.13176.0) than the latest from the updater (1.5.5-9.12411.0). This confuses and prevent players to join the gameserver.

To Reproduce
Steps to reproduce the behavior:

  1. Download the latest mta resources
  2. Start the parachute resource

Expected behavior
The latest version of mtasa resource should not bump the required mta version higher than the current latest mta version. Maybe create a seperate branch for such changes.

MTA Client (please complete the following information):

  • Version 1.5.5-9.12411.0
  • Running in Wine? No

MTA Server (please complete the following information):

  • OS: Linux (Docker Debian)
  • Version 1.5.5

Additional context
The commit which broke it 81e03e1

Output of the server log
https://i.imgur.com/Ju9P42z.png

admin2: decide content for "network" tab

Is your feature request related to a problem? Please describe.
There is a "network" tab and some existing code (client, server). Let's brainstorm features to put into this tab.

Describe the solution you'd like
This issue does not aim to implement the Network tab. This issue is for us to discuss potential features we can include. A separate issue will be filed by an MTAQA member describing how the "Network" tab will function at a later date.

What the tab looks like currently
image

freeroam: fast-firing bug with weapon command

This bug enables a player to shoot otherwise slow-firing weapons (such as sniper, country rifle) at a high rate. It can easily be abused to gain an unfair advantage.

Reproduction (example for sniper):

  • bind /wp 34 to a key
  • get a sniper
  • start aiming, fire a shot, and in the refractory period (otherwise the delay) quickly hit the bind
  • keep hitting the bind shortly after each shot

By staying slightly under the default anti-command spam threshold, you can still get the maximum achievable firing rate gain as in the video below.

Reproduction video:
https://www.youtube.com/watch?v=Pgrn_aK0_78

admin2: automatic scripts

Describe the bug
"Automatic scripts" can be seen on the "Server" tab but you cannot edit the fields.

To do

  1. Investigate the existing code
  2. Link up the GUI with the existing code OR implement the features

Expected behavior
To be able to edit the fields

Screenshots
image

admin2: auto focus primary items in tabs

Is your feature request related to a problem? Please describe.
I find it frustrating having to click onto a search box or input box after changing tab!

Describe the solution you'd like
Clicking onto a tab should automatically focus the search box (or for admin chat, the chat input box).

Additional context
This is an enhancement to be worked on after feature parity is established (or when someone is super duper bored).

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.