munin-monitoring / pymunin3 Goto Github PK

Munin now allows for plugins providing configuration and values in one run. The protocol extension is called dirtyconfig and is meant to reduce execution time.

Best approach is probably to extent the MuninPlugin class to include a hasDirtyconfig attribute and then handle everything else in config().

As suggested by @kenyon on IRC, let's move PyMunin3 to Munin Monitoring. Especially, if people come up with plugins based on PyMunin3, it feels like the natural habitat for this package.

Let's go and join the murder!

In config():

for (parent_name, subgraph_names) in self._subgraphNames.items():
    for graph_name in subgraph_names:
        graph = self._subgraphDict[parent_name][graph_name]
        print(
            "multigraph %s" % self.getMultigraphID(parent_name, graph_name)
        )
        print(self._formatConfig(graph.getConfig()))
        print()

In the print statement self.getMultigraphID should be self._getMultigraphID.

From munin irc:

12:18        bcg | Penguinpee: Interesting. Any plans for rhel9 rpm?
12:25 Penguinpee | Do you happen to know the version of setuptools shipped in el9? I have to hit the road. I can try doing a scratch build
                 | later on to find out if the version of setuptools is new enough. It needs to be >=61.
12:28        bcg | python3-setuptools-53.0.0-10.el9.noarch
12:32        bcg | PyMunin3 looks nice and I might use that for my plugins, but rhel9 support is mandatory for me.

If that matters, I'm the maintainer of munin.rpm in EPEL and Fedora. I've also written 10+ plugins for it in Python.