murraycu / ios-galaxyzoo Goto Github PK

On Android, on tablets (like iPads) we use the normal layout for portrait orientation. For instance:
https://github.com/murraycu/android-galaxyzoo/blob/master/google_play_store_graphics/screenshots_tablet_10inch/screenshot_nexus10_api21_portrait_classify_spirals.png

But for landscape orientation on Android tablets we put the questions at the side, like so:
https://github.com/murraycu/android-galaxyzoo/blob/master/google_play_store_graphics/screenshots_tablet_10inch/screenshot_nexus10_api21_landscape_classify_first.png

This lets us see the image as large as possible without stretching the answer buttons too much horizontally. The end result doesn't look ideal, but we should probably do the same for iPad, at least until we think of something better.

On some devices (maybe iPhone 4 or 5), I think we are not shown the whole height of the image. Maybe it's somehow under the top navigation toolbar.

The buttons don't currently show the text in quite the correct position. This code probably needs some improvement:
https://github.com/murraycu/ios-galaxyzoo/blob/master/ios-galaxyzoo/QuestionAnswerButton.m#L29

See also: #4

Not sure if this is intended behavior or not, but the list is showing me objects in the queue as well as those I've already classified. I think it shouldn't show any images I haven't yet classified, right?

There are some reports via the app store's crash reporter of crashes after the user has pressed the revert button, but I cannot reproduce this myself.

Some items seem to arrive in the wrong place, moving older items down the list, and then they jump to their correct positions. This shouldn't be happening because the Subjects should just be sorted by their datetimeRetrieved, which is an ios date string that should always alphabetically increase:
https://github.com/murraycu/ios-galaxyzoo/blob/master/ios-galaxyzoo/UI/Utils.m#L17

A subject viewer screen should be visible when you click on an already-classified subject in the list.
It should reuse this view controller for the image part of the UI:
https://github.com/murraycu/ios-galaxyzoo/blob/master/ios-galaxyzoo/SubjectViewController.m

It needs to do what the android version does:
https://github.com/murraycu/android-galaxyzoo/blob/master/google_play_store_graphics/screenshots_phone/screenshot_nexus4_api21_classify_spirals.png
via its code:
https://github.com/murraycu/android-galaxyzoo/blob/master/app/src/main/java/com/murrayc/galaxyzoo/app/SubjectViewerFragment.java

I didn't get an error message when I tried to log in, but it didn't succeed either; I had assumed it wasn't yet supported, but perhaps not!

The first time we open the app in German, the buttons are not big enough for their text. Clicking a button, or going to another screen (help, login, for instance), and going back, makes the button arrange itself properly from then on.

The app is working really well so far on my 4S, though when I try to login the keyboard blocks the "Sign In" link:

I then can't get the keyboard to disappear (tapping outside the text boxes just brings up the "forgot password" page, even when I'm tapping very far from that link), and I didn't have a "Go" option from the keyboard, so I haven't been able to log in.

Although the zooniverse server responds to our POSTs with 201 (Created), it doesn't seem to really be accepting them. For instance, they don't show up in my profile page
http://www.galaxyzoo.org/#/profile
though I am supplying the correct name and api_key in the Authorization header, correctly I think.

These request have the User-Agent set as "murrayc.com-ios-galaxyzoo" so they should be easy to find on the server's side. Maybe someone there can see what the server doesn't like about them.

For instance, this is the body (content) of the request:

%5Bsubject_ids%5D%5B%5D=5500598269736d5162160800&classification%5Bannotations%5D%5B0%5D%5Bsloan_singleband-0%5D=a-1&classification%5Bannotations%5D%5B1%5D%5Bsloan_singleband-1%5D=a-1&classification%5Bannotations%5D%5B2%5D%5Bsloan_singleband-2%5D=a-1&classification%5Bannotations%5D%5B3%5D%5Bsloan_singleband-3%5D=a-0&classification%5Bannotations%5D%5B4%5D%5Bsloan_singleband-9%5D=a-1&classification%5Bannotations%5D%5B5%5D%5Bsloan_singleband-10%5D=a-1&classification%5Bannotations%5D%5B6%5D%5Bsloan_singleband-4%5D=a-2&classification%5Bannotations%5D%5B7%5D%5Bsloan_singleband-5%5D=a-1&classification%5Bannotations%5D%5B8%5D%5Bsloan_singleband-11%5D=a-1&classification%5Bannotations%5D%5B9%5D%5Buser_agent%5D=murrayc.com-ios-galaxyzoo

And these are the headers that are set:

    Authorization = "REDACTED_BUT_I_AM_QUITE_SURE_IT_IS_CORRECT";
    "Content-Length" = 734;
    "Content-Type" = "application/x-www-form-urlencoded";
    "User-Agent" = "murrayc.com-ios-galaxyzoo";

Something must be wrong with the POST request that we make in uploadClassifications:
https://github.com/murraycu/ios-galaxyzoo/blob/master/ios-galaxyzoo/client/ZooniverseClient.m#L517
though it seems to be doing the same thing as the similar (working) code in the Android app:
https://github.com/murraycu/android-galaxyzoo/blob/master/app/src/main/java/com/murrayc/galaxyzoo/app/provider/client/ZooniverseClient.java#L305

When opening the help (examples) screen (via the i icon) and then returning to the classification screen, the buttons briefly flicker as they show the wrong text (from other buttons) and then the correct text. There is some green flickering in between the buttons too.

Apparently we should set networkActivityIndicatorVisible during any (even background) network activity to show a spinner in the toolbar.

In XCode (6.3), when setting Product->Destination to Simulator: iPhone 4S or iPhone 5, I get this linker error. Note the "file was built for x86_64 which is not the architecture being linked".

I don't have this problem when using the iPhone 5s or iPhone 6s simulators and I'm fairly sure that I didn't always have this problem with those simulator targets.

Ld /Users/murrayc/Library/Developer/Xcode/DerivedData/ios-galaxyzoo-amipkzucemghvagnemtgshdtgysk/Build/Intermediates/ios-galaxyzoo.build/Debug-iphonesimulator/ios-galaxyzooTests.build/Objects-normal/i386/ios-galaxyzooTests normal i386
    cd /Users/murrayc/Documents/xcode_projects/ios-galaxyzoo
    export IPHONEOS_DEPLOYMENT_TARGET=8.3
    export PATH="/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/usr/bin:/Applications/Xcode.app/Contents/Developer/usr/bin:/usr/bin:/bin:/usr/sbin:/sbin"
    /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang -arch i386 -bundle -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator8.4.sdk -L/Users/murrayc/Library/Developer/Xcode/DerivedData/ios-galaxyzoo-amipkzucemghvagnemtgshdtgysk/Build/Products/Debug-iphonesimulator -F/Users/murrayc/Library/Developer/Xcode/DerivedData/ios-galaxyzoo-amipkzucemghvagnemtgshdtgysk/Build/Products/Debug-iphonesimulator -F/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator8.4.sdk/Developer/Library/Frameworks -F/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/Library/Frameworks -F/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator8.4.sdk/Developer/Library/Frameworks -filelist /Users/murrayc/Library/Developer/Xcode/DerivedData/ios-galaxyzoo-amipkzucemghvagnemtgshdtgysk/Build/Intermediates/ios-galaxyzoo.build/Debug-iphonesimulator/ios-galaxyzooTests.build/Objects-normal/i386/ios-galaxyzooTests.LinkFileList -Xlinker -rpath -Xlinker @executable_path/Frameworks -Xlinker -rpath -Xlinker @loader_path/Frameworks -bundle_loader /Users/murrayc/Library/Developer/Xcode/DerivedData/ios-galaxyzoo-amipkzucemghvagnemtgshdtgysk/Build/Products/Debug-iphonesimulator/ios-galaxyzoo.app/ios-galaxyzoo -Xlinker -objc_abi_version -Xlinker 2 -framework XCTest -fobjc-arc -fobjc-link-runtime -Xlinker -no_implicit_dylibs -mios-simulator-version-min=8.3 -Xlinker -dependency_info -Xlinker /Users/murrayc/Library/Developer/Xcode/DerivedData/ios-galaxyzoo-amipkzucemghvagnemtgshdtgysk/Build/Intermediates/ios-galaxyzoo.build/Debug-iphonesimulator/ios-galaxyzooTests.build/Objects-normal/i386/ios-galaxyzooTests_dependency_info.dat -o /Users/murrayc/Library/Developer/Xcode/DerivedData/ios-galaxyzoo-amipkzucemghvagnemtgshdtgysk/Build/Intermediates/ios-galaxyzoo.build/Debug-iphonesimulator/ios-galaxyzooTests.build/Objects-normal/i386/ios-galaxyzooTests

ld: warning: ignoring file /Users/murrayc/Library/Developer/Xcode/DerivedData/ios-galaxyzoo-amipkzucemghvagnemtgshdtgysk/Build/Products/Debug-iphonesimulator/ios-galaxyzoo.app/ios-galaxyzoo, file was built for x86_64 which is not the architecture being linked (i386): /Users/murrayc/Library/Developer/Xcode/DerivedData/ios-galaxyzoo-amipkzucemghvagnemtgshdtgysk/Build/Products/Debug-iphonesimulator/ios-galaxyzoo.app/ios-galaxyzoo
Undefined symbols for architecture i386:
  "_OBJC_CLASS_$_DecisionTree", referenced from:
      objc-class-ref in TestDecisionTree.o
  "_OBJC_CLASS_$_ZooniverseHttpUtils", referenced from:
      objc-class-ref in TestZooniverseHttpUtils.o
ld: symbol(s) not found for architecture i386
clang: error: linker command failed with exit code 1 (use -v to see invocation)

Oddly, one Subject doesn't have locationStandardDownloaded (and other *Downloaded) set to YES after the app restarts, so we have to check that the image files really exist (they do) and then set those BOOLs to YES. For some reason the Core Data for those properties is not persisting, though it does for all other Subject instances.

See https://github.com/murraycu/ios-galaxyzoo/blob/master/ios-galaxyzoo/client/ZooniverseClient.m#L314

The app seems to require iOS 8 at the moment. That shouldn't be necessary.

The Android app has a menu, like most Android apps, which lets you do extra stuff, such as:

• marking a subject as a favorite
• logging in
• restarting the classification
  For instance, https://github.com/murraycu/android-galaxyzoo/blob/master/google_play_store_graphics/screenshots_phone/screenshot_nexus4_api21_classify_menu.png

I don't know of any official iPhone UI standard for this kind of thing, but we do need to make these features available to the user without slapping buttons onto the screen always.

There classify screen (ClassifyViewController) has two main parts: The SubjectViewerController and the QuestionViewController below it. The QuestionViewController should take as much height as it needs, and the SubjectViewController should shrink to take up whatever space is left over.

At the moment, because this doesn't work properly, the second row of answer buttons is not visible.

The small per-item spinners don't stop spinning. They should disappear eventually. I've even seen them on items whose classifications have already been uploaded.

The help screen should show all the example icons for all the answers, and open the full images when the user clicks on them. For instance, in the Android app:
https://github.com/murraycu/android-galaxyzoo/blob/master/google_play_store_graphics/screenshots_phone/screenshot_nexus4_api21_classify_help.png

Some code for this exists already but it just shows the help text so far:
https://github.com/murraycu/ios-galaxyzoo/blob/master/ios-galaxyzoo/HelpViewController.m

The question object there already has all the data that's needed.

This is how the Android app does it:
https://github.com/murraycu/android-galaxyzoo/blob/master/app/src/main/java/com/murrayc/galaxyzoo/app/QuestionHelpFragment.java

I'm using the app with my iPad; I've noticed that if I rotate my screen during the classification the new placement of the items on the screen is a little weird, such that often some of the answer choices end up off the screen. If I answer the question while rotated, the next question comes up with the correct alignment.