murraysum / honeybadger-api Goto Github PK

Hey,

I'm using latest version and since today, I have a problem with paginator.
Pulling notices like this:
notices = Honeybadger::Api::Notice.paginate(project_id, fault_id, { created_after: created_after })
There is a NoMethodError: undefined method '<' for nil:NilClass when trying to access next page with notices.next?

After updating to 2.0.0 version i've encountered problem with notice resource. After calling paginate method on Notice i'm receiving error

2.3.1 :001 > Honeybadger::Api::Notice.paginate(XXXX, XXXX)
NoMethodError: undefined method `[]' for nil:NilClass
    from gems/honeybadger-api-2.0.0/lib/honeybadger-api/deploy.rb:14:in `initialize'
    from gems/honeybadger-api-2.0.0/lib/honeybadger-api/notice.rb:22:in `new'
    from gems/honeybadger-api-2.0.0/lib/honeybadger-api/notice.rb:22:in `initialize'
    from gems/honeybadger-api-2.0.0/lib/honeybadger-api/notice.rb:42:in `new'
    from gems/honeybadger-api-2.0.0/lib/honeybadger-api/notice.rb:42:in `block in handler'
    from gems/honeybadger-api-2.0.0/lib/honeybadger-api/paginator.rb:22:in `block in initialize'
    from gems/honeybadger-api-2.0.0/lib/honeybadger-api/paginator.rb:21:in `map'
    from gems/honeybadger-api-2.0.0/lib/honeybadger-api/paginator.rb:21:in `initialize'
    from gems/honeybadger-api-2.0.0/lib/honeybadger-api/request.rb:40:in `new'
    from gems/honeybadger-api-2.0.0/lib/honeybadger-api/request.rb:40:in `paginate'
    from gems/honeybadger-api-2.0.0/lib/honeybadger-api/request.rb:36:in `paginate'
    from gems/honeybadger-api-2.0.0/lib/honeybadger-api/notice.rb:37:in `paginate'
    from (irb):1

From what i see, Notice resource is now using Deploy resource. Why Deploy is
obligatory now ?

EDIT 1
I think empty deploy key in response is causing that problem

http://docs.honeybadger.io/guides/api.html#site-list-site-details

Since the gem was written several of the Read API endpoints now support URL parameter filters and ordering:

• Fault
• Notice
• Deploy
• Metrics

See Read API docs for details.

Support for these filters and ordering parameters should be in the gem

http://docs.honeybadger.io/guides/api.html#site-outage-list

Under Ruby 2.1.8 the gem raises an unintialized constant exception:

NameError: uninitialized constant Honeybadger::Api::Client::OpenSSL
from /Users/murray/.gem/ruby/2.1.8/gems/honeybadger-api-1.0.0/lib/honeybadger-api/client.rb:26:in `request'

Within Honeybadger::Api::Client there is a missing require "openssl":

https://github.com/murraysum/honeybadger-api/blob/master/lib/honeybadger-api/client.rb#L26

• RSpec has changed the color_enabled configuration option.
• RSpec has also replaced be_true with be_truthy and be_false with be_falsey.

Issue

Within https://github.com/murraysum/honeybadger-api/blob/master/lib/honeybadger-api/client.rb#L27 we do not verify ssl certs. Instead we use OpenSSL::SSL::VERIFY_NONE which defeats the point of SSL. 😨

We should be using the OpenSSL::SSL::VERIFY_PEER mode.

Read more here: http://mislav.net/2013/07/ruby-openssl/

Expected Behaviour

SSL certs are verified

Actual Behaviour

SSL certs are not verified

There is a missing github_project attribute coming from the API response but not on the Project class

http://docs.honeybadger.io/guides/api.html#metrics

http://docs.honeybadger.io/guides/api.html#rate-limiting

http://docs.honeybadger.io/guides/api.html#site-uptime-check-list