mybbgroup / thank-you-like-system Goto Github PK

Some users on my forum accidentally discovered a race condition which allows someone to like a post multiple times - there is a millisecond (or so) long window between checking for an existing like and inserting the like. Under the right conditions (The first few times it happened it was accidental) or with a flood of requests a post can end up with two likes from one user.

The solution was to change the index on (pid, uid) to a unique key as opposed to just a plain ol' index.

Fix and more info are here:
http://community.mybb.com/thread-59652-post-1073519.html#pid1073519

List of users stays hidden after you remove and add a thank/like even you set show collapsed in setting

How to reproduce:

• enable thanks/like removing
• enable list collapsive
• set default collapsive state to: "List shown"

Everything works fine until you add and then without refreshing remove your thank/like from a post and add again thank/like for a same post.

I am not good in JS so I dont know how to fix that :(

Bullet is added for classic_postbit, not for postbit

Possible SQL injection in lang file - html link in lang file

Add Czech translation

Hi, I have a forum at popfn.com

For some reason, it has never worked with MyAlerts. Do you know if there is an issue?

Add how many likes/thanks can a specific usergroup give per XX time.

For example for registered users 10 likes per 24 hours etc.

• amount of likes/thanks can be changed
• time period should be in hours

Add an url link for images in buttons + add icons

I think this is better. Show first thanks/likes received and then thanks/like given in postbit template

@WhiteNeo - with latest mod version (GitHub release) there is a problem during activation

Add info how to uninstall + add uninstall file into plugin

Plugin description - broken links for authors/sources
@SvePu - it is a regression from your last update in lang file - can you please fix?

Show date and time on a mouse hover for nicknames.

http://community.mybb.com/thread-59652-post-1128322.html#pid1128322

I would like to create a simple project webpages with info about releases, changes, template changes and FAQ. It will be ready in 2 weeks.

Better styling for a list of users who added thank/like under the post

Maybe custom .css for thankyoulike would be better than add this into global.css

@WhiteNeo

When you install and activate thnak you/like plugin no alert type is added into myalerts setting :(

Some users reported that after instalation and activation there is no list under the post of users who thanked/liked for this post.

@SvePu @Evenprime - can you confirm this? I cannot

No big deal but it could bring faster loading speeds of websites. I would like to see a setting for this: use minified version of JS? Yes/No

Add a secure interval which could block fast adding/removing thanks/like to the post.

For example 10-15 seconds

link: http://community.mybb.com/thread-169382-post-1160848.html#pid1160848

As @euan wrote in this post (http://community.mybb.com/thread-169382-post-1161017.html#pid1161017 ), we just need to adjust lang file and users have to use latest MyAlerts version (2.0.1 and higher).

What about to add click to select forums where to disable thank you/like system? It would be better than write numbers.

@SvePu

http://community.mybb.com/thread-59652-post-1106106.html#pid1106106

Change a description line in a plugin file

• add links
• change version number

What about to add more language support?

@SvePu - German
@WhiteNeo - Spanish? I am not sure what is your native laguage
@CU8ER - Czech

Just a minor thing, we should use tyl_add/tyl_del instead of thx_add and thx_del for icon paths. I will change it ASAP.

Make post author´s username shown (under the list of users who put thank/like for a post) clickable + get group style from MyBB setting (same like for list of users under the post).

Some parts of code in templates are not deleted during uninstall

for example code in post bit template in your theme

see: #2

• post bit template:
  -- postbit
  -- postbit_author_user
  -- postbit_classic

@WhiteNeo

I just test it locally and I think there must be a problem with latest changes in JS file

What about to make Like/Thank you for buttons in post bit?

EDIT: just use strong and /strong to make the text bold

Check if %%TYL_NUMTHANKEDLIKED%% is added automatically into postbin after instalation

Just everything in one issue, is it possible? What do you think

• use same style like MyBB popup notifications
• turn on/off
• is possible to have a lang var for "CLOSE ALL"?
• anything else?

@WhiteNeo

Thank you/like button is shown for unregistered/unlogged users... it should be hidden, am I right?

What about German translation @SvePu - can you add it for frontend? Admin part should stay in English.

MyAlerts v2 supports custom modules. It would be nice to integrate alerts for Thankyou/like plugin in future.

Delete unused button images. In MyBB 1.8 there are only css buttons

Currently there exists a problem with IPv6 users in MyBB 1.8.x, where they can't use the four quick search links in another users profile (liked threads, liked posts, posts with likes, threads with likes). A MySQL error is thrown because the value for the ipaddress field is too long.

The problem is in "tylsearch.php":
"ipaddress" => $db->escape_string($session->ipaddress),
has to be replaced with
"ipaddress" => $db->escape_binary($session->packedip),

for the inserts into the 'searchlog' table.

• dotted border-top for postbit_classic
• bold font weight for text in thank you/like button
• move list od users to the end of postbit for classic_postbit
• make dotted border top for user list in postbit
• add no-repeat for images in buttons (just to be sure)

@WhiteNeo

Remove unnecessary code from postbit and postbit_classic
http://community.mybb.com/thread-59652-post-1109789.html#pid1109789

Better styling for a collapse button in a list od users

http://community.mybb.com/thread-59652-post-1125259.html#pid1125259

It would be better to use a dotted line - same style like under avatar picture on the left

code for this change:
{
border-top: 1px dotted #ccc;
color: #ffffff;
height: 1px;
width: 100%;
margin-left: auto;
margin-right: auto;
}

Also the list with thanks/like is too high - its height shoul be smaller - padding between title and users should be smaller

Small improvement for list of users whose added thanks/like

There should be a setting for this - classic list under the post or this one

http://community.mybb.com/thread-59652-post-1150146.html#pid1150146

Correct small typos in lang file - admin part

Do you have any ideas or plans what to add into next version? I think it looks fine, I will test latest changes tommorow.

Feel free to open a new issue with your idea/bug/PR :)

Thank you/like info is not placed correctly - it should be above the total time spend online

@SvePu - please, could you check latest merge? I solved merge conflicts. It should be OK, I checked it twice and it looks fine but if you have some time please check it again and tell me :)

@WhiteNeo - new bug has been found. It is related only to thankyou/like plugin. Every other plugin with myalerts support shows apostrophes correctly.

Here is a conversion script for migrating from Thank you/like system into Simple Like system. Can we revert this easily?

https://github.com/euantor/SimpleLikes/archive/current.zip

Allow adding like/thank in closed threads for normal users. Now only moderators/administrators can do that... New setting should be added instead of hard coded value

http://community.mybb.com/thread-59652-post-1128203.html#pid1128203

Add option to plugin tab to enable (reenable) alerts for myalerts

(register thankyoulike alerts to myalerts without uninstall/install process)

This is doable in DVZ mentions for example