MyBB 1.8.28+ incompatibility - member profile - post meesage is parsed incorrectly about thank-you-like-system HOT 10 CLOSED

I doubt that this issue has anything to do with MyBB core or core version, but perhaps I'm mistaken. It seems to be caused by the "Trophy post character cut-off" setting being set to a value other than zero, such that for this particular trophy post, the closing tags for [size] and [font] are cut off, meaning that the parser then renders the opening tags as-is, since it can't parse them.

The fix would probably best be handled - if at all - in core, rather than in this plugin: a sort of "auto-insert any missing closing MyCode tags prior to rendering" feature. That's probably not such an easy feature to implement though.

from thank-you-like-system.

OK, thank you for your feedback!

from thank-you-like-system.

So this is a mybb core related?

from thank-you-like-system.

It's a general problem that if we cut off closing tags, the parser doesn't render the message as if those closing tags were there - instead, it renders the opening tags as plain text. We could try to fix this ourselves, but better would be a solution in core which would reusable for others. Perhaps an alternative solution is rendering the message to plain text rather than to HTML. IIRC, that's how message fragments are rendered in search results.

from thank-you-like-system.

Maybe disallowing parser option mycode by default and parsing the message before cutting.

from thank-you-like-system.

@SvePu this idea is good, we can just display text, we do not need any formating of text here. It is just a part of text. Could you please make a PR?

from thank-you-like-system.

@Eldenroot Please check the modification fbe254f

from thank-you-like-system.

@SvePu - I would like to, but if I update to the latest version I will have to redo all my template modifications - see #302

I am going to install a test board for this, need some time.

Thank you!

from thank-you-like-system.

@Eldenroot for testing you dont need to reinstall ... just replace plugin files on server.

from thank-you-like-system.

Closing as complete.

from thank-you-like-system.