{day}:today won't be translated about skill-weather HOT 6 OPEN

Found a place where "today" was hardcoded, See PR #136, It's not the rework Gez is intending to do but it should fix this particular issue.

from skill-weather.

Thanks Ake!

I'm thinking the rework will go straight to the 20.08 branch so we can split the Skill up into submodules, so great to have this fix available for 20.02.

from skill-weather.

Hi emphasize, thanks for reporting these, I want to clean this Skill up a bit so will take a look at this shortly.

from skill-weather.

@krisgesling

Most likely found the source. If this is coded like skill-reminder you've used some date_str(time) method to change the {day} output of timely events to 'today'/'tommorow'.

Since i'm working on the reminder skill (and face the similar problem), how is this translated seperately?

from skill-weather.

In the reminder skill it seems like the hard coded "today", "tomorrow" should be replaced with self.translate() calls and a today.dialog and tomorrow.dialog files should be created.

In this skill from a brief look at it the nice_date is called with the lang code so lingua franca should translate that...

Can you give me an example utterance for which you get this issue and I can dig some more in the morning?

from skill-weather.

Sorry for confusing the two.

I made a check and in this skill (skill-weather) it only affects 'today', which isn't translated.
"wird heute schönes wetter sein" -> today instead of "heute".

(translation: will the weather be fine today)

But thanks on the hint towards self.translate()

But most valueable is that nice_date() is (or should be) capable of formatting timely events to today/tommorow (+ lingua franca) which would make the whole shabang here and here irrelevant (the three dialogs SavingReminder* can be merged into one) I don't want to drag old code as i flesh out untimed reminder. (even if this only relates to timed reminders)

from skill-weather.