hs-findbugs

红松代码检查器

南京红松研发中心代码检查工具.

项目主页:http://mycsoft.github.io/hs-findbugs

hs-findbugs's People

Contributors

Stargazers

Watchers

hs-findbugs's Issues

BuesinessException是正确的异常抛出方式

检查dao被错误调用的问题.

Dao必须在Service层之后调用.

More Loop查询结果不一定是循环嵌套.

有些结果发现在多个if语句之后.

检查异常嵌套时出错.

try (InputStream in = CommonsConstants.class.getResourceAsStream("/constants.properties")) {
            props.load(in);
} catch (IOException e) {
            logger.error("初始化环境变量异常", e);
            throw new RuntimeException("Hs System init failed!", e);
}

这里仍然会示为错误.

在Hudson中不显示错误说明.

在Hudson 的findbugs插件中都显示为下面这个样子:

AttachController.java:84, HS_EXCEPTION_PRINT, Priority: Normal
No description available.
No description available.

While中异常处理检查错误

    public static String emojiConvert(String str) {
        String patternString = "([\\x{10000}-\\x{10ffff}\ud800-\udfff])";

        Pattern pattern = Pattern.compile(patternString);
        Matcher matcher = pattern.matcher(str);
        StringBuffer sb = new StringBuffer();
        while (matcher.find()) {
            try {
                matcher.appendReplacement(
                        sb,
                        "[["
                        + URLEncoder.encode(matcher.group(1),
                                "UTF-8") + "]]");
            } catch (UnsupportedEncodingException e) {
                logger.error("emojiConvert error", e);
                throw new RuntimeException("emojiConvert error", e);
            }
        }
        matcher.appendTail(sb);
        logger.debug("emojiConvert " + str + " to " + sb.toString()
                + ", len：" + sb.length());
        return sb.toString();
    }

Recommend Projects