Giter VIP home page Giter VIP logo

jeeves's People

Contributors

alexgog78 avatar luckyraul avatar mavlyan avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar

jeeves's Issues

Admin page sample_module/customeraddress 404

Precond:

  • Run generated code under Magento 2.2.
  • Click on CustomerAddress grid in menu (in Stores by default)
Expected:

CustomerAddress grid is available

Actual:

CustomerAddress grid is unavailable (404).

It happens because of lishnee podcherkivanie in app/code/Mygento/SampleModule/etc/adminhtml/menu.xml action="sample_module/customer_address" . Underscore separates folders! Camelcased entities should be without underscore!

Correct version:

<?php
action="sample_module/customeraddress"

And consequently - Underscore should be removed from layout filenames.
A takzhe vot zdes ubrat underscore:

    <settings>
        <submitUrl path="sample_module/customer_address/save"/>
    </settings>

Using Twig Templates

I think it's better to use Twig templating based generator.
This way, you can leverage the whole file with just a dynamic placeholder.

Add support PHP 7.2 version

There is used old library for code generating https://github.com/memio/memio. Latest update 2 years ago.
It causes following error:
PHP Fatal error: Cannot use Memio\Model\Object as Object because 'Object' is a special class name in phar:///usr/local/bin/jeeves/src/Jeeves/Console/Command/PaymentGateway.php on line 12

phpstan level 5

  Line   app/code/MostWanted/BulkOffer/Controller/Adminhtml/Lead/Delete.php                                                                               
 ------ ------------------------------------------------------------------------------------------------------------------------------------------------- 
  21     Parameter #1 $message of method Magento\Framework\Message\ManagerInterface::addErrorMessage() expects string, Magento\Framework\Phrase given.    
  28     Parameter #1 $message of method Magento\Framework\Message\ManagerInterface::addSuccessMessage() expects string, Magento\Framework\Phrase given.  
 ------ ------------------------------------------------------------------------------------------------------------------------------------------------- 

 ------ ----------------------------------------------------------------------------------------------------------------------------------------------- 
  Line   app/code/MostWanted/BulkOffer/Controller/Adminhtml/Lead/Edit.php                                                                               
 ------ ----------------------------------------------------------------------------------------------------------------------------------------------- 
  45     Parameter #1 $message of method Magento\Framework\Message\ManagerInterface::addErrorMessage() expects string, Magento\Framework\Phrase given.  
  58     Parameter #1 $label of method Magento\Backend\Model\View\Result\Page::addBreadcrumb() expects string, Magento\Framework\Phrase given.          
  59     Parameter #2 $title of method Magento\Backend\Model\View\Result\Page::addBreadcrumb() expects string, Magento\Framework\Phrase given.          
  61     Parameter #1 $prefix of method Magento\Framework\View\Page\Title::prepend() expects string, Magento\Framework\Phrase given.                    
 ------ ----------------------------------------------------------------------------------------------------------------------------------------------- 

 ------ ----------------------------------------------------------------------------------------------------------------------------- 
  Line   app/code/MostWanted/BulkOffer/Controller/Adminhtml/Lead/Index.php                                                            
 ------ ----------------------------------------------------------------------------------------------------------------------------- 
  43     Parameter #1 $prefix of method Magento\Framework\View\Page\Title::prepend() expects string, Magento\Framework\Phrase given.  
 ------ ----------------------------------------------------------------------------------------------------------------------------- 

 ------ ------------------------------------------------------------------------------------- 
  Line   app/code/MostWanted/BulkOffer/Controller/Adminhtml/Lead/InlineEdit.php               
 ------ ------------------------------------------------------------------------------------- 
  51     Call to an undefined method MostWanted\BulkOffer\Api\Data\LeadInterface::getData().  
  51     Call to an undefined method MostWanted\BulkOffer\Api\Data\LeadInterface::setData().  
 ------ ------------------------------------------------------------------------------------- 

 ------ ------------------------------------------------------------------------------------------------------------------------------------------------- 
  Line   app/code/MostWanted/BulkOffer/Controller/Adminhtml/Lead/MassDelete.php                                                                           
 ------ ------------------------------------------------------------------------------------------------------------------------------------------------- 
  45     Parameter #1 $message of method Magento\Framework\Message\ManagerInterface::addSuccessMessage() expects string, Magento\Framework\Phrase given.  
 ------ ------------------------------------------------------------------------------------------------------------------------------------------------- 

 ------ ---------------------------------------------------------------------------------------------------------------------------------------------------------------- 
  Line   app/code/MostWanted/BulkOffer/Controller/Adminhtml/Lead/Save.php                                                                                                
 ------ ---------------------------------------------------------------------------------------------------------------------------------------------------------------- 
  45     Call to an undefined method Magento\Framework\App\RequestInterface::getPostValue().                                                                             
  55     Right side of && is always true.                                                                                                                                
  58     Parameter #1 $message of method Magento\Framework\Message\ManagerInterface::addErrorMessage() expects string, Magento\Framework\Phrase given.                   
  71     Parameter #1 $message of method Magento\Framework\Message\ManagerInterface::addSuccessMessage() expects string, Magento\Framework\Phrase given.                 
  81     Parameter #2 $alternativeText of method Magento\Framework\Message\ManagerInterface::addExceptionMessage() expects string|null, Magento\Framework\Phrase given.  
 ------ ---------------------------------------------------------------------------------------------------------------------------------------------------------------- 

 ------ ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 
  Line   app/code/MostWanted/BulkOffer/Model/LeadRepository.php                                                                                                                                                     
 ------ ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 
  66     Parameter #1 $object of method Magento\Framework\Model\ResourceModel\Db\AbstractDb::save() expects Magento\Framework\Model\AbstractModel, MostWanted\BulkOffer\Api\Data\LeadInterface given.               
  83     Parameter #1 $object of method Magento\Framework\Model\ResourceModel\Db\AbstractDb::delete() expects Magento\Framework\Model\AbstractModel, MostWanted\BulkOffer\Api\Data\LeadInterface given.             
  112    Parameter #1 $items of method MostWanted\BulkOffer\Api\Data\LeadSearchResultsInterface::setItems() expects array<MostWanted\BulkOffer\Api\Data\LeadInterface>, array<Magento\Framework\DataObject> given.  
 ------ ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 

 ------ --------------------------------------------------------------------- 
  Line   app/code/MostWanted/BulkOffer/Ui/Component/Listing/LeadActions.php   
 ------ --------------------------------------------------------------------- 
         Class Mygento\Base\Ui\Component\Listing\Actions not found.           
         ๐Ÿ’ก Learn more at https://phpstan.org/user-guide/discovering-symbols  
 ------ --------------------------------------------------------------------- 

 [ERROR] Found 19 errors                                                     

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.