myparcelnl / delivery-options Goto Github PK

Wanneer je op dit moment zondag als afleverdag instelt wordt er niets mee gedaan. kan dit ervoor zorgen dat in de checkout maandag als leverdag te zien is?

Using plugin 4.1.4 on Magento 2.3.6

I would like the plugin to make it optional to show the map for pickup points. Reason for this is that the Belgium pickup points are not showing on the map, it only confuses customers. So a simple option to show only list, map, or both would suffice.

What problem does this feature solve?

We need this feature to show this newly implemented carrier from the API.

What should the solution look like?

Add the Carrier DHL Parcel Connect with carrier_id 11 to the CarrierConfiguration

Relevant log output

No response

Additional context

No response

Describe the solution you'd like
The customer should see the base price of either option before selecting them.

For example: If there is a discount for using pickup locations customers don't know this until they actually select a pickup location. If they could see there is a discount they will be more tempted to select pickup instead of delivery.

Additional context
Example of what it could look like:

Describe the bug
Leaflet throws an error and breaks when the centerpoint address is incorrect.

myparcel.js?ver=4.1.4:7 Error: Bounds are not valid.
    at i.fitBounds (leaflet.js:formatted:1436)
    at a.fitToMarkers (myparcel.js?ver=4.1.4:7)
    at a.<anonymous> (myparcel.js?ver=4.1.4:7)
    at Array.<anonymous> (myparcel.js?ver=4.1.4:7)
    at ut (myparcel.js?ver=4.1.4:7)

Configuration

{
  "config": {
    "platform": "belgie",
    "locale": "nl-BE",
    "currency": "EUR",
    "carrierSettings": {
      "bpost": {
        "allowDeliveryOptions": true,
        "allowPickupLocations": true,
        "largeFormat": false,
        "allowSignature": false,
        "allowOnlyRecipient": false,
        "cutoffTime": "14:00",
        "deliveryDaysWindow": 1,
        "dropOffDays": [
          "1",
          "2",
          "3",
          "4",
          "5",
          "6"
        ],
        "dropOffDelay": 1,
        "pricePickup": -2,
        "priceSignature": 1,
        "priceOnlyRecipient": 0,
        "priceSaturdayDelivery": 0
      },
      "dpd": {
        "allowDeliveryOptions": true,
        "allowPickupLocations": true,
        "largeFormat": false,
        "allowSignature": false,
        "allowOnlyRecipient": false,
        "cutoffTime": "17:00",
        "deliveryDaysWindow": 1,
        "dropOffDays": [
          "1",
          "2",
          "3",
          "4",
          "5"
        ],
        "dropOffDelay": 0,
        "pricePickup": -2.5,
        "priceSignature": 0,
        "priceOnlyRecipient": 0,
        "priceSaturdayDelivery": 0
      },
      "postnl": {
        "allowDeliveryOptions": true,
        "allowPickupLocations": true,
        "largeFormat": false,
        "allowSignature": true,
        "allowOnlyRecipient": false,
        "cutoffTime": "17:00",
        "deliveryDaysWindow": 1,
        "dropOffDays": [
          "1",
          "2",
          "3",
          "4",
          "5"
        ],
        "dropOffDelay": 0,
        "pricePickup": -2,
        "priceSignature": 0,
        "priceOnlyRecipient": 0,
        "priceSaturdayDelivery": 0
      }
    }
  },
  "strings": {
    "addressNotFound": "Adresgegevens zijn niet ingevuld",
    "city": "Plaats",
    "closed": "Gesloten",
    "deliveryStandardTitle": "Standaard levering",
    "deliveryTitle": "Thuis of op het werk bezorgd",
    "headerDeliveryOptions": "Bezorgopties",
    "houseNumber": "Huisnummer",
    "openingHours": "Openingstijden",
    "pickUpFrom": "Ophalen vanaf",
    "pickupTitle": "Afhalen ophaalpunt",
    "postcode": "Postcode",
    "retry": "Opnieuw",
    "wrongHouseNumberCity": "Postcode/plaats combinatie onbekend",
    "signatureTitle": "Handtekening voor ontvangst ",
    "onlyRecipientTitle": "Alleen ontvanger",
    "pickupLocationsListButton": "Lijstweergave",
    "pickupLocationsMapButton": "Kaartweergave"
  },
  "address": {
    "cc": "de",
    "postalCode": "200",
    "number": "200",
    "city": "Hamburg"
  }
}

Expected behavior
Map doesn't show and asks to correct the address.

Screenshots

Hardware

• OS: MacOS 10.15.4
• Browser: Chrome 85.0.4183.121

Describe the bug
When I try to select a location of my preference in the checkout using "List" tab (new design in version 4.x.x) it is not clear to me 1) if I selected a location and 2) what location. The background is white, there is no difference to see between the selected location and the other alternatives. This is not clear to the customer and will lead to confusion

To Reproduce
Steps to reproduce the behavior:

1. Go to checkout
2. shipping section
3. select the option for
4. use the list view and try to select a location of your preference

Expected behavior
Design that shows a clear difference in f.i. color or a text that says selected or something similar.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: iOS mac
• Browser Chrome and Safari
• MyParcel Plugin version 4.1.1
• MyParcel SDK version 5.1.0
  also using latest Mageplaza OSC 2.9.5
  Magento version 2.3.5-p1

Additional context
Add any other context about the problem here.

Is your feature request related to a problem? Please describe.
There are multiple pickup points with the same name in my area which will be displayed at the top of the pick up list.

Describe the solution you'd like
Showing the street of the pickup point

Locatie lijst begint niet met dichtstbijzijnde afhaal locatie.

Customers think the shippingcosts are free, but when +€0,00 or just a blank space is used, there will be less confusion.

What problem does this feature solve?

We need this feature to show this newly implemented carrier from the API.

What should the solution look like?

Add the Carrier DHL Parcel Connect with carrier_id 10 to the CarrierConfiguration.

Relevant log output

No response

Additional context

No response

Describe the bug
Standard delivery sometimes shows AFTER morning and evening delivery

Configuration

{
  "config": {
    "carriers": [],
    "platform": "myparcel",
    "locale": "nl-NL",
    "currency": "EUR"
  },
  "strings": {
    "addressNotFound": "Address details are not entered",
    "city": "City",
    "closed": "Closed",
    "deliveryStandardTitle": "Standard delivery",
    "deliveryTitle": "Delivered at home or at work",
    "deliveryMorningTitle": "Morning delivery",
    "deliveryEveningTitle": "Evening delivery",
    "headerDeliveryOptions": "",
    "houseNumber": "House number",
    "openingHours": "Opening hours",
    "pickUpFrom": "Pick up from",
    "pickupTitle": "Pickup",
    "postcode": "Postcode",
    "retry": "Retry",
    "wrongHouseNumberCity": "Postcode/city combination unknown",
    "signatureTitle": "Signature on delivery",
    "onlyRecipientTitle": "Home address only"
  },
  "address": {
    "cc": "nl",
    "postalCode": "1025 WK",
    "number": "576",
    "city": "Amsterdam"
  }
}

Expected behavior
Standard delivery is between morning and evening delivery.

Screenshots

Hardware

• OS: MacOS 10.15.4
• Browser Chrome 85.0.4183.102

I want to be able to reorganize the delivery options so I can choose what the client sees first.

Is your feature request related to a problem? Please describe.
If the customer decides to adjust his delivery options after the data was sent and he left the page, going back will require him to fill in the information from nothing. I could not find a option to pre-fill the delivery options on render or update events.

Describe the solution you'd like
Add "delivery_options" to window.MyParcelConfig with the structure of the contents of #mypa-input that will allow customers to edit what they picked previously.

If I missed some configuration that can make this happen, please let me know. Thank you.

Is your feature request related to a problem? Please describe.
When there are no pickup locations it doesn't handle this correctly. It just errors and hides while at home delivery may still be possible.

Describe the solution you'd like
When this occurs, keep showing the module but show a message along the lines of "No pickup locations found."

Additional context
Relates to myparcelnl/woocommerce#377

Is your feature request related to a problem? Please describe.
You're able to enter anything in configuration properties, this can easily cause unexpected behaviour which can be hard to debug.

Describe the solution you'd like
Validate the configuration on load and report warnings if types are invalid, unsupported options are passed, etc.

When using a faulty address on purpose. And selecting 'pick up from location' the error message pop's up that their has no address has been filled in.

There has. But the supplied address doesn't exist. For more info see attached image.

Additional context
Add any other context about the problem here.

Describe the bug
Date selector pick list in checkout is displaying "Invalid date" as title for each day to select

To Reproduce
Steps to reproduce the behavior:

1. Put products in basket
2. Go to checkout
3. Go to shipping section
4. When trying to select a delivery day, the pick list shows "invalid date" for all values
   Strangely it only happens with iOS/Mac devices

Expected behavior
Show dates instead of "invalid date" text

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: iOS and Mac
• Browser: Safari
• MyParcel Plugin version: 4.1.1
• MyParcel SDK version: 5.1.0

Please make the list/map view when choosing a pickup location more configurable. Let the shopowner choose what to show and what should have priority.

Reasons:

• Not every store wants to show the map
• The map doesn't work correctly (bug filed)
• As a shopowner I want to be able to choose the listview as default; there the shipment costs are displayed rightaway, not after you've clicked a location

Using MyParcel 4.1.6-beta.1 and Magento 2.3.5 together with Firecheckout.

We have a sticky horizontal menu in the header.
When we select an address the deliveryoptions show up.
Select pickup location, witness the pickup list expanding, select more options.
Now scroll down to the bottom of the site and witness the stickymenu going awry.

Reason for this is that the angular box isn't adding up to the document size. I tried to observe it with ResizeObserver, but that doesn't play nice with Angular.

I now circumvented it in a different way, but it would be nice for the document to know how high the deliveryoptions container is so that sticky elements remain working.

Het is mogelijk dat sommige dagen een andere sluitingstijd hebben. Kan het zo gemaakt worden dat je per dag kan instellen wanneer je sluit, zodat de checkout hier goed op ingesteld kan worden?

Graag de mogelijkheid om de mogelijkheid voor het kiezen van afhaalpunten voor België en Nederland apart aan of uit te zetten. Dit was tijdens het begin van de Corona-perikelen een probleem, omdat België al de pakketpunten had gesloten en Nederland niet.

Als een klant wil ik de volgorde van de verzendmethoden in de checkout (standaard / ochtend / avond) willen aanpassen.
Nu is de volgorde:

• Ochtend
• Avond
• Standaard

Als ik dit zelf kan wijzigen, kan iedereen zelf bepalen wat het best voor hem/haar werkt.

It's currently not possible to use the event myparcel_update_config to change the carriers on the fly. You'll end up only being able to select the first available carrier. It's possible that this event triggers more bugs, if you run into any please report them here so we can test these as well.

Workaround

A workaround for now is to do a rerender, by essentially deleting the whole html structure of the delivery options, placing a new empty div with the id myparcel-delivery-options, and sending an event to myparcel_render_delivery_options.

Example

const oldElement = document.querySelector('.myparcel-delivery-options');
oldElement.outerHTML = '<div id="myparcel-delivery-options"></div>';
​
document.dispatchEvent(new Event('myparcel_render_delivery_options'));

Note

By @gett-thijssimonis

The event myparcel_update_config also requires that config param currency is present instead of using default from defaultConfiguration.

Error

TypeError: Currency code is required with currency style.

Describe the bug
When I use an address with no pickup points nearby the map shows nothing but a blank map. Because of this you have to zoom out until there are any pickup points to be showed.

Steps to reproduce

1. Go to 'the checkout'
2. Use postal code 9982BL with house number 2
3. Click on 'pick up'
4. See no pickup points on the map

Expected behavior
The map should zoom out until a few pickup points are visible.

Currently the list view only mentions the location name but not the streetname. Especially when there are multiple retail locations with the same brand name mentioned in the list, this becomes confusing.

Solution: Add a streetnaam+housenumber below the retail location name in the list view.

Describe the bug
When selecting a new location, the default location will not appear "unselected". This way the user can't see which one is the "real" selected location.

Configuration
Default configuration on https://myparcelnl.github.io/delivery-options/

Steps to reproduce

1. Go to pickup map
2. Click on an unselected location
3. Original location is not deselected.

Expected behavior
Original location is deselected.

Screenshots

Hardware

• OS: MacOS 10.15.4
• Browser: Chrome 85.0.4183.121

What went wrong?

Users can fill in letters in the field 'house number' in the retry form

Reproduction steps

1. Fill in an invalid address with allowRetry: true
2. Click on the house number field
3. Start typing letters

With a clean install. With all the latest versions of WP, WOO and Myparcel (on 7-12-20) it seems that pickup locations are excluded or not loaded on the map for Belgium.
When moving in the map the icon of the locations are visible, but only in The Netherlands.

The list without map works.

Is your feature request related to a problem? Please describe.
The buttons 'Lijst' and 'Kaart' don't have an active state for styling them.

Describe the solution you'd like
A class to be applied to the buttons when they're active.

From myparcelnl/woocommerce#611

Pickup point locations are not correctly sorted.

3,5 Km comes before 325 meter

Please see the below example:

• MyParcel Plugin version 4.1.1

Graag zou ik de sluitingstijden per dag in willen stellen. Ik heb nu doordeweeks een cut-off tijd van 23:00 uur en op Zondag een cut-off-tijd van 18:00 uur.
Daarnaast als ik dan een cut-off tijd op Zondag instel moet de afleverdag op Maandag worden vermeld en niet op Dinsdag zoals nu het geval is.)
(Alle bestellingen van vrijdag 23:00 uur tot zondag 18:00 uur worden op maandag bezorgd...)

Describe the bug
The delivery options radio button is disabled, but selected, when only one MyParcel option is set. If the user has any other delivery methods besides MyParcel, MyParcel options will always be selected.

Expected behavior
Unselect MyParcel shipping method when another delivery method is available.

Screenshots

Describe the solution you'd like
The delivery options endpoint now supports sending street instead of number. This should be supported so frontends don't have to split numbers from full street addresses if they don't use separate address fields.

Is your feature request related to a problem? Please describe.
Right now, only a generic message will be shown when the API returns an error.
Describe the solution you'd like
It would be good to show what exactly went wrong, for example when an invalid address was entered.
Describe alternatives you've considered
.
Additional context

Describe the bug
When package type is not "package", pickup locations aren't automatically turned off, forcing anyone implementing the delivery options to write this logic themselves.

Configuration

{
  "config": {
    "packageType": "digital_stamp",
    "platform": "myparcel",
    "carrierSettings": {
      "postnl": {
        "allowStandardDelivery": true,
        "allowPickupLocations": true,
        "allowEveningDelivery": false,
        "allowMondayDelivery": false,
        "allowMorningDelivery": false,
        "allowOnlyRecipient": false,
        "allowSaturdayDelivery": false,
        "allowSignature": false
      }
    }
  }
}

Steps to reproduce

1. Load delivery options with above config
2. See pickup option

Expected behavior
No pickup option to be available.

In version 4.1.1 the shown map has a green dot in the center, most likely based on the entered location (I'd expect). However, it doesn't match that location (checked with 5 postcodes/addresses) - in one case I came in a totally different village.

However the list of nearby locations is correct.