Giter VIP home page Giter VIP logo

foss-weekend-meals-from-around-the-world's Introduction

FOSS Weekend Meals From Around The World

About

This project is a minimalistic website for searching recipes by country, made using vanilla JavaScript and theMealDB api, to practice ajax fetching and making modals.

Local Setup

  • After forking and cloning this repository to your local machine, open the project folder in your favourite code editor.
  • Assuming you already have the "Live Server" extension installed (if not, then install it right now, it is very useful for any simple html css js project!), open index.html with Live Server.
  • Any changes you make in the code will be reflected in the browser immediately

foss-weekend-meals-from-around-the-world's People

Contributors

n-shar-ma avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar

foss-weekend-meals-from-around-the-world's Issues

Properly communicate any error to the user

Currently, when any error occurs when fetching data from the api service, the user only sees a perpetual "loading" screen, while the error message is printed in the console. While this is okay for debugging during development, conveying any error messages clearly to the user is a very important aspect of any website.

Using the showModal function (that is also used to show details about a recipe) show the error message to the user in a modal. There is some scope for creativity here, so feel free to think about what should the ideal color for an error message be, what the title and content should be, etc. Make sure normal functioning of the website resumes after the error message has been dismissed by the user.

Attach a gif of what happens when an error occurs (you can try to force an error by simply typing gibberish into the input box)

Visual changes are much easier for PR reviewers when the contributor adds screenshots / gifs, as appropriate, which show the change at a cursory glance, so make this a habit!

Give credit to API service

In the open source world, it's very easy to take all the free services you get for granted, but we should always give credit where it's due, even if just via a shout out / mention.

For this website, we are using the free theMealDB API. Add a footer at the bottom of the page thanking the service and link to their website. The exact wording of the content of the footer is upto you, as is the styling. Express gratitude however you'd like to! Just remember that this is a footer and not the central focus of the page, so don't over style it and keep it simple, yet easily visible.

Attach a screenshot showing the new footer.

Visual changes are much easier for PR reviewers when the contributor adds screenshots / gifs, as appropriate, which show the change at a cursory glance, so make this a habit!

Remove the mysterious extra space after ingredients

For dishes with less ingredients, there is a lot of extra space visible before the instructions. The amount of this space seems to be inversely proportional to the number of ingredients. Investigate what is causing so many blank lines and fix the UI so that there are no unpredictable blank lines after the list of ingredients.

Hint: Investigate the data being returned by the API

Attach 2 screenshots, one for before and for after, showing how you have fixed this UI bug. Feel free to elaborate in writing how you figured out what exactly was wrong, since finding the root cause of a bug is as important as fixing it.

Visual changes are much easier for PR reviewers when the contributor adds screenshots / gifs, as appropriate, which show the change at a cursory glance, so make this a habit!

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.