n37r06u3 / django-cart Goto Github PK

What steps will reproduce the problem?
cart_manager = CartManager(request)
cart_manager.add(someitem)
item_manager = ItemManager()
item_manager.get(product=someitem)

What is the expected output? What do you see instead?
I would expect to have the item returned, instead I get:
'NoneType' object has no attribute '_meta'
which is traced back to this line of code:
return super(ItemManager, self).get(*args, **kwargs) 

I get the same error on my Mac OSX or ArchLinux.

I would like to push some of my changes back, as I've managed to get the basic 
functionality 
working for updating and clearing the cart. I couldn't find a way to contact 
the project owner or 
request membership.

cart.py: Cart.update - so what exactly this method do ?

Hy, I have a very problem. When the User enters the site, django-cart create 
a table cart in database, but if the User leave the site, the table cart is 
still there. If a thousand users entering and leaving the site, the database 
will be very polluted, this is a serious problem because as I do to remove 
the table cart from the database when the User leave the site?

models.py:

class Item(models.Model):
    cart = models.ForeignKey(Cart, verbose_name=_('cart'))
    quantity = models.PositiveIntegerField(verbose_name=_('quantity'),
default=1)
    ....

cart.ry:

class Cart:
    ...
    def add(self, product, unit_price, quantity=None):
        try:
            item = models.Item.objects.get(
                cart=self.cart,
                product=product,
            )
        except models.Item.DoesNotExist:
            item = models.Item()
            item.cart = self.cart
            item.product = product
            item.unit_price = unit_price
            if quantity: item.quantity = quantity
            item.save()
        else:
            raise ItemAlreadyExists

...

    def update(self, product, quantity, unit_price=None):
        try:
            item = models.Item.objects.get(
                cart=self.cart,
                product=product,
            )
            item.quantity = quantity
            if unit_price: item.unit_price = unit_price
            item.save()
        except models.Item.DoesNotExist:
            raise ItemDoesNotExist

GPL'd code in the Django community is really annoying. This code looks
useful from the overview, but I really shouldn't look at GPL'd code because
I work on code that is closed source that may implement similar
functionality. Django is BSD licensed, and more permissive licenses are
much more useful to the community.

the queryset is missing an evaluator