Giter VIP home page Giter VIP logo

valmond's People

Contributors

n3tc4t avatar richardah avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar

valmond's Issues

Problematic control logic around peer count

My validator has 5 peers, configured via peer_private = 1 and ips_fixed. The configuration I am running was put into place with the help of talking to @alloynetworks. The lines of code that need to be adjusted are https://github.com/N3TC4T/valmond/blob/master/src/checks/validation.cpp#L96-L110.

I am not knowledgeable enough to know why 7 might have been chosen. I would be curious in knowing why 5 peers would be deemed non-optimal. My suggestion for a change is the following.

        if (serverInfo["peers"] > 7)
        {
            peersCheck["exit_code"] = 0;
            peersCheck["output"] = "Check Peer count OK: Peer count is greater than 7";
        }
        else if (serverInfo["peers"] <= 7 && serverInfo["peers"] != 0)
        {
            peersCheck["exit_code"] = 1;
            peersCheck["output"] = "Check Peer count WARNING: Peer count is less than or equal to 7";
        }
        else
        {
            peersCheck["exit_code"] = 2;
            peersCheck["output"] = "Check Peer count CRITICAL: Peer count is zero.";
        }

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.