Improve login handling about synology-api HOT 8 CLOSED

I looked into the behavior of the Authentication class a bit more and I think there are some more general issues:

1. Failed login attempts might only result in an unrelated error message (see above)
2. The returns for login() etc are not used anywhere, since the returns are never used. This should probably be prints instead (for debugging)
3. most other methods other then login() seem to use a fixed version: , although they should probably all use version: self._version
4. A failed login does not result in any exception, so the code continues and may result in the debug output You are now logged in!

from synology-api.

It surely needs to improve, I was working on error handling function as PR #100 suggest but I wasn't much into it.
Ill try to work on it and take your suggestion time permitting

from synology-api.

I will try to work on a pull request. Once I started looking into it it got just bigger then I originally thought, so it might take a couple of days to find enough time ;)

from synology-api.

lol me too, however I'll do my best to improve this part

from synology-api.

ok so based on PR #100 and very little changes I managed to let error codes work and implemented in all modules, I still need to add it for logout process.
I can upload to a new branck and if you want to test too would be great

check it out at error codes branch

from synology-api.

Ok, I will try to have a look this evening!

from synology-api.

I added a PR on the error_code branch: #108

from synology-api.

closed with PR #109

from synology-api.