/play pushit

Hi,
Below Discussion's properties are wrong:
String author
long id

It should be:
User author
String id

It appears that authentication has not been implemented yet, at least on the issues management code, am I correct?

Hi,
The UserService.getUserOrganizations no long working and I found out the diff in url from your latest commit.

7a54fcd#diff-7

-com.github.api.v2.services.userService.getUserOrganizations=http://github.com/api/{version}/{format}/user/show/{userName}/organizations

+com.github.api.v2.services.userService.getUserOrganizations=http://github.com/api/{version}/{format}/{userName}/organizations

Not sure though if you accidentally commit it.

Thanks.

Changing com.github.api.v2.services.dateFormat in ApplicationConstants.properties has no effect.
This is because RepositoryServiceImpl.getGsonBuilder() calls

gson.setDateFormat("yyyy-MM-dd'T'HH:mm:ss");

That overrides the value from ApplicationConstants.properties.
(quick fix suggestion - remove the line...)

Some fields in schema objects are not filled by gson. Added an underscore to some fields in Repository class:

@SerializedName("created_at")
@SerializedName("has_wiki")
@SerializedName("has_issues")
@SerializedName("has_downloads")```

Hi,
The return PullRequest object from PullRequestService.getPullRequest, I can't find the discussion object as stated at the http://develop.github.com/p/pulls.html. Or is there any other way to get the pull request discussion?

Thanks.

The description and homePage parameters to the RepositoryService.createRepository() method should be optional. Passing them as null results the following:

java.lang.NullPointerException
    at java.net.URLEncoder.encode(URLEncoder.java:205)
    at com.github.api.v2.services.impl.GitHubApiGateway.encodeUrl(GitHubApiGateway.java:539)
    at com.github.api.v2.services.impl.GitHubApiGateway.getParametersString(GitHubApiGateway.java:403)
    at com.github.api.v2.services.impl.GitHubApiGateway.callApiPost(GitHubApiGateway.java:312)
    at com.github.api.v2.services.impl.GitHubApiGateway.callApiPost(GitHubApiGateway.java:273)
    at com.github.api.v2.services.impl.RepositoryServiceImpl.createRepository(RepositoryServiceImpl.java:92)

Currently your sources carry library files which is bad practice if you use maven. The best approach is to link them as dependencies in in the pom.xml.

• gson can be linked using this example: http://mvnrepository.com/artifact/com.google.code.gson/gson/1.4
• jdom can be linked using this example: http://mvnrepository.com/artifact/jdom/jdom/1.0
• rome can be liked using this url: http://download.java.net/maven/2/rome/rome/1.0/

I receive strings ending with a newline character when using the OAuthService.getAccessToken() method. The authentication fails unless the newline is removed. The reason is this pattern in ApplicationConstants.properties:

com.github.api.v2.services.accessTokenPattern=access_token=([^&]+)(&expires=(\\d+))?

I tried changing the pattern to:

access_token=(\\w+)(&expires=(\\d+))?

and that works.

You should change the date format to : "yyyy/MM/dd HH:mm:ss Z"

An attempt to use the UserService.getUserOrganizations(String) will result in a URL like:

http://github.com/api/v2/json/thallgren/organizations?access_token=<my access token>

This used to work but apparently GitHub changed the API. In order to make it work, the URL must be:

http://github.com/api/v2/json/user/show/thallgren/organizations?access_token=<my access token>

Hi,
Great works. I tested it without any problems, except minor bug where I always get null for the job.getCreatedAt(). Is it happen to you?

Thanks

I get the following error everytime I try to access information related to a team within an organization.

{"error":"api route not recognized"}

Is there any quick fix available?

I'm trying to add a key using the UserService.addKey() method. The method executes OK but no key is added. I debugged this method and concluded that I indeed got a 401 response from the server. This error is however discarded since the addKey method just ignores the returned InputStream.

The callApiPost() will always return an InputStream regardless of success or failure so how is the caller of this method supposed to detect an error?

I created a fork of the sdk where I added OSGi bundle support. That entailed adding the OSGi Manifest, fixing some classpath issues, and removing the gson and junit jars.

https://github.com/cloudsmith/github-java-sdk

I'd be happy to contribute this if you find it interesting.

Hi,
Are you going to merge branch version-3.0 to master or you will maintain them separetely?

The UserService.getKeys() will issue a GET with a URL similar to:

http://github.com/api/v2/json/user/keys?access_token=XXX

The response from that is JSON data that starts with

{"public_keys": [{"title": ...

The getKeys() method then looks for "keys" instead of "public_keys" which always yields a null result.

If you try to create a team and add multiple repositories - only one is added. This is because of

for (String repoName : repoNames) {
      parameters.put("team[" + ParameterNames.REPO_NAMES + "][]", repoName);
}

You can't add multiple values with one key to a map. I'm going to work on a fix but, no telling how elegant it may be...

Test