nadikuts / react-native-pull-refresh Goto Github PK

Hi,

Is it possible for you to add a DefinitlyTyped version so that I can use the library in my typescript applications?

https://github.com/DefinitelyTyped/DefinitelyTyped

It's missing a check to fix the scrollable view to get disabled when the scrollY value is 0 after the second swipe down without refreshing the list, I will provide below the fixes to someone who wants to open a PR to fix it in master:

// line 146
            if (
                this.state.scrollY._value > 0 ||
                (this.state.scrollY._value === 0 && gestureState.dy < 0)
            ) {
                this.setState({isScrollFree: true});
            }

If you have an empty or small list, and scroll down, the animation disappears and onRefresh method is not called anymore.

proptypes no longer avalible in react

If I dont have enough list items, the animationBackgroundColor is shown in the background.

Wondering if this will ever consider implementing a horizontal pull to refresh. I cannot seem to find anything that does it.

Hello, help me please!!

yarn add installs an older version of the code which does not work.

Not working anymore, need to update in the package manager, there are some error because you used old versions,however it was easy to solve them manually!...

Just import the proptypes according the new version....
and replace react.proptypes into PropTypes 👍

But as soon as I scroll even a little bit down, taps will trigger onPress in the children?

Any idea what could cause those events in children not to fire?

I know FlatList has built in pull-to-refresh functionality, but I have yet to find a way to override it with something other than the default. Since FlatList is based on ScrollView should it work?

This change appears to make the library work for iOS. Perhaps the "Android" only indicator in the readme should be removed?

#43

Hi @NadiKuts,

your solution looks really promising. I have not played around with it pretty much yet, but I have two questions already:

• does it work with a Webview, where the Webview takes 100% of the Screen Size. Which means the user should still be able to scroll to the top of the WebView.
• and do you plan do support iOS in the future?

Regarding the Webview, it would be possible to get the scroll position (eg. user is at the top of the page or not) from the Webview (with onMessage etc.). Still I would need a way to tell your component to only trigger the PTR when a certain condition is met (eg. scroll top is 0).

Can you help me out here please? Thanks.

Does support load more？