naelstrof / maim Goto Github PK

On Ubuntu at least, with xclip I had to modify the line to read:

xclip -sel clip instead of xclip

https://gist.github.com/shmup/c1f9939a2c20b26e78ee/revisions

I realize this isn't your issue, but you do link to the script and I wanted to maybe help somebody else.

I have looked at a few source files for your current software. I have noticed that some checks for return codes are missing.

Would you like to add more error handling for return values from functions like the following?

• fprintf ⇒ write_into_file
• malloc ⇒ main

The only way maim works for me on OSX is by specifying --windowid, otherwise I'm getting empty black images, with just the cursor visible. However combining with slop, -s, I always get black shots with just the cursor visible.

$ maim -i $(xdotool getactivewindow) test_maim.png  # Works!

$ maim -s -i $(xdotool getactivewindow) test_slop.png  # Black image with cursor only
$ maim -s --localize -i $(xdotool getactivewindow) test_slop.png  # Black image with cursor only

It is v3.3.39 instead, so downloading via link:

--2014-11-30 17:41:33--  https://github.com/naelstrof/maim/archive/v2.3.39/maim-2.3.39.tar.gz
Resolving github.com (github.com)... 192.30.252.129
Connecting to github.com (github.com)|192.30.252.129|:443... connected.
HTTP request sent, awaiting response... 302 Found
Location: https://codeload.github.com/naelstrof/maim/tar.gz/v2.3.39/maim-2.3.39 [following]
--2014-11-30 17:41:33--  https://codeload.github.com/naelstrof/maim/tar.gz/v2.3.39/maim-2.3.39
Resolving codeload.github.com (codeload.github.com)... 192.30.252.147
Connecting to codeload.github.com (codeload.github.com)|192.30.252.147|:443... connected.
HTTP request sent, awaiting response... 404 Not Found
2014-11-30 17:41:34 ERROR 404: Not Found.

fails.

Some parameters (like "${IMLIB2_INCLUDE_DIR}") are passed to CMake commands in your build script without enclosing them by quotation marks. I see that these places will result in build difficulties if the contents of the used variables will contain special characters like semicolons.

I would recommend to apply advices from a wiki article.

You limited compiler support on GNU software with your introduction of a CMake build script.

I suggest to lift this restriction. More tools can be easily supported also if a variable like "CMAKE_CXX_COMPILER_ID" will be checked, can't it?

everytime when i take a screenshot, it will create image file at ~/your-png-file
but i want it create image file at ~/my-specified-folder/your-png-file by default

is there anyway to do it??

Hey,

I've been using maim for a while but I never asked myself if it could take compton's shadows with a selected window.
If it is possible I'd love to have this feature made available.

If you don't what I mean here's an example:

But now with shadows.

This is using maim -s ~/screenshot.png.

I don't get any problems when selecting a whole window, or when screenshotting the whole screen.

A specific commit shows also how many source code places are changed when version information should be updated for this software.

I suggest to reduce corresponding efforts for the maintenance of such version data by the reuse of a dedicated input file. How do you think about to distribute details from there to other file templates with the help of the CMake build system?

When i run maim, it shows this error message:

Invalid MIT-MAGIC-COOKIE-1 keyError: Failed to open X display :0
Failed to grab X display!

Installed from the repos on Arch Linux.

How about allowing resizing of region before taking the snapshot? At the moment, it is near impossible to take a snapshot of a selected region if the region is big enough that moving your pointer from one corner of the trackpad to the opposite is not enough to cover this region. Since it's not yet possible to resize the region before taking the screenshot by releasing the mouse button, this is a problem.

When using --windowid instead of specifying the geometry manually, maim seems to not take the position of the specified window into account. The resulting images are partially cut-off and filled with transparency.

my use case for maim at the moment using using it w/ i3 to exec maim -s and take a screenshot, then fetching the file from my home directory.

I'd love to be able to set a destination directory for the resulting images that isn't my home directory. I looked through the man page and didn't see anything to this effect.

scrot has a way to visually show the countdown, like so:

You can see so in the manpage that the -c option provides this, and you need to use this with the -d option; scrot -cd 5

       -c, --count
            Display a countdown when used with delay.

       -d, --delay NUM
            Wait NUM seconds before taking a shot.

maim does only have the delay option. My feature request, I guess, is to add an option to do visual countdown. The -c option is used with slop though I think so maybe it's necessary to find another option to use. -c would be convenient since it's the same for scrot, though.

  -d, --delay=FLOAT             Set the amount of time to wait before taking an
                                  image.  (default=`0.0')

http://pastebin.com/Ja2MWHMm

REFERENCES:

• http://www.linux.org.ru/forum/desktop/12928579

https://i.imgur.com/h26F6sY.png (since github doesn't want to upload it)

Whenever I take a selection screenshot now the dim for the selection just stays.

I run maim on Arch Linux and got this error:
"Inconsistency detected by ld.so: dl-version.c: 224: _dl_check_map_versions: Assertion `needed != ((void *)0)' failed!"

I'd like to be able to output screenshots to stdout.

$ maim "~/Pictures/$(date +%F-%T).png"
Failed to save image /Pictures/2014-10-20-00:19:11.png: path component is non-existant ( isn't expanded inside quotes!)
Failed to take screenshot.

Whereas,
$ maim ~/Pictures/$(date +%F-%T).png
Works fine. Shouldn't we remove the quotes from the example then?

I expect that exception handling is usually supported by a C++ program. I wonder why your function "main" does not contain corresponding try and catch instructions so far.

How do you think about recommendations by Matthew Wilson in an article?

Would you like to adjust the implementation if you consider effects for uncaught/unhandled exceptions like they are described by Danny Kalev?

I use sxhkd to bind ctrl + Print to 'maim -s ~/screenshots/$(date +%F-%T).png'.
This works, but the resulting screenshots have a dark tint, apparently because maim takes a screenshot while the grey overlay of slop is still visible.
This does not happen when I use maim without slop to capture a fullscreen screenshot.
Example screenshot:

I don't have the system to test a feature like it so I haven't added it.

For those of you who actually use twinview or dualhead you're going to have tell me this feature is actually wanted and I'll look into it further.

No error is given, here's an example output:

http://nylen.tv/maimed.jpg

Basically, cd /tmp; maim -s fails because /tmp is not own by current user.

You may want to use access(dirname, R_OK | W_OK)

I suggest to correct the handling around the programs "gengetopt" and "cp" by the reuse of the CMake functionality "add_custom_command".

I don't know if it's slop or maim issue.

I'm using i3wm, when i "click" in a window with maim -s screenshot is in right size... but completely empty.

Selecting by mouse sliding works perfectly.

When I try to run maim -s and mouse is over any window and I select it maim gives an error:

X Error of failed request:  BadMatch (invalid parameter attributes)
  Major opcode of failed request:  73 (X_GetImage)
  Serial number of failed request:  25  
  Current serial number in output stream:  25  

Problem doesn't appear when mouse is over lemonbar and then I select the window I'd like to print (bspwm@arch).
video

Error detection and corresponding exception handling is missing in the script "generateReadme.sh".
I suggest to reconsider corresponding possibilities with CMake.

Hello. I've done the test in my three desktop environments at Linux Mint 17.1
imlib2 version is 1.4.6-2 from repository

I'm using most tiling WMs since my Cinnamon started to act weird (only in 3D acceleration though, so I could test it using software rendering). Mostly BSPWM but I have StumpWM as well so I tested it into both. I've noted that my screenshots (I usually use Poomf script for uploading them in a puu.sh-style) were being uploaded as blanks. So I started testing what was up.

Running maim --hidecursor or maim produced blanks. However using coordinates (-h -w -x -y) or using slop mode with -s just worked fine. To complete this I've tried taking a shot with ImageMagick (import -window root ) and it just worked fine. Then I re-installed imlib2 and tried all again. So I went from BSPWM from Cinnamon and tried maim --hidecursor and maim and well, it worked too. So I decided to try StumpWM and... curiously I've got the same problem as BSPWM.

So I think it's something specially ocurring with tiling WMs (maybe because they use a tree approach to rooting windows and tiling them instead of a root workspace with grips and floating windows with no parental relationship. Dunno, only my guess). Please let me know if I can contribute with any additional information.

Some commands are used to update the file "README.md".

• How do you think about to work with another template file? Would it eventually be better and safer to reuse the CMake functionality "configure_file"?
• If you insist on in-place modification here, I suggest to drop the variable "MODIFIED_FILE_CONTENT" because of the detail that a direct use of the variable "FILE_CONTENT" would be sufficient there, wouldn't it?

maim used to work fine on my system. I use arch linux. I updated my system and now have gnome 3.22. gnome 3.22 uses wayland by default. Since that update maim produces black images. the images have the same resolution as my screen. 1280x800.

Please confirm whether this is a problem with wayland or just a problem on my system.

$ maim --version
maim v3.4.47

Copyright (C) 2014 Dalton Nell, Maim Contributors
(https://github.com/naelstrof/maim/graphs/contributors)

$ uname -a
Linux lestop 4.8.4-1-ARCH #1 SMP PREEMPT Sat Oct 22 18:26:57 CEST 2016 x86_64 GNU/Linux

$ gnome-shell --version
GNOME Shell 3.22.1

Please tell me what more information do you need.

can not find how to set quality of output image in jpg format output file

When i launch maim with a hotkey in a dota2 game (in the menu it works fine) nothing happens, slop's selection isnt even popping up.

I'm fairly sure this is caused by Dota already grabbing the pointer so slop cant do it.

This is a suggestion to bring maim more in inline with scrot. At least
personally and all the people I've spoken to, the default of showing the mouse
pointer only seems to only get in the way of the content (troubleshooting). It
would be nice if either --hidecursor was made the default operation or a more
convenient shortopt was provided.

A workaround for now is to use aliases or wrapper scripts.

i love the maim and slop combination. unfortunately, I had to create this ugly hack to implement a delay instead of just using --delayoption because i want feedback to the user that the screenshot is about to be taken...

eval $(slop --nodecorations)
notify-send --expire-time=1000 "taking screenshot in 3 secs"; sleep 1
notify-send --expire-time=1000 "taking screenshot in 2 secs"; sleep 1
notify-send --expire-time=900 "taking screenshot in 1 secs"; sleep 1
maim -g $G "$snapsdir/$snap"

i'd prefer to use maim --select --delay 3, but then there's no visual indication that the screenshot is about to be taken...

could we have some sort of "CHEEEEEEEESE" visual output before actually taking the screenshot with --delay?

thanks!

I suggest to reuse a higher level build system than your current small make file so that powerful checks for software features will become easier.

• CMake
• Autotools

 static const char *stopbg[]     = { "systemctl", "--user", "stop", "feh-wallpaper.timer", NULL };
-static const char *scrot[]      = { "scrot", NULL };
+static const char *maim[]       = { "maim", NULL };
 static const char *termcmd[]    = { "st", "-c", "st-256color", "-e", "dvtm", "-M", NULL };
 static const char *trans[]      = { "trans-exempt.sh", NULL };

I tried to switch from scrot to maim for my screenshot tool, but maim doesn't seem to like the way in which dwm is invoking it. Scrot works fine under this setup, nothing happens with maim.

Hello,

Earlier today I tried to install maim on Linux Mint. I got this error and it didn't install:
[ 25%] Building CXX object CMakeFiles/maim.dir/src/im.cpp.o
/home/sebastiaan/maim/src/im.cpp: In member function ‘int maim::IMEngine::blendCursor(Window, int, int)’:
/home/sebastiaan/maim/src/im.cpp:135:39: error: variable-sized object ‘pixels’ may not be initialized
DATA32 pixels [ size_px ] = { 0x0 };
^
make[2]: *** [CMakeFiles/maim.dir/src/im.cpp.o] Error 1
make[1]: *** [CMakeFiles/maim.dir/all] Error 2
make: *** [all] Error 2

I've installed all of the required tools and programs.

If there's no copy of the GPL included in the source code, anyone that forks the repository is violating the license.

Warning: Command gengetopt or sed not found! Won't regenerate command line code. 
...
$which sed
/bin/sed

i'm using Ubuntu based Linux MInt.

As gcc pointed out:

main.cpp:140:53: warning: format ‘%i’ expects argument of type ‘int’, but argument 7 has type ‘char*’ [-Wformat]

This has the effect of passing the pointer's numeric value to slop, resulting in an invocation like slop -b 5 -p 0 -t 2 -g 32358608 -c 0.5,0.5,0.5,1 --min=0 --max=0

I tried to address this in #5 but that approach introduces other issues, so I'm not sure what the preferred fix would be.

The default filename format includes :, which is problematic for certain unfortunately popular filesystems. Perhaps these could be removed (so it's just %H%M%S)? I think the format is still pretty clear without them.

example:

$ maim -s --color=$(printf '%0300d' 1),1,1,1` foo.png

*** buffer overflow detected ***: maim terminated

etc

$cmake ./                                                                                    
-- Regenerating cmdline.in
CMake Error at /usr/share/cmake-2.8/Modules/FindPackageHandleStandardArgs.cmake:108 (message):
  Could NOT find OpenGL (missing: OPENGL_gl_LIBRARY OPENGL_INCLUDE_DIR)
Call Stack (most recent call first):
  /usr/share/cmake-2.8/Modules/FindPackageHandleStandardArgs.cmake:315 (_FPHSA_FAILURE_MESSAGE)
  /usr/share/cmake-2.8/Modules/FindOpenGL.cmake:161 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
  CMakeLists.txt:109 (find_package)
$cmake --version    
cmake version 2.8.12.2

I'm using Linux Mint. How can i fix it?

I'm was trying to capture a single window using maim -s, but while the screenshot seem to be of the correct size, it's actually black after a certain position.

The coordinates reported by slop though seem correct. In fact, running maim -g $(slop -f%g) works perfectly.

It seems that using window IDs instead is broken in maim itself. maim -i $(slop -f%i) has the same issue as maim -s when just selecting a window.

How do you install this on Ubuntu? Couldn't find it in the repositories

There is a small misinformation in examples: the README.md and the help suggest that the command to take a screenshot of the active window is maim -id $(xdotool getactivewindow) when it should be maim -i $(xdotool getactivewindow).

The README says:

maim can actually take screenshots with your cursor included in them! It does this using the XFixes extension. I don't think there's any other screenshooters that do this.

KSnapshot 0.8.1, KDE's screenshot tool, has an option "Include mouse pointer" which acts as expected.
Therefore, you might want to change above sentence to "To my knowledge, no other commandline screenshot tool does this." or something similar. (While KSnapshot has a few commandline options, the pointer option can only be changed in the GUI).

maim foobar.png consistently segfaults for me. I don't know why. I'm running recently updated Arch with bspwm for windows manager. I tried stracing the command, but it's mostly gibberish to me. It keeps repeating this error:

recvmsg(3, {msg_name(0)=NULL, msg_iov(1)=[{"\1\1!\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0", 4096}], msg_controllen=0, msg_flags=0}, 0) = 32
recvmsg(3, 0x7fff612954e0, 0)           = -1 EAGAIN (Resource temporarily unavailable)
recvmsg(3, 0x7fff612954e0, 0)           = -1 EAGAIN (Resource temporarily unavailable)
poll([{fd=3, events=POLLIN|POLLOUT}], 1, 4294967295) = 1 ([{fd=3, revents=POLLOUT}])
writev(3, [{"\214\24\3\0O\0\0\0\\W\0\0", 12}, {NULL, 0}, {"", 0}], 3) = 12
poll([{fd=3, events=POLLIN}], 1, 4294967295) = 1 ([{fd=3, revents=POLLIN}])
recvmsg(3, {msg_name(0)=NULL, msg_iov(1)=[{"\1\0\"\0\3\0\0\0\\W\0\0\0\0\0\0\0\5\0\4T\0\0\0\1\0?\0\1\0\2\0"..., 4096}], msg_controllen=0, msg_flags=0}, 0) = 44
recvmsg(3, 0x7fff61295db0, 0)           = -1 EAGAIN (Resource temporarily unavailable)
recvmsg(3, 0x7fff61295db0, 0)           = -1 EAGAIN (Resource temporarily unavailable)

and then the segfault happens. maim version is 3.4.43. I suspect that the issue might be in my setup, since this version was out for a long time and somebody would have noticed by now that it doesn't work on archlinux.

How can I help?