naftis / number-minify Goto Github PK

Pros:

• It would make using the library more easy and trivial

Cons:

• Underlying algorithm doesn't support it by default (the mapping to letters has to start from somewhere), so negative numbers don't get encoded to strings. Now the minus sign is just prefixed to the number. Alternative would be starting the mapping from Number.MIN_SAFE_INTEGER which would add a lot of unnecessary letters when using positive numbers.
• Default use case uses positive numbers (?)
• User might not expect the output having a minus sign when character set doesn't have it by default

For now I think the feature should be opt-in as it is right now.