nager / nager.articlenumber Goto Github PK

ArticleNumberHelper.GetArticleNumberType("849172008847 ") is reported as type EAN13 but I think it should be unknown or maybe UPC (if the traling space is ignored)

ISSN is similar to ISBN but used for series instead of individual editions.

http://www.issn.org/understanding-the-issn/what-is-an-issn/

Hello,
I was thinking about extending your library to do conversions from UPC to GTIN-14. Would this be something you'd want to pull into your repo?

Thanks,
Jason

I tried this:
Nager.ArticleNumber.ArticleNumberType articleNumberType = Nager.ArticleNumber.ArticleNumberHelper.GetArticleNumberType("9783551775849");

articleNumberType was recognized as ArticleNumberType.Ean13 but it is actually a ArticleNumberType.Isbn13 (Prefix 978)

But
if (Nager.ArticleNumber.ArticleNumberHelper.IsValidIsbn13("9783551775849"))
and
if (Nager.ArticleNumber.ArticleNumberHelper.IsValidEan("9783551775849"))
both are true...

2 Issues:

1. ArticleNumberHelper.GetArticleNumberType does not recognize ArticleNumberType.Isbn13 but ArticleNumberHelper.IsValidIsbn13 does
2. ArticleNumberHelper.IsValidEan does recognize ArticleNumberType.Isbn13 as EAN

IsValidIssn throws exception on string "1234ffsfe" but should have returned false.