nah-mnnu / mnnu-mobile Goto Github PK

For an explanation with which benefits form templates come, read https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/about-issue-and-pull-request-templates#issue-templates.

To configure, read: https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/configuring-issue-templates-for-your-repository#creating-issue-forms

Is your feature request related to a problem? Please describe.

At the moment, the app is huge for what it offers: between 70 and 100MB. This also may mean a lot of performance improvements can be made.

Describe the solution you'd like

You can try reducing the app size by following some best practices, as well as some other tips given by developers:

• https://stackoverflow.com/questions/60630065/how-to-reduce-android-apk-size-in-react-native
• https://medium.com/@aswinmohanme/how-i-reduced-the-size-of-my-react-native-app-by-86-27be72bba640
• https://www.google.com/search?q=reduce+app+size+react+native

Describe alternatives you've considered

Takes a lot of work, but: switching to Java/Kotlin as language, if possible.

Describe the bug
On the third slide of the onboarding, the spacing between the title and the image is too little.

To Reproduce
Steps to reproduce the behavior:

1. Open the app for the first time
2. Go to the third slide
3. See how there should be more space between image and title

Expected behavior
There should be more space between the title and the image.

Screenshots

Smartphone (please complete the following information):

• Device: Pixel 5
• OS: Android 12.0

User story
As a user I'd like to see more space between the title and the image so that it is easier to read.

Is your feature request related to a problem? Please describe.

In case your phone breaks, you may lose access to your wallet and its content. With an export/back-up feature, you'll be able to export the wallet to another phone for example.

Describe the solution you'd like

Some sort of solution like a QR-code, for example as how Google Authenticator does it. This can include a list of items (e.g. permissions, first name, last name) that you can select, whether you'd like to include that in the back-up or not. Also, make sure the user can set a password for end-to-end encryption.

Describe the bug
When opening the app for the first time and choosing a language, the languages aren't centered properly when the button width is increased from default. The button is centered from the start of the button instead of from the center.

To Reproduce
Steps to reproduce the behavior:

1. Use the app for the first time
2. Click on 'Dutch'
3. See how the buttons aren't aligned in the center properly

Expected behavior
The buttons should be centered in the center instead of from the start.

Screenshots

Smartphone (please complete the following information):

• Device: Pixel 5
• OS: Android 12.0

User story
As a user I'd like to see the buttons centered when changing language.

Is your feature request related to a problem? Please describe.

Sometimes it happens that PRs are not properly formatted, or that there's only a limited explanation available in the description of the PR.

Describe the solution you'd like

Add PR templates to enhance what PRs will look like. It also adds consistency across PRs and there should be more details available in a PR, because users will get to know what they need to fill in.

Is your feature request related to a problem? Please describe.

Currently, it's required to create a release manually, including generating the changelog and uploading an asset (which is an APK). This requires time and effort.

Describe the solution you'd like

A workflow that does this automatically when merging changes to main, something like https://github.com/nah-mnnu/MNNU-Mobile-deprecated/blob/main/.github/workflows/build.yml for building, https://github.com/marketplace/actions/automatic-releases, or https://github.com/marketplace/actions/automatic-release-with-assets.

Is your feature request related to a problem? Please describe.

The app does not require you to choose a complex PIN. This means that you can just choose 123456 as PIN, which is far from safe.

Describe the solution you'd like

Don't allow easy PINs such as 123456, 012345, 000000 or a related combination.

User story

As a CSC-student I'd like that a user should not be able to use an easy PIN, as it'd to impact the security of someone's wallet.

Is your feature request related to a problem? Please describe.

Related to #6: it may be possible that incorrect patient credentials have been made/issued by a zorgverlener and that these credentials have been sent to the patient. Because it's SSI, the patient should decide about its own identity/credentials.

Describe the solution you'd like

A feedback button next to the screen of a credential offer, creating the possibility for a patient to send a request for the correction of its identity/credentials.

Describe alternatives you've considered

Send an email, manually requesting for a correction of personal information/credentials.

Is your feature request related to a problem? Please describe.

In case someone with NAH (non-congenital brain disorder) is unable to manage credentials him or herself, the user should be able to delegate permissions to its parent/guardian/carer.

Describe the solution you'd like

Create a process where a parent/guardian/carer will be able to decide over the user's/patient's credentials.

Additional context

We have talked about it before, and we're not sure if it's technically possible, but it should be noted that if this feature gets implemented, it's not fully SSI anymore.

Is your feature request related to a problem? Please describe.

It may be possible that incorrect patient credentials have been made/issued by a zorgverlener and that these credentials have been sent to the patient.

Describe the solution you'd like

A textbox/notification (see screenshot below) that should tell/request the patient to check its credentials/information.

Additional context

Is your feature request related to a problem? Please describe.

To protect medical information from being shared to unauthorised people, we should implement a function that prevents the user from being able to make a screenshot within the app. Of course it'd still be possible to make a photo of the smartphone, but this implementation at least makes it harder to share medical/confidential information with outsiders.

Describe the solution you'd like

Making use of a React Native library that prevents users from making screenshot (just like how you can't take a screenshot in the CoronaCheck or ING app). We should be able to use either https://github.com/Yatanvesh/react-native-prevent-screenshot-android or https://github.com/SnowLew/react-native-screenshot-prevention (recommended to read both to check which implementation fits best for our needs.)