namesco / roundcube-plugin-recipient-to-contact Goto Github PK

The recipient-to-contact plugin appears to be broken for 0.8-rc. A window pops up but after a moment, the user is logged out with "Your session is invalid or expired".

I've not extensively tested, but changing the 3 references to $rcube_imap->decode_address_list to rcube_mime::decode_address_list prevents the PHP fatal error when running with RoundCube 1.2.

Shortcuts are not disabled when dialog is opened preveting from filling the form

When use this plugin with roundcube 0.9.5 and "larry skin".
After the dialog to save a contact the message Loading ...
still in status bar from mail menu.

config.inc.php

$rcmail_config['recipient_to_contact_addressbooks'] = array();
$rcmail_config['recipient_to_contact_enabled_by_default'] = false;
$rcmail_config['recipient_to_contact_use_groups'] = false;

as said @Halfwalker in #14 , if address are not added and cassuality there's and address book readonly, the forms will continue to show and offers in every reload of the mail tab...

this error may be the cause of the #14 due contact are not checked in all contact list,

that its happened due when u retrieve the lists, only retrieve those can write, and of course, the results are that contact are not in "currently retrieved" lists.. but still are in the read-only list ..

this are in the line 363 of recipient_to_contact.php , so if contact are not in any list retreive here.. will offer to added to personal list.. but contact already are, but the list not retrieved are readonly or are not specify in the config files or default adressbooks

Sometimes, when you close the dialog and reload the inbox (by either reloading the page, clicking in "Mail", or clicking the RC logo) the dialog reappears.
This occurs because of the following:
Whenever there is an ajax request that starts before the plugin.recipient_to_contact_get_contacts request ends, and also ends after it, then the session variable (recipient_to_contact) that is removed by the get_contacts request, is overwritten by the other request. To explain it better:

• Request X starts and loads the recipient_to_contact session variable which is not empty
• Request get_contacts starts and loads the same variable
• Request get_contacts ends and removes recipient_to_contact from session and stores the session
• Request X ends and stores the recipient_to_contact variable it loaded when it started
  In my case, request X is usually the "getunread" request.

To solve this, I had 2 ideas:

1. Use cookies to store the recipient_to_contact array instead of session variables.
2. Send an additional request, when closing the dialog, that resets the recipient_to_contact variable.

Only sort of an issue. I think R-T-C needs to check all addressbooks of a particular type for the contact info before offering to save as a new contact. For example, in my configuration I have

main.inc.php - autocomplete_addressbooks = array('sql');
config.in.php - recipient_to_contact_addressbooks = array();

I'm also using the google_addressbook plugin, which creates a "Google Addressbook" addressbook, stored in mysql (contacts_google table) synced down from Google.

When sending an email to somone from the google contact list, R-C-T still pops up and offers to save the info. So it's not checking the google addressbook.

While I don't currently use ldap, I can definitely see a situation where some might be using more than one ldap directory. Would R-T-C check all of them ?

i have using global_adressbook plugin and when user dialog appears, r-t-c permits user to write into global address book,

i search in code and see that funtion "get_addressbooks(array ids, writable=false)" dont make sense on "writable" flag in your function

so then in config file must be a oiption to parse this flag to plugin and could set!

Add ability to specify a Contact Group when adding new contacts

Hi,

I find that, at least in recent versions of Roundcube (1.4.x), when using this plugin, Recipient To Contact, if I have Roundcube configured to compose new emails or reply emails in a new window, once the email is sent, when the plugin dialog should appear requesting the contact information to add, it does not appear.

But I have verified that if after sends the email I press the Mail button (in the main menu) to reload the email list, the plugin dialog box mysteriously appears, apparently hidden and waiting. If I complete the form data and press the Save button, the new contact is saved, but the Loading message remains active at the bottom of the Roundcube window.

If instead of having Roundcube configured to compose or answer emails on a new window, I disable that option, the plugin works correctly.

Is there a chance that they will review this issue?

Thanks in advance

hai,

I am configured it properly as per your instructions and the plugin not working in my cPanel.

Any Idea 👍

I'm using RoundCube version 0.6 and recipient_to_contact plugin version 0.2.

I'm always logged out just before I can click to save button. The page is not totally loaded when I'm logged aout with a "Session expiration" error message.

With Roundcube in version 0.5.3 there is a server error "Not found" when the plugin appears after sending a mail and when I'm trying to save a new address. It's not possible to save a new address. Sometimes I also got logged out. I'm using release 0.2 and also the plugin 'global_addressbook'.

When I save the current preferences option "Use recipients to contacts plugin" again, then I got a saving error. Because the option is currently set there is no problem for using the plugin, but it is confusing. There is nor error when saving the opposite option.

this plugin causes the email not to able to send with my recently updated roundcube 1.2.1
anyone aware of a fix?

Compose_newwindow doesn't reload the page, when an email has been sent. That is, the plugin's JS isn't even loaded and no new recipients are captured.

Need to find workaround for this.