Giter VIP home page Giter VIP logo

keyrace's Introduction

👋

keyrace's People

Contributors

ashtom avatar dend avatar jessfraz avatar krausefx avatar nat avatar skylerwiernik avatar

Stargazers

avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar

Watchers

avatar avatar avatar avatar avatar

Forkers

jessfraz naytri ashtom yousefhamza skylerwiernik chrisxu taroyuyu zfauser talemache shyamalschandra elvisbyron galandreka manny27nyc daiyin1981 bcmp2005 garik1818 cyberflamego jpbfrca4 parsy346 drbilal12

keyrace's Issues

Ability to export to CSV/JSON

Content is already stored internally - would be neat to export to CSV/JSON for further historical analysis (e.g. in a Jupyter notebook).

Happy to contribute with a pull request and use this issue as a tracking item, but want to make sure I am not stepping on anyone's toes if this is already planned.

server: unbuffered signal channel could cause signal not to be delivered

Coming here from auditing

keyrace/server.go

Lines 281 to 283 in dab1b87

signals := make(chan os.Signal)
signal.Notify(signals, os.Interrupt)
signal.Notify(signals, syscall.SIGTERM)

which is a bug as documented in os/signal https://golang.org/pkg/os/signal/#Notify as per:
Screen Shot 2020-11-30 at 9 15 04 PM

For Go1.17, my team is going to release a static analyzer that'll be included when you run go test as per golang/go#9399, but for now, please make that channel buffered.

Our internal static analyzer reports this:

$ sigchanyzer ./server.go 
github.com/nat/keyrace/server.go:282:2: misuse of unbuffered os.Signal channel as argument to signal.Notify

/cc @cuonglm

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.