Giter VIP home page Giter VIP logo

wikiquotes-api's People

Contributors

egeland avatar natetyler avatar parklize avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

wikiquotes-api's Issues

Hi

Is it possible to give an simple example to use one of your fabulous function?

Wikipedia now enforces HTTPS

Hi, this module is still using HTTP as the base API url , so the example app doesn't work for me because Chrome blocks this request.

Also the API response format seems to be changed, so even when it gets the response it can't parse it.

Missing out on text inside anchor tags

If a quotation contains anchor tags, getQuotesForSection will strip out the text within the tag and the quote will often make no sense. Suggest retaining the <a> tags and pushing the text content, rather than the html, to quoteArray.

$(this).children().remove(':not(b,a)');
var $bolds = $(this).find('b');

// If the section has bold text, use it.  Otherwise pull the plain text.
if ($bolds.length > 0) {
    quoteArray.push($bolds.text());
} else {
    quoteArray.push($(this).text());
}

Pushing the jQuery text used as a quick way to remove the anchor tag while retaining it's contents, which worked out for me, but may have consequences I didn't forsee,

getRandomQuotes doesn't handle Wikiquote error

error

When getRandomQuotes causes Wikiquote to return this error, the error is sent to $.ajax's success function (as result), which tries to access its parse property, which is undefined.

success: function(result, status) {
        var quotes = result.parse.text["*"];

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.