nathan-osman / rust-sunrise Goto Github PK

There's an error in coordinates that are used in the usage example in the readme file.

The readme gives the following example

// Calculate times for January 1, 2016 in Toronto
let (sunrise, sunset) = sunrise::sunrise_sunset(
    43.6532,
    79.3832,
    2016,
    1,
    1,
);

However, the valid coordinates for Toronto in Lat Lng format are 43.6532, -79.3832. Therefore the example above should be written this way:

// Calculate times for January 1, 2016 in Toronto
let (sunrise, sunset) = sunrise::sunrise_sunset(
    43.6532,
    -79.3832,
    2016,
    1,
    1,
);

It took me a bit of time at first to figure out why computations were incorrect.

I'd love to use this crate for a crate that provide an engine for OSM's opening hours, but it can be based on dawn and dusk. I'd be willing to make a PR that implement this change but I need some help understanding where to make a change. (This may also motivate to change a bit the API if there is more values to output).

Wikipedia defines "civil dawn" as follow:

Civil dawn begins when there is enough light for most objects to be distinguishable, so that some outdoor activities can commence. Formally, it occurs when the Sun is 6 degrees below the horizon in the morning.[4]

So this is seems it is just about adding / removing a 6° angle somewhere, should it be directly added / removed the sun declination, $\delta$ ?

Thanks for implementing this function.

However from reading the documentation I see that the function returns a tuple of i64. I do not yet understand how this i64 is representing a sunrise/sunset time. What is the encoding.

More specifically, how to convert this into something like a chrono::naive::NaiveTime

I've found your crate of sunrise/sunset equation implementation exactly what I need in my embedded project. :)

Would you consider releasing a newer version of your package after time dependency removal?